From: Krzysztof Kozlowski <krzk@kernel.org>
To: Viken Dadhaniya <quic_vdadhani@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
linux-arm-msm@vger.kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: quic_msavaliy@quicinc.com, quic_anupkulk@quicinc.com
Subject: Re: [PATCH v1] arm64: dts: qcom: sa8775p: Add UART node
Date: Thu, 11 Jul 2024 08:17:39 +0200 [thread overview]
Message-ID: <b2c88f85-eefb-411c-bfe0-6a476b449753@kernel.org> (raw)
In-Reply-To: <fa189b4c-d407-4d48-9677-528f07f81efa@quicinc.com>
On 11/07/2024 07:04, Viken Dadhaniya wrote:
>>>> + clock-names = "se";
>>>> + interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
>>>> + &clk_virt SLAVE_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS>,
>>>> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
>>>> + &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ALWAYS>;
>>>> + interconnect-names = "qup-core", "qup-config";
>>>> + power-domains = <&rpmhpd SA8775P_CX>;
>>>
>>> All the clocks, interconenct and power domains look to me questionable.
>>> AFAIK, most of it (if not all) is going to be removed.
>>
>> Yeah.. I'm lukewarm on accepting any sa8775p changes until that qcs9100(?)
>> situation is squared out first
>>
>> Konrad
>
> Thanks for clarification. Please help to sign-off or let me know in case
> of any concern.
I think I was quite explicit, so I feel above suggestion as still
pushing your choice even though to reviewers gave you their opinion.
In such case:
No, NAK, for the reasons stated above.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-11 6:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 9:41 [PATCH v1] arm64: dts: qcom: sa8775p: Add UART node Viken Dadhaniya
2024-07-10 9:47 ` Krzysztof Kozlowski
2024-07-10 10:39 ` Konrad Dybcio
2024-07-11 5:04 ` Viken Dadhaniya
2024-07-11 6:17 ` Krzysztof Kozlowski [this message]
2024-07-12 9:32 ` Viken Dadhaniya
2024-07-12 17:16 ` Krzysztof Kozlowski
2024-07-29 10:47 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c88f85-eefb-411c-bfe0-6a476b449753@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_anupkulk@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).