From: Georgi Djakov <georgi.djakov@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Ilia Lin <ilia.lin@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Sricharan R <sricharan@codeaurora.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding
Date: Wed, 22 Apr 2020 18:26:06 +0300 [thread overview]
Message-ID: <b2dad165-39f8-afb7-2bf8-74fa0239798a@linaro.org> (raw)
In-Reply-To: <20200422140827.1726-1-ansuelsmth@gmail.com>
Hi Ansuel,
On 4/22/20 17:08, Ansuel Smith wrote:
> Binding has changed from operating-points-v2-kryo-cpu to
> operating-points-v2-qcom-cpu. Also check for old binding in driver
> probe.
>
> Fixes: a8811ec764f9 cpufreq: qcom: Add support for krait based socs
The correct format is: Fixes: %h (\"%s\")
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/cpufreq/qcom-cpufreq-nvmem.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> index a1b8238872a2..8a0411efc79a 100644
> --- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
> @@ -278,6 +278,10 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
> return -ENOENT;
>
> ret = of_device_is_compatible(np, "operating-points-v2-qcom-cpu");
> + if (!ret)
> + ret = of_device_is_compatible(np,
> + "operating-points-v2-kyro-cpu");
There is a typo in the compatible string.
Thanks,
Georgi
> +
> if (!ret) {
> of_node_put(np);
> return -ENOENT;
>
prev parent reply other threads:[~2020-04-22 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 14:08 [PATCH 1/2] cpufreq: qcom: fix compatibility issue with old binding Ansuel Smith
2020-04-22 14:08 ` [PATCH 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq Ansuel Smith
2020-04-22 15:26 ` Georgi Djakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2dad165-39f8-afb7-2bf8-74fa0239798a@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ilia.lin@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).