From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C2F21FF1C7 for ; Fri, 5 Dec 2025 01:13:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764897227; cv=none; b=llcs9IPtL2e55QqewcgirIbdvSjkj76cWp8T+4Gg54dxhX6DmlcJsslhPl72YGVa+TtbPpQfc8+KB3HhIszxqWnAExGUKVZtApxmqu+wL1zRXL2tAN7pSsG7qi3il0wksOcR9isTKGOBE/q/OaTgO6B2MKZ2/qbFg4xs/+q8kYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764897227; c=relaxed/simple; bh=7R7QufhlfMcE5gG3bzU3U5TtUEPIiN1UD6E0hStby5I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g5VqztLD3LgENfXsAB8j8IadlZunbYhU28vLwVSnGbQjHYQUzR6J60wgcuTmOOpZ7Q3wPmrR3c6XsjutWc2mEkHElKgwWamu2FrESfrnBQ+i/mcZ3LD3Fag1Qqk0LVlZBI8I56YJ/u4Vydrjtp5gnxhaMwhnnu8DpVaL4UPwgt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fC1f+/NR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=efu7OLSH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fC1f+/NR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="efu7OLSH" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B4JfWCO1131299 for ; Fri, 5 Dec 2025 01:13:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ES8FkVhlyY6ZBE+Y/f+xBmWFC9CfoOa6Zybsf7X4Dq0=; b=fC1f+/NRtJ/hVpTF 39lWd42hcFm/KCH7g0nic3Qow8T6Nv3pFiK0fMJC04/mCfewZTlCqxexIB6FytT2 zNGN7S8UijiXgtRK8Dqu4DbC52n32Qw4DNI7y4tY3+VSKN+8YUzGq8PeleqpvS3f LYwe2dAyCJc7QCAlYCuxg0wlrJqX0O0+4+ELs2CwB9k8qhriFY2DTyEZpzyg+LAx aHSGVR170c7qPcdJh1VthSbAsJjgDbvtImZl3gOGwTp4uETeV1K8DBtnt7vWeUG0 V8WwRQALoTqIV0HfXxC4jmLyDAvs8+ITZ3vZPdTG99lGr6XP19rYmGBc4DSNrAPU WEr/2g== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4au1f03msq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 05 Dec 2025 01:13:43 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-297e5a18652so19593265ad.1 for ; Thu, 04 Dec 2025 17:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764897222; x=1765502022; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ES8FkVhlyY6ZBE+Y/f+xBmWFC9CfoOa6Zybsf7X4Dq0=; b=efu7OLSHhZ/LCC43cb8MEx9XsTwyzjtidVbSK79wFQ8KM3yyc3Vw+0zN0UnyDXiLBw OwVKDZFJdxnE0myj5YDiaDHhR4B3fQZrDcWvA7zwV0nIG7mVI3RxgRPUDzY6ImazwTSI g0Yajlh1zFk+luiq9MRVu9dDVbhVWt2O7mGjoVqbjMTC55y65mwx1CS5jA7ng5ARexkf yXCCJJ4ZVKvkO4a2K4euOmwzPULNnJgFqRg4pNaaZLHZ8Q4nbdQ4aifYUBDHRVkvRuXe o0/PIUcQYx0KLBvKAg779EhvPhY3lLrMIhffHPiEwhz1RtD1ZcbOn+VZObXFcx7IIPVq Zi2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764897222; x=1765502022; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ES8FkVhlyY6ZBE+Y/f+xBmWFC9CfoOa6Zybsf7X4Dq0=; b=s+58SJJHkOUgeOevm7vDUXDz1lOx9CbwnWqRXxZBUsl3RuNYXxVLK2BzxmcrJ+ywMN BFpEc0cUp5NOeuHrqFP5uWW44T5KPvDftplcpHRZHJFA2GjoKea+YVI91cMNkz4OUe/S aFuWuA9AiLMQ0WDxS3YPU22ZB9e/tstwkzQ49wFhKtxjHs5VBL9wajPGZY3uGE3raT1N BUd7xL//WZmwApniCGwpcw6pjwMRfYxioPSIRE51p9FFuDNThkpEMftputYmKiIKYDVj VWPcnVMS+vZra4i8D5brb8xuvM+emSA9ZkEipVkiC7235GTNW2+/vgAD7SPRibGSszcG Vw8g== X-Forwarded-Encrypted: i=1; AJvYcCUD7eX7z494Y0mE86lof8NiYAMEjocp0tA3qiwPm0skDh0VuSKMgwA2LEYf1j32ThBU5CEmFy4lGQnh@vger.kernel.org X-Gm-Message-State: AOJu0Yz28nXGatTMRJureThoRzDSUjUgFde6+fMQ6EMM8PlmZypvTGXS 8t5zG3v6Rn4tQ5KY8wjgGmoHBvV80pAYOG75cRemq0tkK1wfQU07uxbjMGCuMwBxGYwFVy1dxuZ EeZ9MT2pYjV8vsm7VqGFMXmgVzJwEKvSrRl35FogEpS/pxoTwRnggqiWG/WK58G49 X-Gm-Gg: ASbGnctuC8tq7O35fNkeUKTNtqRHPtar8yl9gwIGktd+0X3pYHyvGaWphAJWdPrEqzY njuchSh/EE6Oi8V5A51YfZ/aGoF7YFX/jw1fZxR4F7JSHRX7Qo/vw3pdSh2pQyNXdPXdEzR2twn KlU+DjzP1KkyBLmhoJMf+5sPyvu4NzgycIo86RxPTHVAdnx9uio9oguw9h94pEYOHjm/mZbcuCu jfjGVdHRcDefYIbPgUffE2N4cBrOSnBezu4/UZQN9MgsxYtEHvf4RHDgTvcPmK0JAKDp/TJDwRw kBCzLyHiq5zgM7TBH5gyAuYDAE5VgBTq6jy2pLVEWByeKT2P9D/oLVJoSTSyHnBiTAFV9E84UTA Asp8GeKTdB/5pChHCqf+/pd0bxFfXsXOQwipUXQyJYEZ8niEt0iyYU/CLS7B3Co6oB5engZbICg Z/YvlG X-Received: by 2002:a17:902:f54e:b0:295:5132:1a99 with SMTP id d9443c01a7336-29d683b0135mr88087755ad.44.1764897222075; Thu, 04 Dec 2025 17:13:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+iWfWYud26rmtPI0Gd5cgq1HtwMmDA5U4WgyQfBF8rZTCz19c/VJFXbDWoac3xNzZRQv4sw== X-Received: by 2002:a17:902:f54e:b0:295:5132:1a99 with SMTP id d9443c01a7336-29d683b0135mr88087335ad.44.1764897221424; Thu, 04 Dec 2025 17:13:41 -0800 (PST) Received: from [10.133.33.82] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae49c358sm30913595ad.5.2025.12.04.17.13.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 17:13:40 -0800 (PST) Message-ID: Date: Fri, 5 Dec 2025 09:13:21 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 0/7] Provides support for Trigger Generation Unit To: Suzuki K Poulose , andersson@kernel.org, alexander.shishkin@linux.intel.com, kernel@oss.qualcomm.com, mike.leach@linaro.org, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, Greg Kroah-Hartman References: <20251203090055.2432719-1-songwei.chai@oss.qualcomm.com> <4f53766f-6338-4d94-a947-19b95952e08a@arm.com> Content-Language: en-US From: Songwei Chai In-Reply-To: <4f53766f-6338-4d94-a947-19b95952e08a@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: 0hVuuXdaL_mUXY-LvmWwt1xBx2bK3lTK X-Proofpoint-ORIG-GUID: 0hVuuXdaL_mUXY-LvmWwt1xBx2bK3lTK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA1MDAwNyBTYWx0ZWRfXzpD4MtfZtXTW 8kVeTNMeUfKaJptkwNn5zn3Oxl6N/YxjTZR3xQo8F01BG97wo0ow9NRACMo8FY6l8bDgrML4xck DGQ6O/ItGQJ9hDEqiaSj21prvs0xv+F0EQTNo+SDiCjJdUWDlxnAAWn2PvqTm5weS8rpx+vylD8 RGHltf3WQr1FjRy1dcgzVSc+SsJJf4ZROy9KVUvAfE9utiERmSKu8L6Xlyl6E6xt9/hZtO+7KcG CdejkpXPT7cTmS1WGfef/+Q1PS/ZMxQ1u2Riu96b1llHotWG0dQyVcsjTLUTjv7rWMacw9ghE5E +Fo4DmlR2YdgFlDGiGXRVw4bpTOhcJ5rTd3YR4oQhVK4SQ1XeB8aCed57At4c5s4XBMylxpBxv5 QAYmVMgY0W9jVQhliLlisXeqvwKBmg== X-Authority-Analysis: v=2.4 cv=Scz6t/Ru c=1 sm=1 tr=0 ts=693231c7 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=MOl3Vg1xW4PLRbHwqxUA:9 a=Mm_3ml_JzrRrl0x6:21 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-04_06,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512050007 On 12/3/2025 11:48 PM, Suzuki K Poulose wrote: > Cc: Greg > > On 03/12/2025 09:00, Songwei Chai wrote: >> We propose creating a new qcom directory under drivers/hwtracing >> to host this TGU driver, as well as additional Qualcomm-specific >> hwtracing drivers that we plan to submit in the coming months. >> This structure will help organize vendor-specific implementations >> and facilitate future development and maintenance. >> >> Feedback from the community on this proposal is highly appreciated. >> >> - Why we are proposing this: >> >> TGU has the ability to monitor signal conditions and trigger debug- >> related >> actions, serving as a programmable hardware component that enhances >> system >> trace and debug capabilities. Placing it under drivers/hwtracing >> aligns with >> its function as a trace generation utility. >> >> We previously attempted to push this driver to drivers/hwtracing/ >> coresight, >> but did not receive support from the maintainers of the CoreSight >> subsystem. >> The reason provided was: “This component is primarily a part of the >> Qualcomm proprietary QPMDA subsystem, and is capable of operating >> independently from the CoreSight hardware trace generation system.” >> >> Chat history : https://lore.kernel.org/all/ >> CAJ9a7ViKxHThyZfFFDV_FkNRimk4uo1NrMtQ-kcaj1qO4ZcGnA@mail.gmail.com/ >> >> Given this, we have been considering whether it would be appropriate >> to create a dedicated drivers/hwtracing/qcom directory for >> Qualcomm-related hwtracing drivers. This would follow the precedent set >> by Intel, which maintains its own directory at drivers/hwtracing/ >> intel_th. >> We believe this structure would significantly facilitate >> future submissions of related Qualcomm drivers. >> >> - Maintenance of drivers/hwtracing/qcom: >> > > Fine by, me. > > >> Bjorn, who maintains linux-arm-msm, will be the maintainer of this >> directory — we’ve discussed this with him and he’s aware that his task >> list may grow accordingly. Additionally, Qualcomm engineers familiar with >> the debug hardware — such as [Tingwei Zhang, Jinlong Mao, Songwei Chai], >> will be available to review incoming patches and support ongoing >> development. >> >> - Detail for TGU: >> >> This component can be utilized to sense a plurality of signals and >> create a trigger into the CTI or generate interrupts to processors >> once the input signal meets the conditions. We can treat the TGU’s >> workflow as a flowsheet, it has some “steps” regions for customization. >> In each step region, we can set the signals that we want with priority >> in priority_group, set the conditions in each step via condition_decode, >> and set the resultant action by condition_select. Meanwhile, >> some TGUs (not all) also provide timer/counter functionality. >> Based on the characteristics described above, we consider the TGU as a >> helper in the CoreSight subsystem. Its master device is the TPDM, which >> can transmit signals from other subsystems, and we reuse the existing >> ports mechanism to link the TPDM to the connected TGU. > > Please remove the coresight_device and other dependencies. You may use > generic bits, CS_LOCK/UNLOCK etc. But including coresight-priv.h is > not something I would prefer. It brings in unnecessary dependencies > between two subsystems and I don't see any reason for using -priv.h. > It is named as it is, for a reason, coresight private definitions. > > >> >> Here is a detailed example to explain how to use the TGU: >> >> In this example, the TGU is configured to use 2 conditions, 2 steps, and >> the timer. The goal is to look for one of two patterns which are >> generated >> from TPDM, giving priority to one, and then generate a trigger once the >> timer reaches a certain value. In other words, two conditions are used >> for the first step to look for the two patterns, where the one with the >> highest priority is used in the first condition. Then, in the second >> step, >> the timer is enabled and set to be compared to the given value at each >> clock cycle. These steps are better shown below. >>                |-----------------| >>                |                 | >>                |       TPDM      | >>                |                 | >>                |-----------------| >>                         | >>                         | >>      --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- >> ------ >>      |                  | >>                                                  | >>      |                  | >> |--------------------| | >>      |    |---- --->    |                          |  Go to next >> steps  | | >>      |    |             |                |--- ---> |  Enable >> timer      | | >>      |    |             v                |         | >>                     | | >>      |    |    |-----------------|       | >> |--------------------| | >>      |    |    |                 |  Yes  |                    | >>            | >>      |    |    |   inputs==0xB   | ----->|                    | >> <-------- | >>      |    |    |                 |       |                    | >> No | | >>      | No |    |-----------------|       | >> v         | | >>      |    |             |                | >> |-----------------| | | >>      |    |             |                |          | >> | | | >>      |    |             |                |          |      timer>=3 >> |-- | >>      |    |             v                |          | >> |   | >>      |    |    |-----------------|       | >> |-----------------|   | >>      |    |    |                 |  Yes  |                    | >>            | >>      |    |--- |   inputs==0xA   | ----->|                    | >> Yes       | >>      |         |                 |                            | >>            | >>      |         |-----------------| >> v           | >>      | >> |-----------------|   | >>      |                                              | >> |   | >>      |                                              |      Trigger >> |   | >>      |                                              | >> |   | >>      | >> |-----------------|   | >>      |  TGU                                                   | >>            | >>      |--- --- --- --- --- --- --- --- --- --- --- --- --- --- |--- --- >> -- | >>                                                               | >>                                                               v >>                                                      |-----------------| >>                                                      |The controllers  | >>                                                      |which will use   | >>                                                      |triggers further | >>                                                      |-----------------| >> >> steps: >>      1. Reset TGU /*it will disable tgu and reset dataset*/ >>      - echo 1 > /sys/bus/coresight/devices//reset_tgu >> >>      2. Set the pattern match for priority0 to 0xA = 0b1010 and for >>         priority 1 to 0xB = 0b1011. >>      - echo 0x11113232 > /sys/bus/coresight/devices// >> step0_priority0/reg0 >>      - echo 0x11113233 > /sys/bus/coresight/devices// >> step0_priority1/reg0 > > Why do they need to be coresight devices and appear on the coresight bus > if they are not coresight devices ? As I understand they are simply > devices with some sysfs knobs. > > Otherwise, happy with the proposal > > > Suzuki Hi Suzuki, Would it be a good idea to register the TGU device as a platform device so that it will appear under "/sys/devices/platform/" and the code could also be decoupled from coresight-priv.h BRs, Songwei> > > > >> >>      Note: >>          Bit distribution diagram for each priority register >> >> |-------------------------------------------------------------------| >>      |   Bits          |       Field Nam   | >> Description              | >> >> |-------------------------------------------------------------------| >>      |                 |                   | 00 = bypass for OR >> output   | >>      |     29:28       |   SEL_BIT7_TYPE2  | 01 = bypass for AND >> output  | >>      |                 |                   | 10 = sense input '0' is >> true| >>      |                 |                   | 11 = sense input '1' is >> true| >> >> |-------------------------------------------------------------------| >>      |                 |                   | 00 = bypass for OR >> output   | >>      |     25:24       |   SEL_BIT6_TYPE2  | 01 = bypass for AND >> output  | >>      |                 |                   | 10 = sense input '0' is >> true| >>      |                 |                   | 11 = sense input '1' is >> true| >> >> |-------------------------------------------------------------------| >>      |                 |                   | 00 = bypass for OR >> output   | >>      |     21:20       |   SEL_BIT5_TYPE2  | 01 = bypass for AND >> output  | >>      |                 |                   | 10 = sense input '0' is >> true| >>      |                 |                   | 11 = sense input '1' is >> true| >> >> |-------------------------------------------------------------------| >>      |                 |                   | 00 = bypass for OR >> output   | >>      |     17:16       |   SEL_BIT4_TYPE2  | 01 = bypass for AND >> output  | >>      |                 |                   | 10 = sense input '0' is >> true| >>      |                 |                   | 11 = sense input '1' is >> true| >> >> |-------------------------------------------------------------------| >>      |                 |                   | 00 = bypass for OR >> output   | >>      |     13:12       |   SEL_BIT3_TYPE2  | 01 = bypass for AND >> output  | >>      |                 |                   | 10 = sense input '0' is >> true| >>      |                 |                   | 11 = sense input '1' is >> true| >> >> |-------------------------------------------------------------------| >>      |                 |                   | 00 = bypass for OR >> output   | >>      |      9:8        |   SEL_BIT2_TYPE2  | 01 = bypass for AND >> output  | >>      |                 |                   | 10 = sense input '0' is >> true| >>      |                 |                   | 11 = sense input '1' is >> true| >> >> |-------------------------------------------------------------------| >>      |                 |                   | 00 = bypass for OR >> output   | >>      |      5:4        |  SEL_BIT1_TYPE2   | 01 = bypass for AND >> output  | >>      |                 |                   | 10 = sense input '0' is >> true| >>      |                 |                   | 11 = sense input '1' is >> true| >> >> |-------------------------------------------------------------------| >>      |                 |                   | 00 = bypass for OR >> output   | >>      |      1:0        |  SEL_BIT0_TYPE2   | 01 = bypass for AND >> output  | >>      |                 |                   | 10 = sense input '0' is >> true| >>      |                 |                   | 11 = sense input '1' is >> true| >> >> |-------------------------------------------------------------------| >>      These bits are used to identify the signals we want to sense, with >>      a maximum signal number of 140. For example, to sense the signal >>      0xA (binary 1010), we set the value of bits 0 to 13 to 3232, which >>      represents 1010. The remaining bits are set to 1, as we want to use >>      AND gate to summarize all the signals we want to sense here. For >>      rising or falling edge detection of any input to the priority, set >>      the remaining bits to 0 to use an OR gate. >> >>      3. look for the pattern for priority_i i=0,1. >>      - echo 0x3 > /sys/bus/coresight/devices// >> step0_condition_decode/reg0 >>      - echo 0x30 > /sys/bus/coresight/devices// >> step0_condition_decode/reg1 >> >> >> |-------------------------------------------------------------------------------| >>      |   Bits          |    Field Nam        | >> Description                | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |For each decoded >> condition, this       | >>      |      24         |       NOT           |inverts the output. If >> the condition   | >>      |                 |                     |decodes to true, and the >> NOT field     | >>      |                 |                     |is '1', then the output >> is NOT true.   | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> the associated| >>      |      21         |  BC0_COMP_ACTIVE    |comparator will be >> actively included in| >>      |                 |                     |the decoding of this >> particular        | >>      |                 |                     | >> condition.                             | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> the associated| >>      |                 |                     |comparator will need to >> be 1 to affect | >>      |      20         |   BC0_COMP_HIGH     |the decoding of this >> condition.        | >>      |                 |                     |Conversely, a '0' here >> requires a '0'  | >>      |                 |                     |from the >> comparator                    | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> the associated| >>      |      17         |                     |comparator will be >> actively included in| >>      |                 |  TC0_COMP_ACTIVE    |the decoding of this >> particular        | >>      |                 |                     | >> condition.                             | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> the associated| >>      |                 |                     |comparator will need to >> be 1 to affect | >>      |      16         |  TC0_COMP_HIGH      |the decoding of this >> particular        | >>      |                 |                     |condition.Conversely, a >> 0 here         | >>      |                 |                     |requires a '0' from the >> comparator     | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> Priority_n    | >>      |                 |                     |OR logic will be >> actively              | >>      |     4n+3        | Priority_n_OR_ACTIVE|included in the decoding >> of            | >>      |                 |    (n=0,1,2,3)      |this particular >> condition.             | >>      |                 |                     | >>                                        | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> Priority_n    | >>      |                 |                     |will need to be '1' to >> affect the      | >>      |     4n+2        |  Priority_n_OR_HIGH |decoding of this >> particular            | >>      |                 |    (n=0,1,2,3)      |condition. Conversely, a >> '0' here      | >>      |                 |                     |requires a '0' from >> Priority_n OR logic| >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> Priority_n    | >>      |                 |                     |AND logic will be >> actively             | >>      |     4n+1        |Priority_n_AND_ACTIVE|included in the decoding >> of this       | >>      |                 |  (n=0,1,2,3)        |particular >> condition.                  | >>      |                 |                     | >>                                        | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> Priority_n    | >>      |                 |                     |AND logic will need to >> be '1' to       | >>      |      4n         | Priority_n_AND_HIGH |affect the decoding of >> this            | >>      |                 |   (n=0,1,2,3)       |particular condition. >> Conversely,      | >>      |                 |                     |a '0' here requires a >> '0' from         | >>      |                 |                     |Priority_n AND >> logic.                  | >> >> |-------------------------------------------------------------------------------| >>      Since we use `priority_0` and `priority_1` with an AND output in >> step 2, we set `0x3` >>      and `0x30` here to activate them. >> >>      4. Set NEXT_STEP = 1 and TC0_ENABLE = 1 so that when the conditions >>         are met then the next step will be step 1 and the timer will >> be enabled. >>      - echo 0x20008 > /sys/bus/coresight/devices// >> step0_condition_select/reg0 >>      - echo 0x20008 > /sys/bus/coresight/devices// >> step0_condition_select/reg1 >> >> >> |-----------------------------------------------------------------------------| >>      |   Bits          |       Field Nam   | >> Description                | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |This field defines the >> next step the   | >>      |    18:17        |     NEXT_STEP     |TGU will 'goto' for the >> associated     | >>      |                 |                   |Condition and >> Step.                    | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |For each possible output >> trigger       | >>      |    13           |     TRIGGER       |available, set a '1' if >> you want       | >>      |                 |                   |the trigger to go active >> for the       | >>      |                 |                   |associated condition and >> Step.         | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |This will cause BC0 to >> increment if the| >>      |    9            |     BC0_INC       |associated Condition is >> decoded for    | >>      |                 |                   |this >> step.                             | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |This will cause BC0 to >> decrement if the| >>      |    8            |     BC0_DEC       |associated Condition is >> decoded for    | >>      |                 |                   |this >> step.                             | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |This will clear BC0 count >> value to 0 if| >>      |    7            |     BC0_CLEAR     |the associated Condition >> is decoded    | >>      |                 |                   |for this >> step.                         | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |This will cause TC0 to >> increment until | >>      |    3            |     TC0_ENABLE    |paused or cleared if the >> associated    | >>      |                 |                   |Condition is decoded for >> this step.    | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |This will cause TC0 to >> pause until     | >>      |    2            |     TC0_PAUSE     |enabled if the associated >> Condition    | >>      |                 |                   |is decoded for this >> step.              | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |This will clear TC0 count >> value to 0   | >>      |    1            |     TC0_CLEAR     |if the associated >> Condition is         | >>      |                 |                   |decoded for this >> step.                 | >> >> |-----------------------------------------------------------------------------| >>      |                 |                   |This will set the done >> signal to the   | >>      |    0            |     DONE          |TGU FSM if the associated >> Condition    | >>      |                 |                   |is decoded for this >> step.              | >> >> |-----------------------------------------------------------------------------| >>      Based on the distribution diagram, we set `0x20008` for >> `priority0` and `priority1` to >>      achieve "jump to step 1 and enable TC0" once the signal is sensed. >> >>      5. activate the timer comparison for this step. >>      -  echo 0x30000  > /sys/bus/coresight/devices// >> step1_condition_decode/reg0 >> >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> the associated| >>      |      17         |                     |comparator will be >> actively included in| >>      |                 |  TC0_COMP_ACTIVE    |the decoding of this >> particular        | >>      |                 |                     | >> condition.                             | >> >> |-------------------------------------------------------------------------------| >>      |                 |                     |When '1' the output from >> the associated| >>      |                 |                     |comparator will need to >> be 1 to affect | >>      |      16         |  TC0_COMP_HIGH      |the decoding of this >> particular        | >>      |                 |                     |condition.Conversely, a >> 0 here         | >>      |                 |                     |requires a '0' from the >> comparator     | >> >> |-------------------------------------------------------------------------------| >>      Accroding to the decode distribution diagram , we give 0x30000 >> here to set 16th&17th bit >>      to enable timer comparison. >> >>      6. Set the NEXT_STEP = 0 and TC0_PAUSE = 1 and TC0_CLEAR = 1 once >> the timer >>         has reached the given value. >>      - echo 0x6 > /sys/bus/coresight/devices// >> step1_condition_select/reg0 >> >>      7. Enable Trigger 0 for TGU when the condition 0 is met in step1, >>         i.e. when the timer reaches 3. >>      - echo 0x2000 > /sys/bus/coresight/devices// >> step1_condition_select/default >> >>      Note: >>          1. 'default' register allows for establishing the resultant >> action for >>          the default condition >> >>          2. Trigger:For each possible output trigger available from >>          the Design document, there are three triggers: interrupts, CTI, >>          and Cross-TGU mapping.All three triggers can occur, but >>          the choice of which trigger to use depends on the user's >>          needs. >> >>      8. Compare the timer to 3 in step 1. >>      - echo 0x3 > /sys/bus/coresight/devices//step1_timer/reg0 >> >>      9. enale tgu >>      - echo 1 > /sys/bus/coresight/devices//enable_tgu >> --- >> Link to V7: https://lore.kernel.org/all/20251104064043.88972-1- >> songwei.chai@oss.qualcomm.com/ >> >> Changes in V8: >> - Add "select" section in bindings. >> - Update publish date in "sysfs-bus-coresight-devices-tgu". >> --- >> Link to V6: https://lore.kernel.org/all/20250709104114.22240-1- >> songchai@qti.qualcomm.com/ >> >> Changes in V7: >> - Move the TGU code location from 'drivers/hwtracing/coresight/' to >> 'drivers/hwtracing/qcom/'. >> - Rename the spinlock used in the code from 'spinlock' to 'lock'. >> - Perform the 'calculate_array_location' separately, instead of doing >> it within the function. >> - Update the sender email address. >> --- >> Link to V5: https://lore.kernel.org/all/20250529081949.26493-1- >> quic_songchai@quicinc.com/ >> >> Changes in V6: >> - Replace spinlock with guard(spinlock) in tgu_enable. >> - Remove redundant blank line. >> - Update publish date and contact member's name in "sysfs-bus- >> coresight-devices-tgu". >> --- >> Link to V4: https://patchwork.kernel.org/project/linux-arm-msm/ >> cover/20250423101054.954066-1-quic_songchai@quicinc.com/ >> >> Changes in V5: >> - Update publish date and kernel_version in "sysfs-bus-coresight- >> devices-tgu" >> --- >> Link to V3: https://lore.kernel.org/all/20250227092640.2666894-1- >> quic_songchai@quicinc.com/ >> >> Changes in V4: >> - Add changlog in coverletter. >> - Correct 'year' in Copyright in patch1. >> - Correct port mechansim description in patch1. >> - Remove 'tgu-steps','tgu-regs','tgu-conditions','tgu-timer-counters' >> from dt-binding >> and set them through reading DEVID register as per Mike's suggestion. >> - Modify tgu_disable func to make it have single return point in >> patch2 as per >> Mike's suggestion. >> - Use sysfs_emit in enable_tgu_show func in ptach2. >> - Remove redundant judgement in enable_tgu_store in patch2. >> - Correct typo in description in patch3. >> - Set default ret as SYSFS_GROUP_INVISIBLE, and returnret at end in >> pacth3 as >> per Mike's suggestion. >> - Remove tgu_dataset_ro definition in patch3 >> - Use #define constants with explanations of what they are rather than >> arbitrary magic numbers in patch3 and patch4. >> - Check -EINVAL before using 'calculate_array_location()' in array in >> patch4. >> - Add 'default' in 'tgu_dataset_show''s switch part in patch4. >> - Document the value needed to initiate the reset in pacth7. >> - Check "value" in 'reset_tgu_store' and bail out with an error code >> if 0 in patch7. >> - Remove dev_dbg in 'reset_tgu_store' in patch7. >> --- >> Link to V2: https://lore.kernel.org/all/20241010073917.16023-1- >> quic_songchai@quicinc.com/ >> >> Changes in V3: >> - Correct typo and format in dt-binding in patch1 >> - Rebase to the latest kernel version >> --- >> Link to V1: https://lore.kernel.org/all/20240830092311.14400-1- >> quic_songchai@quicinc.com/ >> >> Changes in V2: >>   - Use real name instead of login name, >>   - Correct typo and format in dt-binding and code. >>   - Bring order in tgu_prob(declarations with and without assignments) >> as per >> Krzysztof's suggestion. >>   - Add module device table in patch2. >>   - Set const for tgu_common_grp and tgu_ids in patch2. >>   - Initialize 'data' in tgu_ids to fix the warning in pacth2. >> --- >> >> Songwei Chai (7): >>    dt-bindings: arm: Add support for Qualcomm TGU trace >>    qcom-tgu: Add TGU driver >>    qcom-tgu: Add signal priority support >>    qcom-tgu: Add TGU decode support >>    qcom-tgu: Add support to configure next action >>    qcom-tgu: Add timer/counter functionality for TGU >>    qcom-tgu: Add reset node to initialize >> >>   .../testing/sysfs-bus-coresight-devices-tgu   |  51 ++ >>   .../devicetree/bindings/arm/qcom,tgu.yaml     |  92 +++ >>   drivers/Makefile                              |   1 + >>   drivers/hwtracing/Kconfig                     |   2 + >>   drivers/hwtracing/qcom/Kconfig                |  18 + >>   drivers/hwtracing/qcom/Makefile               |   3 + >>   drivers/hwtracing/qcom/tgu.c                  | 737 ++++++++++++++++++ >>   drivers/hwtracing/qcom/tgu.h                  | 252 ++++++ >>   8 files changed, 1156 insertions(+) >>   create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight- >> devices-tgu >>   create mode 100644 Documentation/devicetree/bindings/arm/qcom,tgu.yaml >>   create mode 100644 drivers/hwtracing/qcom/Kconfig >>   create mode 100644 drivers/hwtracing/qcom/Makefile >>   create mode 100644 drivers/hwtracing/qcom/tgu.c >>   create mode 100644 drivers/hwtracing/qcom/tgu.h >> >