From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C03E11BF3A; Thu, 27 Jun 2024 09:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719480357; cv=none; b=PAwoXmeXP1KSmGQx0s7re3EEYo13/Q9hwmbFZkA2yz4VKSlWMz1OIQ9vh0Wd7W2H++B1LOvAEUUt2GrZjmM2pkaRjY7JOhZ3X7fMS5lYu7HGxpEkrN+naFg1PecBGy1FfI/PRKUrA5dvnZMExHJGzAgYQbl2dzy8i0dsspLIL4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719480357; c=relaxed/simple; bh=yms0dvcM+cOFXF/b3rgL4MfeUvo48xGxAXWzQPcm+CE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Dc3awmAlDC77dtMEXAFKdTLHuAobzNNKt5bThc0oid4RnoeWcE44Ss8I3GF4XH9ynvwueo0X3/6x0Fp+kptZXTQt3DhtTv7GU1jzV/Zt70ESPbVcVeNFMwvjtCGZpI93POWt6fhE4Z34TWeXP+hOHimNbJfSGkEAA2dM8TN46Tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=baOWdl7Q; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="baOWdl7Q" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-424a3ccd0c0so23326815e9.1; Thu, 27 Jun 2024 02:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719480354; x=1720085154; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=yms0dvcM+cOFXF/b3rgL4MfeUvo48xGxAXWzQPcm+CE=; b=baOWdl7Qiorh+u3AVF+DbsDQlFMTJayW6zaafu66QUObVibm1pkpa+AH7x4PPFMH1n 9gZu9ms45+vPiWusvSMnKU12xjGm78q0K8BXzJkGUbJFZD+mMOEB1tVrO3OmkVC370O9 TdwgojSQCLRTFY7RW7ln/Rs4E1rfWNwy2fqsLueH2kiZS+SptZK7FVIHyCJrL9t7IXV/ apEFVRw3hidNbdTDDqfi0RhhvjFX8x/6PpOygOGstK+Mn/hI42Qv2zLkbI21k17X6cYJ qbAxezJU7MjR1OFlt1JOY3cqAZVCBeu6zOaavS6jUsPRWB1kKFz5EAAGbb7TK807SW43 NIeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719480354; x=1720085154; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yms0dvcM+cOFXF/b3rgL4MfeUvo48xGxAXWzQPcm+CE=; b=V3j5ZswMvw2wY3l25+qdksftE8fNwldWqE7K96ILmeBkPSqD3HEL+8ErT1cES/iu11 FueVu3oK386lKJD1TEIKbfdMPJvoCoXzpGKTSDfdmpqo7YzIM3+hOutBDTPgJEYPZgZ1 6PeyQNvupjbPyAAbkKIxrYOGouukYD1U394a8/rGqeNwdiaUNty5B023gjXCH+3w6EIk Yl0l9nw3Z9HBnz+0mza3Xmgtxuj2wc2bZzqRZOu93mAHfn3/7l8vOW+VdEXE4oD3z0yR g4wCI8VbHEbeYBEKxH1wgssEKTsBy/tiKSjiwkIIWYyDl/fxEtsslF3eUX5HQ3DhJ/Jg C/SQ== X-Forwarded-Encrypted: i=1; AJvYcCXuRzrTuGO9tEi5L9WV4S1xdQmHI6gHoOGAJxE0Ts3zQ1sWsaFPHfAcC4+ArVVIS8/45rhmRF+7LxmXXrT3QDxo9UGAvnW7kpNTT1sgEnZEntNbwuMyRdO4btqfIN/V4tVpMcd8Fmd0QA== X-Gm-Message-State: AOJu0YxBHkEktx3azTL7mzcs1TqMcDFRu+IHTIlupxJcgUewZlnk9rrQ 9ZY+cIdKCXbUWrHbDSr6Gogak/tgRo25cdUD+xes0Cd6CUqAEUUO X-Google-Smtp-Source: AGHT+IG3qQJOlsPSb9mrwiN19TVVQzBmbUDyKeJiSJmR4CM0XqDUNRuOzxKANhLRTTCQvEJ+h+D2cg== X-Received: by 2002:a05:6000:184f:b0:366:eb61:b47 with SMTP id ffacd0b85a97d-366eb610bafmr11187920f8f.8.1719480353838; Thu, 27 Jun 2024 02:25:53 -0700 (PDT) Received: from ?IPv6:2001:8a0:e622:f700:9537:8d85:b9f7:78bb? ([2001:8a0:e622:f700:9537:8d85:b9f7:78bb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367436999f6sm1225086f8f.72.2024.06.27.02.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 02:25:53 -0700 (PDT) Message-ID: Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: add TPM device From: Vitor Soares To: Francesco Dolcini , Shawn Guo Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vitor Soares , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 27 Jun 2024 10:25:52 +0100 In-Reply-To: References: <20240613134150.318755-1-ivitro@gmail.com> <20240617071842.GA4832@francesco-nb> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2024-06-27 at 09:10 +0200, Francesco Dolcini wrote: > On Thu, Jun 27, 2024 at 02:57:48PM +0800, Shawn Guo wrote: > > On Mon, Jun 17, 2024 at 09:18:42AM +0200, Francesco Dolcini wrote: > > > Hello Shawn, > > >=20 > > > On Mon, Jun 17, 2024 at 10:33:50AM +0800, Shawn Guo wrote: > > > > On Thu, Jun 13, 2024 at 02:41:50PM +0100, Vitor Soares wrote: > > > > > From: Vitor Soares > > > > >=20 > > > > > Add TPM device found on Verdin iMX8M Mini PID4 0090 variant. > > > > >=20 > > > > > Signed-off-by: Vitor Soares > > > > > --- > > > > > =C2=A0arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 16 +++++= ++++++---- > > > > > - > > > > > =C2=A01 file changed, 11 insertions(+), 5 deletions(-) > > > > >=20 > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > > b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > > index 4768b05fd765..c9ae5f0bb526 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > > > @@ -227,15 +227,16 @@ &ecspi2 { > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pinctrl-0 =3D <&p= inctrl_ecspi2>; > > > > > =C2=A0}; > > > > > =C2=A0 > > > > > -/* Verdin CAN_1 (On-module) */ > > > > > +/* On-module SPI */ > > > > > =C2=A0&ecspi3 { > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#address-cells = =3D <1>; > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0#size-cells =3D <= 0>; > > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cs-gpios =3D <&gpio5 2= 5 GPIO_ACTIVE_LOW>; > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cs-gpios =3D <&gpio5 2= 5 GPIO_ACTIVE_LOW>, <&gpio4 19 > > > > > GPIO_ACTIVE_LOW>; > > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pinctrl-names =3D= "default"; > > > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pinctrl-0 =3D <&pinctr= l_ecspi3>; > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pinctrl-0 =3D <&pinctr= l_ecspi3>, <&pinctrl_pmic_tpm_ena>; > > > >=20 > > > > Would it make more sense to have tpm pinctrl in node tpm@1 below? > > > It's the pinctrl of the SPI Chip Select pin, not something about the > > > TPM, I think it's correct to have it into the ecspi node. > >=20 > > The name pinctrl_pmic_tpm_ena seems confusing then. >=20 > I agree (this is coming from the schematics net name, let's blame the HW > folks). >=20 > With that said, let's rename this to `pinctrl_tpm_spi_cs`. Vitor? I will prepare a v2 with this small change. Vitor Soares >=20 > Francesco >=20