devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thor Thayer <thor.thayer@linux.intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10
Date: Thu, 28 Jun 2018 15:23:56 -0500	[thread overview]
Message-ID: <b325b195-de23-c0bf-8c82-ab72bac2c43c@linux.intel.com> (raw)
In-Reply-To: <22497e7f-74dc-2427-6b36-5900fe062d9d@kernel.org>

Hi Dinh,

On 06/28/2018 02:37 PM, Dinh Nguyen wrote:
> Hi Thor
> 
> On 06/27/2018 12:50 PM, thor.thayer@linux.intel.com wrote:
>> From: Thor Thayer <thor.thayer@linux.intel.com>
>>
>> Add the required clocks for the new Stratix10 clock bindings
>> to the SPI nodes.
>>
>> Signed-off-by: Thor Thayer <thor.thayer@linux.intel.com>
>> ---
>>   arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> index 67dac595dc72..9e54282ee08c 100644
>> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi
>> @@ -310,6 +310,7 @@
>>   			resets = <&rst SPIM0_RESET>;
>>   			reg-io-width = <4>;
>>   			num-cs = <4>;
>> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>   			status = "disabled";
>>   		};
>>   
>> @@ -322,6 +323,7 @@
>>   			resets = <&rst SPIM1_RESET>;
>>   			reg-io-width = <4>;
>>   			num-cs = <4>;
>> +			clocks = <&clkmgr STRATIX10_L4_MAIN_CLK>;
>>   			status = "disabled";
>>   		};
>>   
>>
> 
> I thought you already sent a patch for this?
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2018-June/585514.html
> 
> Dinh
> 
Good catch. I didn't see the clock addition in the

dinh_linux_for_next/socfpga_for_next_v4.19_fixes_v1
dinh_linux_for_next/socfpga_for_next_v4.19_dts_v1

branches so I assumed it hadn't been applied (since the num-cs change 
from the patchset is there).

This is a simpler patch since the STRATIX10_SPI_M_CLK isn't needed.

Thanks,

Thor

  reply	other threads:[~2018-06-28 20:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 17:50 [PATCH] arm64: dts: stratix10: Add SPI node clocks for Stratix10 thor.thayer
2018-06-28 19:37 ` Dinh Nguyen
2018-06-28 20:23   ` Thor Thayer [this message]
2018-06-29 14:27     ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b325b195-de23-c0bf-8c82-ab72bac2c43c@linux.intel.com \
    --to=thor.thayer@linux.intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).