[PATCH 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml

[PATCH 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml

[Roger Quadros]

Hi,

This series converts omap_elm DT bindings to yaml and adds
support for ELM on AM64 SoC.

cheers,
-roger

Roger Quadros (3):
  dt-bindings: mtd: ti,elm: Convert to yaml
  dt-bindings: mtd: ti,elm: Add support for AM64 ELM
  mtd: rawnand: omap_elm: Add compatible for AM64 ELM

 Documentation/devicetree/bindings/mtd/elm.txt | 16 ----
 .../devicetree/bindings/mtd/ti,elm.yaml       | 73 +++++++++++++++++++
 drivers/mtd/nand/raw/omap_elm.c               |  1 +
 3 files changed, 74 insertions(+), 16 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
 create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml

-- 
2.17.1

[PATCH 1/3] dt-bindings: mtd: ti,elm: Convert to yaml

[Roger Quadros]

Convert elm.txt to ti,elm.yaml.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 Documentation/devicetree/bindings/mtd/elm.txt | 16 -------
 .../devicetree/bindings/mtd/ti,elm.yaml       | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 16 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
 create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml

diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
deleted file mode 100644
index 59ddc61c1076..000000000000
--- a/Documentation/devicetree/bindings/mtd/elm.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-Error location module
-
-Required properties:
-- compatible: Must be "ti,am3352-elm"
-- reg: physical base address and size of the registers map.
-- interrupts: Interrupt number for the elm.
-
-Optional properties:
-- ti,hwmods: Name of the hwmod associated to the elm
-
-Example:
-elm: elm@0 {
-	compatible = "ti,am3352-elm";
-	reg = <0x48080000 0x2000>;
-	interrupts = <4>;
-};
diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
new file mode 100644
index 000000000000..24ed0fb84204
--- /dev/null
+++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/ti,elm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments Error Location Module (ELM).
+
+maintainers:
+  - Roger Quadros <rogerq@kernel.org>
+
+description:
+  ELM module is used together with GPMC and NAND Flash to detect
+  errors and the location of the error based on BCH algorithms
+  so they can be corrected if possible.
+
+properties:
+  compatible:
+    items:
+      - const: ti,am3352-elm
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  ti,hwmods:
+    description:
+      Name of the HWMOD associated with ELM. This is for legacy
+      platforms only.
+    $ref: /schemas/types.yaml#/definitions/string
+    deprecated: true
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    elm: elm@0 {
+        compatible = "ti,am3352-elm";
+        reg = <0x0 0x2000>;
+        interrupts = <4>;
+    };
-- 
2.17.1

Re: [PATCH 1/3] dt-bindings: mtd: ti,elm: Convert to yaml

[Krzysztof Kozlowski]

On 23/03/2022 12:18, Roger Quadros wrote:
> Convert elm.txt to ti,elm.yaml.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  Documentation/devicetree/bindings/mtd/elm.txt | 16 -------
>  .../devicetree/bindings/mtd/ti,elm.yaml       | 48 +++++++++++++++++++
>  2 files changed, 48 insertions(+), 16 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
>  create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
> deleted file mode 100644
> index 59ddc61c1076..000000000000
> --- a/Documentation/devicetree/bindings/mtd/elm.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -Error location module
> -
> -Required properties:
> -- compatible: Must be "ti,am3352-elm"
> -- reg: physical base address and size of the registers map.
> -- interrupts: Interrupt number for the elm.
> -
> -Optional properties:
> -- ti,hwmods: Name of the hwmod associated to the elm
> -
> -Example:
> -elm: elm@0 {
> -	compatible = "ti,am3352-elm";
> -	reg = <0x48080000 0x2000>;
> -	interrupts = <4>;
> -};
> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> new file mode 100644
> index 000000000000..24ed0fb84204
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/ti,elm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments Error Location Module (ELM).
> +
> +maintainers:
> +  - Roger Quadros <rogerq@kernel.org>
> +
> +description:
> +  ELM module is used together with GPMC and NAND Flash to detect
> +  errors and the location of the error based on BCH algorithms
> +  so they can be corrected if possible.
> +
> +properties:
> +  compatible:
> +    items:

No items, just const.

> +      - const: ti,am3352-elm
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  ti,hwmods:
> +    description:
> +      Name of the HWMOD associated with ELM. This is for legacy
> +      platforms only.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    deprecated: true

It was not deprecated before. Could you explain it in commit msg because
it is not a conversion only.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    elm: elm@0 {

This is error correction, right? So generic node name "ecc"?

> +        compatible = "ti,am3352-elm";
> +        reg = <0x0 0x2000>;
> +        interrupts = <4>;
> +    };


Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: mtd: ti,elm: Convert to yaml

[Roger Quadros]

Hi Krzysztof,

On 24/03/2022 20:24, Krzysztof Kozlowski wrote:
> On 23/03/2022 12:18, Roger Quadros wrote:
>> Convert elm.txt to ti,elm.yaml.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>>  Documentation/devicetree/bindings/mtd/elm.txt | 16 -------
>>  .../devicetree/bindings/mtd/ti,elm.yaml       | 48 +++++++++++++++++++
>>  2 files changed, 48 insertions(+), 16 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/mtd/elm.txt
>>  create mode 100644 Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/elm.txt b/Documentation/devicetree/bindings/mtd/elm.txt
>> deleted file mode 100644
>> index 59ddc61c1076..000000000000
>> --- a/Documentation/devicetree/bindings/mtd/elm.txt
>> +++ /dev/null
>> @@ -1,16 +0,0 @@
>> -Error location module
>> -
>> -Required properties:
>> -- compatible: Must be "ti,am3352-elm"
>> -- reg: physical base address and size of the registers map.
>> -- interrupts: Interrupt number for the elm.
>> -
>> -Optional properties:
>> -- ti,hwmods: Name of the hwmod associated to the elm
>> -
>> -Example:
>> -elm: elm@0 {
>> -	compatible = "ti,am3352-elm";
>> -	reg = <0x48080000 0x2000>;
>> -	interrupts = <4>;
>> -};
>> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>> new file mode 100644
>> index 000000000000..24ed0fb84204
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>> @@ -0,0 +1,48 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mtd/ti,elm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments Error Location Module (ELM).
>> +
>> +maintainers:
>> +  - Roger Quadros <rogerq@kernel.org>
>> +
>> +description:
>> +  ELM module is used together with GPMC and NAND Flash to detect
>> +  errors and the location of the error based on BCH algorithms
>> +  so they can be corrected if possible.
>> +
>> +properties:
>> +  compatible:
>> +    items:
> 
> No items, just const.

OK.

> 
>> +      - const: ti,am3352-elm
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  ti,hwmods:
>> +    description:
>> +      Name of the HWMOD associated with ELM. This is for legacy
>> +      platforms only.
>> +    $ref: /schemas/types.yaml#/definitions/string
>> +    deprecated: true
> 
> It was not deprecated before. Could you explain it in commit msg because
> it is not a conversion only.

OK I will mention that hwmod usage is not recommended for new platforms.

> 
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    elm: elm@0 {
> 
> This is error correction, right? So generic node name "ecc"?
> 
>> +        compatible = "ti,am3352-elm";
>> +        reg = <0x0 0x2000>;
>> +        interrupts = <4>;
>> +    };
> 
> 
> Best regards,
> Krzysztof

cheers,
-roger

[PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM

[Roger Quadros]

TI's AM64 SoC has the Error Locator Module. Add compatible and
related properties to support ELM on AM64 SoC.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 .../devicetree/bindings/mtd/ti,elm.yaml       | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
index 24ed0fb84204..bc01d35ce605 100644
--- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
+++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
@@ -17,7 +17,9 @@ description:
 properties:
   compatible:
     items:
-      - const: ti,am3352-elm
+      - enum:
+          - ti,am3352-elm
+          - ti,am64-elm
 
   reg:
     maxItems: 1
@@ -25,6 +27,17 @@ properties:
   interrupts:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+    description: Functional clock.
+
+  clock-names:
+    items:
+      - const: fck
+
+  power-domains:
+    maxItems: 1
+
   ti,hwmods:
     description:
       Name of the HWMOD associated with ELM. This is for legacy
@@ -37,6 +50,18 @@ required:
   - reg
   - interrupts
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: ti,am64-elm
+    then:
+      required:
+        - clocks
+        - clock-names
+        - power-domains
+
 additionalProperties: false
 
 examples:
-- 
2.17.1

Re: [PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM

[Krzysztof Kozlowski]

On 23/03/2022 12:18, Roger Quadros wrote:
> TI's AM64 SoC has the Error Locator Module. Add compatible and
> related properties to support ELM on AM64 SoC.
> 
> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> ---
>  .../devicetree/bindings/mtd/ti,elm.yaml       | 27 ++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> index 24ed0fb84204..bc01d35ce605 100644
> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
> @@ -17,7 +17,9 @@ description:
>  properties:
>    compatible:
>      items:
> -      - const: ti,am3352-elm
> +      - enum:
> +          - ti,am3352-elm
> +          - ti,am64-elm
>  
>    reg:
>      maxItems: 1
> @@ -25,6 +27,17 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  clocks:
> +    maxItems: 1
> +    description: Functional clock.
> +
> +  clock-names:
> +    items:
> +      - const: fck
> +
> +  power-domains:
> +    maxItems: 1
> +
>    ti,hwmods:
>      description:
>        Name of the HWMOD associated with ELM. This is for legacy
> @@ -37,6 +50,18 @@ required:
>    - reg
>    - interrupts
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: ti,am64-elm
> +    then:
> +      required:
> +        - clocks
> +        - clock-names
> +        - power-domains

Are these new properties also valid for am3352?

> +
>  additionalProperties: false
>  
>  examples:


Best regards,
Krzysztof

Re: [PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM

[Roger Quadros]

On 24/03/2022 20:26, Krzysztof Kozlowski wrote:
> On 23/03/2022 12:18, Roger Quadros wrote:
>> TI's AM64 SoC has the Error Locator Module. Add compatible and
>> related properties to support ELM on AM64 SoC.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>>  .../devicetree/bindings/mtd/ti,elm.yaml       | 27 ++++++++++++++++++-
>>  1 file changed, 26 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>> index 24ed0fb84204..bc01d35ce605 100644
>> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>> @@ -17,7 +17,9 @@ description:
>>  properties:
>>    compatible:
>>      items:
>> -      - const: ti,am3352-elm
>> +      - enum:
>> +          - ti,am3352-elm
>> +          - ti,am64-elm
>>  
>>    reg:
>>      maxItems: 1
>> @@ -25,6 +27,17 @@ properties:
>>    interrupts:
>>      maxItems: 1
>>  
>> +  clocks:
>> +    maxItems: 1
>> +    description: Functional clock.
>> +
>> +  clock-names:
>> +    items:
>> +      - const: fck
>> +
>> +  power-domains:
>> +    maxItems: 1
>> +
>>    ti,hwmods:
>>      description:
>>        Name of the HWMOD associated with ELM. This is for legacy
>> @@ -37,6 +50,18 @@ required:
>>    - reg
>>    - interrupts
>>  
>> +allOf:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: ti,am64-elm
>> +    then:
>> +      required:
>> +        - clocks
>> +        - clock-names
>> +        - power-domains
> 
> Are these new properties also valid for am3352?

No they are not required for am3352-elm. Only required for K3 based platforms like AM64.

> 
>> +
>>  additionalProperties: false
>>  
>>  examples:
> 
> 
> Best regards,
> Krzysztof

cheers,
-roger

Re: [PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM

[Krzysztof Kozlowski]

On 25/03/2022 13:05, Roger Quadros wrote:
> 
> 
> On 24/03/2022 20:26, Krzysztof Kozlowski wrote:
>> On 23/03/2022 12:18, Roger Quadros wrote:
>>> TI's AM64 SoC has the Error Locator Module. Add compatible and
>>> related properties to support ELM on AM64 SoC.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>>> ---
>>>  .../devicetree/bindings/mtd/ti,elm.yaml       | 27 ++++++++++++++++++-
>>>  1 file changed, 26 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>> index 24ed0fb84204..bc01d35ce605 100644
>>> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>> @@ -17,7 +17,9 @@ description:
>>>  properties:
>>>    compatible:
>>>      items:
>>> -      - const: ti,am3352-elm
>>> +      - enum:
>>> +          - ti,am3352-elm
>>> +          - ti,am64-elm
>>>  
>>>    reg:
>>>      maxItems: 1
>>> @@ -25,6 +27,17 @@ properties:
>>>    interrupts:
>>>      maxItems: 1
>>>  
>>> +  clocks:
>>> +    maxItems: 1
>>> +    description: Functional clock.
>>> +
>>> +  clock-names:
>>> +    items:
>>> +      - const: fck
>>> +
>>> +  power-domains:
>>> +    maxItems: 1
>>> +
>>>    ti,hwmods:
>>>      description:
>>>        Name of the HWMOD associated with ELM. This is for legacy
>>> @@ -37,6 +50,18 @@ required:
>>>    - reg
>>>    - interrupts
>>>  
>>> +allOf:
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            const: ti,am64-elm
>>> +    then:
>>> +      required:
>>> +        - clocks
>>> +        - clock-names
>>> +        - power-domains
>>
>> Are these new properties also valid for am3352?
> 
> No they are not required for am3352-elm. Only required for K3 based platforms like AM64.
> 

I understand they are not required, but I asked if they are valid. IOW,
whether ELM in am3352 also is part of power domain and has clock input?

Best regards,
Krzysztof

Re: [PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM

[Roger Quadros]

On 25/03/2022 14:08, Krzysztof Kozlowski wrote:
> On 25/03/2022 13:05, Roger Quadros wrote:
>>
>>
>> On 24/03/2022 20:26, Krzysztof Kozlowski wrote:
>>> On 23/03/2022 12:18, Roger Quadros wrote:
>>>> TI's AM64 SoC has the Error Locator Module. Add compatible and
>>>> related properties to support ELM on AM64 SoC.
>>>>
>>>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>>>> ---
>>>>  .../devicetree/bindings/mtd/ti,elm.yaml       | 27 ++++++++++++++++++-
>>>>  1 file changed, 26 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>>> index 24ed0fb84204..bc01d35ce605 100644
>>>> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>>> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>>> @@ -17,7 +17,9 @@ description:
>>>>  properties:
>>>>    compatible:
>>>>      items:
>>>> -      - const: ti,am3352-elm
>>>> +      - enum:
>>>> +          - ti,am3352-elm
>>>> +          - ti,am64-elm
>>>>  
>>>>    reg:
>>>>      maxItems: 1
>>>> @@ -25,6 +27,17 @@ properties:
>>>>    interrupts:
>>>>      maxItems: 1
>>>>  
>>>> +  clocks:
>>>> +    maxItems: 1
>>>> +    description: Functional clock.
>>>> +
>>>> +  clock-names:
>>>> +    items:
>>>> +      - const: fck
>>>> +
>>>> +  power-domains:
>>>> +    maxItems: 1
>>>> +
>>>>    ti,hwmods:
>>>>      description:
>>>>        Name of the HWMOD associated with ELM. This is for legacy
>>>> @@ -37,6 +50,18 @@ required:
>>>>    - reg
>>>>    - interrupts
>>>>  
>>>> +allOf:
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            const: ti,am64-elm
>>>> +    then:
>>>> +      required:
>>>> +        - clocks
>>>> +        - clock-names
>>>> +        - power-domains
>>>
>>> Are these new properties also valid for am3352?
>>
>> No they are not required for am3352-elm. Only required for K3 based platforms like AM64.
>>
> 
> I understand they are not required, but I asked if they are valid. IOW,
> whether ELM in am3352 also is part of power domain and has clock input?

Yes it does have power and clock domains but they are handled a bit differently
on AM335x platform. i.e. in the parent node

e.g.

               target-module@80000 {                   /* 0x48080000, ap 38 18.0 */
                        compatible = "ti,sysc-omap2", "ti,sysc";
                        reg = <0x80000 0x4>,
                              <0x80010 0x4>,
                              <0x80014 0x4>;
                        reg-names = "rev", "sysc", "syss";
                        ti,sysc-mask = <(SYSC_OMAP2_CLOCKACTIVITY |
                                         SYSC_OMAP2_SOFTRESET |
                                         SYSC_OMAP2_AUTOIDLE)>;
                        ti,sysc-sidle = <SYSC_IDLE_FORCE>,
                                        <SYSC_IDLE_NO>,
                                        <SYSC_IDLE_SMART>;
                        ti,syss-mask = <1>;
                        /* Domains (P, C): per_pwrdm, l4ls_clkdm */
                        clocks = <&l4ls_clkctrl AM3_L4LS_ELM_CLKCTRL 0>;
                        clock-names = "fck";
                        #address-cells = <1>;
                        #size-cells = <1>;
                        ranges = <0x0 0x80000 0x10000>;

                        elm: elm@0 {
                                compatible = "ti,am3352-elm";
                                reg = <0x0 0x2000>;
                                interrupts = <4>;
                                status = "disabled";
                        };
                };

cheers,
-roger

Re: [PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM

[Krzysztof Kozlowski]

On 25/03/2022 13:13, Roger Quadros wrote:
> 
> 
> On 25/03/2022 14:08, Krzysztof Kozlowski wrote:
>> On 25/03/2022 13:05, Roger Quadros wrote:
>>>
>>>
>>> On 24/03/2022 20:26, Krzysztof Kozlowski wrote:
>>>> On 23/03/2022 12:18, Roger Quadros wrote:
>>>>> TI's AM64 SoC has the Error Locator Module. Add compatible and
>>>>> related properties to support ELM on AM64 SoC.
>>>>>
>>>>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>>>>> ---
>>>>>  .../devicetree/bindings/mtd/ti,elm.yaml       | 27 ++++++++++++++++++-
>>>>>  1 file changed, 26 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>>>> index 24ed0fb84204..bc01d35ce605 100644
>>>>> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>>>> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml
>>>>> @@ -17,7 +17,9 @@ description:
>>>>>  properties:
>>>>>    compatible:
>>>>>      items:
>>>>> -      - const: ti,am3352-elm
>>>>> +      - enum:
>>>>> +          - ti,am3352-elm
>>>>> +          - ti,am64-elm
>>>>>  
>>>>>    reg:
>>>>>      maxItems: 1
>>>>> @@ -25,6 +27,17 @@ properties:
>>>>>    interrupts:
>>>>>      maxItems: 1
>>>>>  
>>>>> +  clocks:
>>>>> +    maxItems: 1
>>>>> +    description: Functional clock.
>>>>> +
>>>>> +  clock-names:
>>>>> +    items:
>>>>> +      - const: fck
>>>>> +
>>>>> +  power-domains:
>>>>> +    maxItems: 1
>>>>> +
>>>>>    ti,hwmods:
>>>>>      description:
>>>>>        Name of the HWMOD associated with ELM. This is for legacy
>>>>> @@ -37,6 +50,18 @@ required:
>>>>>    - reg
>>>>>    - interrupts
>>>>>  
>>>>> +allOf:
>>>>> +  - if:
>>>>> +      properties:
>>>>> +        compatible:
>>>>> +          contains:
>>>>> +            const: ti,am64-elm
>>>>> +    then:
>>>>> +      required:
>>>>> +        - clocks
>>>>> +        - clock-names
>>>>> +        - power-domains
>>>>
>>>> Are these new properties also valid for am3352?
>>>
>>> No they are not required for am3352-elm. Only required for K3 based platforms like AM64.
>>>
>>
>> I understand they are not required, but I asked if they are valid. IOW,
>> whether ELM in am3352 also is part of power domain and has clock input?
> 
> Yes it does have power and clock domains but they are handled a bit differently
> on AM335x platform. i.e. in the parent node

Then I guess it can stay like this. Otherwise (if there is no clock
input) "else:" with "clocks:false" would be expected.


Best regards,
Krzysztof

[PATCH 3/3] mtd: rawnand: omap_elm: Add compatible for AM64 ELM

[Roger Quadros]

The AM64 SoC has the Error Locator Module. Add compatible id for it.

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 drivers/mtd/nand/raw/omap_elm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/raw/omap_elm.c b/drivers/mtd/nand/raw/omap_elm.c
index db105d9b560c..aa7f49c3f372 100644
--- a/drivers/mtd/nand/raw/omap_elm.c
+++ b/drivers/mtd/nand/raw/omap_elm.c
@@ -550,6 +550,7 @@ static SIMPLE_DEV_PM_OPS(elm_pm_ops, elm_suspend, elm_resume);
 #ifdef CONFIG_OF
 static const struct of_device_id elm_of_match[] = {
 	{ .compatible = "ti,am3352-elm" },
+	{ .compatible = "ti,am64-elm" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, elm_of_match);
-- 
2.17.1