Re: [RFC PATCH 2/6] of: reserved-memory: Add of_reserved_mem_lookup_by_name

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/07/2025 11:29, Viresh Kumar wrote:
> This adds of_reserved_mem_lookup_by_name() helper to get a

Add...


>  
> +/**
> + * of_reserved_mem_lookup_by_name() - acquire reserved_mem from node name
> + * @name:	node name
> + *
> + * This function allows drivers to acquire a reference to the reserved_mem
> + * struct based on a reserved-memory node name.
> + *
> + * Returns a reserved_mem reference, or NULL on error.
> + */
> +struct reserved_mem *of_reserved_mem_lookup_by_name(const char *name)
> +{
> +	struct device_node *np __free(device_node) =
> +		of_find_node_by_path("/reserved-memory");
> +	struct device_node *child __free(device_node) = NULL;

This should not be NULL or this should not be cleanup. Follow coding
style for cleanup - constructor must be real here. You probably wanted
scoped loop below.

> +
> +	if (!np)
> +		return ERR_PTR(-ENODEV);
> +
> +	for_each_child_of_node(np, child) {


Best regards,
Krzysztof