From: Krzysztof Kozlowski <krzk@kernel.org>
To: "ping.gao" <ping.gao@samsung.com>,
ulf.hansson@linaro.org, jh80.chung@samsung.com
Cc: shawn.lin@rock-chips.com, krzk+dt@kernel.org, robh@kernel.org,
conor+dt@kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kwangwon.min@samsung.com, hy50.seo@samsung.com
Subject: Re: [PATCH v4 3/3] mmc: dw_mmc: Using devm_clk_get_optional() for biu_clk
Date: Sat, 28 Feb 2026 10:44:47 +0100 [thread overview]
Message-ID: <b3352f81-89bf-4b9d-be96-2b45dfb3b9f3@kernel.org> (raw)
In-Reply-To: <20260228062457.3210099-4-ping.gao@samsung.com>
On 28/02/2026 07:24, ping.gao wrote:
> From: Ping Gao <ping.gao@samsung.com>
>
> By using devm_clk_get_optional, if clk is optional for device and not define in dts
> it will return NULL, then clk_prepare_enable/clk_disable_unprepare for biu_clk is safe to
> bail out internally.
>
> before biu_clk in dwmmc driver devm_clk_get fail, but it's ERR_PTR,
> not null,it will panic when call clk_prepare
> log is below:
> [7: binder:436_2: 4998] Unable to handle kernel paging request at virtual address fffffffffffffffe
> [7: binder:436_2: 4998] Mem abort info:
> [7: binder:436_2: 4998] ESR = 0x0000000096000005
> [7: binder:436_2: 4998] EC = 0x25: DABT (current EL), IL = 32 bits
> [7: binder:436_2: 4998] SET = 0, FnV = 0
> [7: binder:436_2: 4998] EA = 0, S1PTW = 0
> [7: binder:436_2: 4998] FSC = 0x05: level 1 translation fault
No, we don't support here your downstream kernel.
Start working on upstream instead, please.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-02-28 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260228062020epcas5p1e498c4fc67f590f4243645288c492f01@epcas5p1.samsung.com>
2026-02-28 6:24 ` [PATCH v4 0/3] mmc: dw_mmc: Support optional BIU clock ping.gao
2026-02-28 6:24 ` [PATCH v4 1/3] dt-bindings: mmc: synopsys-dw-mshc: relax clocks constraint ping.gao
2026-02-28 9:44 ` Krzysztof Kozlowski
2026-02-28 10:12 ` Krzysztof Kozlowski
2026-03-06 2:05 ` ping.gao
2026-02-28 6:24 ` [PATCH v4 2/3] mmc: dw_mmc-k3: before set biu_clk rate, check biu_clk available or not ping.gao
2026-02-28 6:24 ` [PATCH v4 3/3] mmc: dw_mmc: Using devm_clk_get_optional() for biu_clk ping.gao
2026-02-28 9:44 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3352f81-89bf-4b9d-be96-2b45dfb3b9f3@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hy50.seo@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=krzk+dt@kernel.org \
--cc=kwangwon.min@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ping.gao@samsung.com \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox