From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8346C433FE for ; Wed, 19 Oct 2022 13:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233728AbiJSNxZ (ORCPT ); Wed, 19 Oct 2022 09:53:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233758AbiJSNw5 (ORCPT ); Wed, 19 Oct 2022 09:52:57 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70F7D1C8110 for ; Wed, 19 Oct 2022 06:36:31 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id m6so10660431qkm.4 for ; Wed, 19 Oct 2022 06:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=spOHuMkUzxNQDF31ZQ14bo2Slaj0LH2xXCN8rwJWrnI=; b=w+CMYrks958c8ml3PmlfBooj70tDMnLmjJmSQ7i5gkstqLRFgYVvEj4aNS4tX2afCi KuYAkUXp8mTQ6lM1dnCZFg1Uvepgbs5c9hw81imvk3Tg5Q6JRw5SM4CKE7uE2wlRlbDO 3bglyUheaLDRyGmGCGgf0t9tUyqyX+W8Vn+6e6fA57MekTOVvqR8W/faGWEx15EM71LX ilmjv2dZ8Yh6IfLlrNkW1hMEXmJCiF+YXGIBe7S/PQpQ2qvgekGFjjaSxDTmXTqrsJSX 8XBwueSqOpqKy5h/oBJIzKsByESd00LhMrJ3vZ6vY2SGo1wLocFxESEJu+NPTun2/TOQ 6Jlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=spOHuMkUzxNQDF31ZQ14bo2Slaj0LH2xXCN8rwJWrnI=; b=6UXumAspwe9CmXkpY5yH93vq87o1m4lJt7a6oVTJ959p+J8Ntiqlz1w+TM4+irqnX6 HfSVlLnBU2YP1tBT21XlP5zsOx3glaIfzvP/dzPhzKyuLrrwY+cAOdWGGe7ZE7iLDgqX Q91/dBSyXE3PFzNgnEbz6WSAc7mk72bIwoR6fype2yl9P2z9g2Tnt4WgspZnbp8WavrV 9DoVnNKHQ3z24Jr3jfWs2LmvNkViDxKKpzQX/fWpfNR6ftdy9DMle5g4t5o3jlmDefUf dOFPh47kgKgTY5hSOMA94mJiWEdWCa6X6mhLnwUKpsUs1ORWVtk1jVJr2/53EPu9qshD 5Gow== X-Gm-Message-State: ACrzQf0gwC1FnXYtjn5bUbcl9cOxTOmwQZ05zjVnVFa1yEt52wG18+ka zFLIsVenofg8BeCdEBTvvIeqr1IN1Ns6og== X-Google-Smtp-Source: AMsMyM4YZyJwWnHgYffvrOP+BQyLg9L1WUxQQbV6BkIOfB1dOifPywxyt/QXAnfCIv35UpoMV3cqLg== X-Received: by 2002:a05:620a:2697:b0:6cf:33cd:2bd2 with SMTP id c23-20020a05620a269700b006cf33cd2bd2mr5404994qkp.341.1666186586436; Wed, 19 Oct 2022 06:36:26 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id ca27-20020a05622a1f1b00b003436103df40sm4052757qtb.8.2022.10.19.06.36.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 06:36:25 -0700 (PDT) Message-ID: Date: Wed, 19 Oct 2022 09:36:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 2/2] dt-bindings: add bindings for QCOM flash LED Content-Language: en-US To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Pavel Machek , Rob Herring , Krzysztof Kozlowski , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com References: <20221018014024.948731-1-quic_fenglinw@quicinc.com> <20221018014024.948731-3-quic_fenglinw@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20221018014024.948731-3-quic_fenglinw@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/10/2022 21:40, Fenglin Wu wrote: > Add binding document for flash LED module inside Qualcomm Technologies, > Inc. PMICs. Use subject prefixes matching the subsystem (git log --oneline -- ...). This means: 1. you miss subsystem prefix 2. drop redundant second "bindings" > > Signed-off-by: Fenglin Wu > --- > .../bindings/leds/qcom,spmi-flash-led.yaml | 116 ++++++++++++++++++ > 1 file changed, 116 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml > > diff --git a/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml > new file mode 100644 > index 000000000000..d8efde02db72 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/qcom,spmi-flash-led.yaml > @@ -0,0 +1,116 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/qcom,spmi-flash-led.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Flash LED device inside Qualcomm Technologies, Inc. PMICs > + > +maintainers: > + - Fenglin Wu > + > +description: | > + Flash LED controller is present inside some Qualcomm Technologies, Inc. PMICs. > + The flash LED module can have different number of LED channels supported > + e.g. 3 or 4. There are some different registers between them but they can > + both support maximum current up to 1.5 A per channel and they can also support > + ganging 2 channels together to supply maximum current up to 2 A. The current > + will be split symmetrically on each channel and they will be enabled and > + disabled at the same time. > + > +properties: > + compatible: > + items: > + - enum: > + - qcom,pm8150c-flash-led > + - qcom,pm8150l-flash-led > + - qcom,pm8350c-flash-led > + - const: qcom,spmi-flash-led Blank line > + reg: > + description: address offset of the flash LED controller Drop description, it's obvious. > + maxItems: 1 > + > +patternProperties: > + "^led-[0-3]$": > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + description: | No need for | > + Represents the physical LED components which are connected to the > + flash LED channels' output. > + > + properties: > + led-sources: > + description: | No need for | Rest looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof