From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4614285069 for ; Tue, 16 Sep 2025 08:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758009861; cv=none; b=qMmYP9zvlZ8CUmmlvAjNvSBPxbI8TLsJh7IKzph2qAq7i5hysj/UF3tA7DN0puH9U5CXCxcdl6z4gjVGHrrgzeVxGXBnp3ZKGtfckAmKaooq96hKxaLRgUxaD36uEZO83rE/SOzqeOVOPviwXhmjb1kv7Fk1qj0bwGoUecKS2Is= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758009861; c=relaxed/simple; bh=MNvlhLg8T5jVTXPi8BC/ZgKt7EeQ5fPjlU+o+01GoDM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fe0fIvQzz1HB4qtPEiNYV2MwixsXxRQDiJB0lXqgVJEpydVEk54W1u4xRXHbIjXl4mwS5njq1cKSN1+0IhoSFeQFaaxcmp2sAFyT3ZH5lQv9co4wXPZApg6nCQJn6eQWro0O06gdprXQRbBLD+eV8WLUm7lOIzAdkAbu8bjSa4k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mst3Nk8q; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mst3Nk8q" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-55f78e3cdf9so5960799e87.1 for ; Tue, 16 Sep 2025 01:04:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758009858; x=1758614658; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4P7S8hmaYihFI7uhYTzYx531ZGw0hfreIoPsZI54Jik=; b=Mst3Nk8qVk6BIgxv9hLCjRiOb2bmMOtJ7Eig+RU1Zaf52nJP8N/8511kIruOVzARSM OgHAJ4GcCQP3uWshzLg8a7CRXTJSBdvMY4lbVtrvJlCvgamjsmz2cCxY37TO/pI27c13 J8yDapUFRDGZmivqiX7Lf7iN2gsid89YY/LyE242AcaJMay+f0tfXFzxW3xALORHXeqx akiFlc6hsKXzrX04tg9lW4FJ1KrC3tszNAT8O7b0S+LFNMQilsPiC4FrNh7+E1zSURww xoxV1dKLKlUlsu+tEX2LOQhKAuzYEiq+1zG0zR+MViucV0xB0/M6+Kg6riwmRTm9eHBb oFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758009858; x=1758614658; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4P7S8hmaYihFI7uhYTzYx531ZGw0hfreIoPsZI54Jik=; b=glATWQet0R+TfNT1eytE2TSmd7PIn0LEZkKVocpnh/ImUTZ/GOkZ8aKwtScGAwE5Bm SJdywHZu7AGkKW+hu183KUxLV2pL4DzzzVzmRQxzDJ38PGNteEajdJiNeNVK9reHbTgG pjBuGWtPjdUHsbYV3Fz+eb0cF931DdxngwLTr31jTJ9M/unJaPUfO0lWIYE/jskS93zk aOmCRC3rvhsOWuO7LEh00tZrtFCKsIcmFYkhGUz1YBR6vLzFutcs8mYs/z+hFSk6b0Ne k20aGM6RJv2ni9EKl7xevCrDJyt7V2hrz8W0ASBH9KBHNugt7wSCHAZ5aU4GhlcoXqi1 Lb1Q== X-Forwarded-Encrypted: i=1; AJvYcCVWjzT5lZ34nkB8etZwtA5JPZOwqVKp5/+6IQlMkbEmW2wUvvRCFp8BPwgmnho1akpyN61rNZQKt02n@vger.kernel.org X-Gm-Message-State: AOJu0YzrwWpYlCwfI/k8fpvsPVM2b5c4+Thfj3TDrsbAXv4Grzv1gsNl 3bVeC9sZaWrw+HpR5AJ7GMBkvrx+G872NTYwpBZbR+n0vrSCQ/VY4Bfn X-Gm-Gg: ASbGncupIC3TL1ajnlAFkPSrFwSqzOA3glmBGsATcARhNjyIm8t1geUrnq+LNfmAZaT FKZgcFxpkmacGx11OqfXvDDA3Wa+/xKx/YY7TgOzj0QwF/EGbzsHEQqPo9PMqZpBt58V6ybPzsd 8H7duXY/rQuiJbT6wUc9OzP7y8bK7IHWd7ScmwKcjb9u+QE+V0X3GiND7tBAKiF/EMWipm0Z49N sghZtHnTwXHOPaAmhY9jNlFJdiHapvWnBArnqB8axXO6AwjZg3l1xxQnHG3B7ksHd+X9pWXfCox 9L66MbNs4o5Zg/391BqZD1V1slROQvf6ZmBOIXrLI1xa5HHxrdsqBzzYABtYx5pUUrd2ZfcQCHY YbcSubKOrcQ+JPaiWVYPLAGt90CzMVXblgJb/W91xtRWIT27WJKieRM6QlSlW/1knqjxN4gVV6i 4EnRTF X-Google-Smtp-Source: AGHT+IFIOSeqw4PYtMvjdrOVsg9klefu6E0u1vhsc82aTrTg6jl010DCPH8XGwIGvu11SJLHEXDYIg== X-Received: by 2002:ac2:4e99:0:b0:56e:53bc:7465 with SMTP id 2adb3069b0e04-5704e723ebbmr3896222e87.43.1758009857617; Tue, 16 Sep 2025 01:04:17 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-571a6d1c5absm3115808e87.40.2025.09.16.01.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Sep 2025 01:04:17 -0700 (PDT) Message-ID: Date: Tue, 16 Sep 2025 11:04:16 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO To: Andy Shevchenko Cc: Andy Shevchenko , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20250915-bd79112-v5-0-a74e011a0560@gmail.com> <20250915-bd79112-v5-2-a74e011a0560@gmail.com> <0b97adc3-4d77-480f-ace9-a53403c62216@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/09/2025 10:39, Andy Shevchenko wrote: > On Tue, Sep 16, 2025 at 7:48 AM Matti Vaittinen > wrote: >> On 15/09/2025 17:12, Andy Shevchenko wrote: >>> On Mon, Sep 15, 2025 at 10:12:43AM +0300, Matti Vaittinen wrote: > ... > >>>> + devm_spi_optimize_message(dev, spi, &data->read_msg); >>> >>> And if it fails?.. >> >> I am not really sure under what conditions this would fail. Without >> taking a further look at that - then we just use unoptimized SPI >> transfers(?). Could warrant a warning print though. > > What is the point of having devm_ variant for it if it never fails, please? I didn't say it never fails. I said that I don't know what can cause the failure. Because I don't know this, I can't say if it is reasonable to assume the SPI (or the system in general) are in unusable state making the failure a show-stopper for this driver. If the failure is indicating "only" a failure of "optimization" this call does, then the driver should still be able to do it's job even if the SPI performance was reduced. Hence aborting the probe might not be necessary but the driver could proceed - although emitting a warning should make sense. Well, I presume failing of the devm_spi_optimize_message() is not likely to happen if system is working correctly. Thus I'm not against Jonathan's edit which aborts the probe. Yours, -- Matti