From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A0EECAAD5 for ; Mon, 12 Sep 2022 10:59:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbiILK7a (ORCPT ); Mon, 12 Sep 2022 06:59:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229979AbiILK73 (ORCPT ); Mon, 12 Sep 2022 06:59:29 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CFE23AB39 for ; Mon, 12 Sep 2022 03:59:25 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id k10so14193069lfm.4 for ; Mon, 12 Sep 2022 03:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=CMrXYaGd9ZuPwxoNdr3XH/ga8t3rjLvzGOmRkyTn3g4=; b=EewBJK9lJIVVIFZKkl8dLluz2Rdy1ntj1KjhRquGAFJS+M1ds/Xwvtbd+2yebKnSY/ d3kTQ+Vz1KIH4DhRg8Cw8xACvbVVXAsvID4WBMm/nkUZP2npSatCoYOXaRoa9kc/Tkt7 /topHc7fSV4h6p58PvDBiDHJNpY85eULd6TZwcJN44bJW16l4EgHp2oBXlYwVLpZMI5H XmtjwOs8q7SQxC/rUL8HwxjfrquHiU6zH+RK6YFhHltQFV5gNhNeW+VNoqh438fAl01q yzTFzxjOVwTsCnebCWWYsziqICUrMR8b9sPuf3yg7UzElZ7936iArGpJJkMOlTHMkQqM wdGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=CMrXYaGd9ZuPwxoNdr3XH/ga8t3rjLvzGOmRkyTn3g4=; b=UMIDRzmjCJ68y9i1MrvSK4EyDxHFGJij7YXMXcmbvRutSu1745d06eJNTFp5fEHKCm tiBKzrsEI7TH9RBqZ0LK4TAgd1IbOStHfguooBaPLq4N+yAvCchzcv+/WKZk0oLq+LKB OOG7mejnCF9x0hcz25aZ+ngL4JXwmJWrrgj7gc4+5pqvWRait1kCOzC4L12tc4AGWJrU eYzbaRNYGnDrICPAUfJ2m2q7fZGMM+4UjJeGk6xLkHhuJ/rppig9SBPJLRkDBNR7jT+A lWilUwvguoQl62CEr5h1HdEzwgZTKa4F2pNAX45e/y+dM22WoMCbQyNXgFkZNqKBoQxx vzMA== X-Gm-Message-State: ACgBeo1yN51XMLCJPIeLQ60XcFCmS7zckRwN8E5yh+rcW91KRI2aDYG6 MQS4AMfgNeLMXNlIYCn8i1YdUw== X-Google-Smtp-Source: AA6agR79u4VfbHvM2AGUDo4UiTk9vFf7uaAXP5srMfNWlWtZd7B/cZLyZS3VkamXHLZWSSjOiS3nkw== X-Received: by 2002:a05:6512:409:b0:49a:eadb:5ec9 with SMTP id u9-20020a056512040900b0049aeadb5ec9mr622074lfk.253.1662980363641; Mon, 12 Sep 2022 03:59:23 -0700 (PDT) Received: from [10.129.96.84] ([109.232.243.34]) by smtp.gmail.com with ESMTPSA id be30-20020a056512251e00b00492a0f02758sm1009117lfb.28.2022.09.12.03.59.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 03:59:23 -0700 (PDT) Message-ID: Date: Mon, 12 Sep 2022 12:59:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 2/7] dt-bindings: usb: Add special clock for Allwinner H616 PHY Content-Language: en-US To: Andre Przywara , Jernej Skrabec , Samuel Holland , Chen-Yu Tsai , Kishon Vijay Abraham I , Vinod Koul Cc: Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Karl Kurbjun , Icenowy Zheng References: <20220911235945.6635-1-andre.przywara@arm.com> <20220911235945.6635-3-andre.przywara@arm.com> From: Krzysztof Kozlowski In-Reply-To: <20220911235945.6635-3-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/09/2022 01:59, Andre Przywara wrote: Thank you for your patch. There is something to discuss/improve. > clocks: > + minItems: 4 > items: > - description: USB OTG PHY bus clock > - description: USB Host 0 PHY bus clock > - description: USB Host 1 PHY bus clock > - description: USB Host 2 PHY bus clock > + - description: PMU clock for host port 2 > > clock-names: > + minItems: 4 > items: > - const: usb0_phy > - const: usb1_phy > - const: usb2_phy > - const: usb3_phy > + - const: pmu2_clk > > resets: > items: > @@ -98,6 +102,21 @@ required: > > additionalProperties: false > > +if: Please enclose it within allOf: block. Helps to reduce indentation changes later when this grows. > + properties: > + compatible: > + contains: > + enum: > + - sun50i-h616-usb-phy > + > +then: > + properties: > + clocks: > + minItems: 5 > + > + clock-names: > + minItems: 5 I assume other variants do not have this clock? If correct, then: else: clocks: maxItems: 4 and the same for clock-names > + > examples: > - | > #include Best regards, Krzysztof