From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor Dooley <conor.dooley@microchip.com>,
William Qiu <william.qiu@starfivetech.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-mmc@vger.kernel.org,
Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties
Date: Wed, 30 Aug 2023 09:29:20 +0200 [thread overview]
Message-ID: <b375b88c-0d9c-30a9-21f6-283083cf3880@linaro.org> (raw)
In-Reply-To: <20230830-commence-trickery-40eaa193cb15@wendy>
On 30/08/2023 08:50, Conor Dooley wrote:
> On Wed, Aug 30, 2023 at 11:18:44AM +0800, William Qiu wrote:
>> Due to the change of tuning implementation, it's no longer necessary to
>> use the "starfive,sysreg" property in dts, so drop the relevant
>> description in dt-bindings here.
>
> How does changing your software implantation invalidate a description of
> the hardware?
>
Which is kind of proof that this syscon was just to substitute
incomplete hardware description (e.g. missing clocks and phys). We
should have rejected it. Just like we should reject them in the future.
There are just few cases where syscon is reasonable. All others is just
laziness. It's not only starfivetech, of course. Several other
contributors do the same.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-30 18:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 3:18 [PATCH v1 0/3] Change tuning implementation William Qiu
2023-08-30 3:18 ` [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties William Qiu
2023-08-30 6:50 ` Conor Dooley
2023-08-30 7:29 ` Krzysztof Kozlowski [this message]
2023-08-30 8:34 ` Conor Dooley
2023-09-01 2:33 ` William Qiu
2023-09-01 15:42 ` Conor Dooley
2023-09-01 17:20 ` Jessica Clarke
2023-09-01 17:43 ` Conor Dooley
2023-09-01 18:39 ` Jessica Clarke
2023-09-08 10:01 ` William Qiu
2023-09-08 13:32 ` Emil Renner Berthing
2023-09-11 16:14 ` Conor Dooley
2023-09-12 2:00 ` William Qiu
2023-08-30 3:18 ` [PATCH v1 2/3] mmc: starfive: Change tuning implementation William Qiu
2023-08-30 10:28 ` Emil Renner Berthing
2023-09-01 2:40 ` William Qiu
2023-08-30 3:18 ` [PATCH v1 3/3] riscv: dts: starfive: Drop unused properties and limit frquency William Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b375b88c-0d9c-30a9-21f6-283083cf3880@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=william.qiu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).