From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksij Rempel Subject: Re: [PATCH v6 3/6] kernel/reboot.c: export pm_power_off_prepare Date: Thu, 7 Dec 2017 06:36:55 +0100 Message-ID: References: <20171206072402.11694-1-o.rempel@pengutronix.de> <20171206072402.11694-4-o.rempel@pengutronix.de> <20171206231130.GA6235@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171206231130.GA6235@infradead.org> Content-Language: en-US Sender: linux-clk-owner@vger.kernel.org To: Christoph Hellwig Cc: Mark Rutland , devicetree@vger.kernel.org, Liam Girdwood , Shawn Guo , Michael Turquette , Stephen Boyd , Russell King , linux-kernel@vger.kernel.org, Rob Herring , Mark Brown , kernel@pengutronix.de, Fabio Estevam , Andrew Morton , Leonard Crestez , Linus Torvalds , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 07.12.2017 00:11, Christoph Hellwig wrote: >> void (*pm_power_off_prepare)(void); >> +EXPORT_SYMBOL(pm_power_off_prepare); > > EXPORT_SYMBOL_GPL for something this deeply internal, please. Ok, probably all other symbols should be converted in this file in to EXPORT_SYMBOL_GPL as well? grep EXPORT_SYMBOL kernel/reboot.c EXPORT_SYMBOL(cad_pid); EXPORT_SYMBOL(pm_power_off_prepare); EXPORT_SYMBOL_GPL(emergency_restart); EXPORT_SYMBOL(register_reboot_notifier); EXPORT_SYMBOL(unregister_reboot_notifier); EXPORT_SYMBOL(devm_register_reboot_notifier); EXPORT_SYMBOL(register_restart_handler); EXPORT_SYMBOL(unregister_restart_handler); EXPORT_SYMBOL_GPL(kernel_restart); EXPORT_SYMBOL_GPL(kernel_halt); EXPORT_SYMBOL_GPL(kernel_power_off); EXPORT_SYMBOL_GPL(orderly_poweroff); EXPORT_SYMBOL_GPL(orderly_reboot);