From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F0DC71153 for ; Thu, 24 Aug 2023 07:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240305AbjHXHP6 (ORCPT ); Thu, 24 Aug 2023 03:15:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240467AbjHXHP5 (ORCPT ); Thu, 24 Aug 2023 03:15:57 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 166EAE4E for ; Thu, 24 Aug 2023 00:15:55 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99de884ad25so853777466b.3 for ; Thu, 24 Aug 2023 00:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692861353; x=1693466153; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MgLATBYJzz7m+lw2uYv1KHF9JGwpz8b2a+H6baqeGgg=; b=FcS0oOd6aB0ImZi68UnNSZl+uztMLQO+hKR5O5gmerz1xHTVNkNEqEY2XtSws7CXCn pxscU0RkTra7sIvakFf6UmdJ1hjsmTFLw0TADvPbWzJ24lgmZuceFWkgpPk/gh0D5Dvf Tw5yE8gWjRqrpUpk8ds/Kxr5MGZB82o7YpJdI+mNrbyHX4o1JD70Bps+qgIZoyWUcGGu Drtv0/Ud8sd3wOSEwrguknfyHl+coRy2dP5HFUpHEeRzx9ZFvt9gldvMG+IfTTSZ2Qt9 Ft/0TUWH6LXjHCPZGQVJMjlpeGBNNLKYW8Og5Zxtp9zDCRmGg2wFn3ThwrHbMzpy4UWv b0KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692861353; x=1693466153; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MgLATBYJzz7m+lw2uYv1KHF9JGwpz8b2a+H6baqeGgg=; b=cpTtwjZSlw0KN+W/zi/0bc3gw+nULntterAWCaUd/tZXlhVVXtL+zU0eVYgad86eCX uKvuAb6tGJ0IvYbtiFfYSWFD+mfNIqUmtX0WTggeeS6IaAc1TP3DYzck0fx8IgIvClJ+ zauPK4J08AntNKp3luTFa6zbJpDt4FlIbKcoy4UX1/GRa14NBNzibIzcHkEfY5BPawcd jhN04CPBu9ZCi1MLXc1UO0vziW+U6lG3FeZ+qvL8rNPlgaiSm/80BHX095GwpyjI9CYH nvuDLb+NkouV7ZJ45T1P3aHwLhn/A9qlEZ594LRLlHoap9wevtoVqhTX0aopoYKT7PBl 26fQ== X-Gm-Message-State: AOJu0YwGduOHAGxLDM2N0nSlpU6fosZJ8PxLllgOnVbd/L7C3ZtMaKW0 l9jV3cvTE/E+dKcfhe+0k77MEA== X-Google-Smtp-Source: AGHT+IERlDVVWHhshVztkfejQKy+zATfjV9rmg6d5qwDMRx+kT7ZhgVa2HTV0j0RMbXHGk/Q6a2F3w== X-Received: by 2002:a17:906:1ba1:b0:987:4e89:577f with SMTP id r1-20020a1709061ba100b009874e89577fmr11005277ejg.24.1692861353577; Thu, 24 Aug 2023 00:15:53 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id sa19-20020a170906edb300b0099ca4f61a8bsm10683298ejb.92.2023.08.24.00.15.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 00:15:53 -0700 (PDT) Message-ID: Date: Thu, 24 Aug 2023 09:15:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 2/2] dt-bindings: dma: hisi: Add bindings for Hisi Ascend sdma Content-Language: en-US To: Guo Mengqi , vkoul@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org Cc: xuqiang36@huawei.com, chenweilong@huawei.com References: <20230824040007.1476-1-guomengqi3@huawei.com> <20230824040007.1476-3-guomengqi3@huawei.com> From: Krzysztof Kozlowski In-Reply-To: <20230824040007.1476-3-guomengqi3@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/08/2023 06:00, Guo Mengqi wrote: > Add device-tree binding documentation for the Hisi Ascend sdma > controller. > > Signed-off-by: Guo Mengqi > --- > .../bindings/dma/hisi,ascend-sdma.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/hisi,ascend-sdma.yaml Filename matching compatible, so hisilicon,ascend-sdma.yaml. hisi, is a deprecated prefix, so don't use it. > > diff --git a/Documentation/devicetree/bindings/dma/hisi,ascend-sdma.yaml b/Documentation/devicetree/bindings/dma/hisi,ascend-sdma.yaml > new file mode 100644 > index 000000000000..87b6132c1b4b > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/hisi,ascend-sdma.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/hisi,ascend-sdma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HISI Ascend System DMA (SDMA) controller What is HISI? HiSilicon? > + > +description: | > + The Ascend SDMA controller is used for transferring data > + in system memory. It utilizes IOMMU SVA feature and accepts > + virtual address from user process. > + > +maintainers: > + - Guo Mengqi > + > +allOf: > + - $ref: dma-controller.yaml# > + > +properties: > + compatible: > + enum: > + - hisilicon,ascend310-sdma > + - hisilicon,ascend910-sdma > + > + reg: > + maxItems: 1 > + > + '#dma-cells': > + const: 1 > + description: > + Clients specify a single cell with channel number. > + > + hisilicon,ascend-sdma-channel-map: > + description: | > + bitmap, each bit stands for a channel that is allowed to > + use by this system. Maximum 64 bits. > + $ref: /schemas/types.yaml#/definitions/uint64 Why some channels would not be allowed to be used on some board with ascend310? Who decides on this? > + > + iommus: > + maxItems: 1 > + > + pasid-num-bits: > + description: | > + sdma utilizes iommu sva feature to transfer user space data. > + It acts as a basic dma controller if not bound to user space. > + const: 0x10 Best regards, Krzysztof