Re: [PATCH v2 3/4] ARM: dts: renesas: r8a7740: Add ZT/ZTR trace clock on R-Mobile A1

Krzysztof Kozlowski
2026-04-23T14:00:16Z

On 23/04/2026 12:00, Marek Vasut wrote:
> On 4/23/26 11:26 AM, Krzysztof Kozlowski wrote:
>> On 23/04/2026 01:33, Marek Vasut wrote:
>>> On 4/21/26 10:02 AM, Krzysztof Kozlowski wrote:
>>>> On Thu, Apr 16, 2026 at 01:31:40AM +0200, Marek Vasut wrote:
>>>>> Add ZT trace bus and ZTR trace clock on the R-Mobile A1.
>>>>>
>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>>>> ---
>>>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>>>> Cc: Magnus Damm <magnus.damm@gmail.com>
>>>>> Cc: Michael Turquette <mturquette@baylibre.com>
>>>>> Cc: Rob Herring <robh@kernel.org>
>>>>> Cc: Stephen Boyd <sboyd@kernel.org>
>>>>> Cc: devicetree@vger.kernel.org
>>>>> Cc: linux-clk@vger.kernel.org
>>>>> Cc: linux-kernel@vger.kernel.org
>>>>> Cc: linux-renesas-soc@vger.kernel.org
>>>>> ---
>>>>> V2: Add ztr/zt clock at the end of the list to match bindings
>>>>> ---
>>>>> arch/arm/boot/dts/renesas/r8a7740.dtsi | 2 +-
>>>>
>>>>> include/dt-bindings/clock/r8a7740-clock.h | 2 ++
>>>>
>>>> This goes to the binding patch.
>>>>
>>>> Didn't you have also a checkpatch warning?
>>> I only got this warning, but the docs 1/4 and includes 3/4 are a
>>> separate patch in this series:
>>>
>>> "
>>> WARNING: DT binding docs and includes should be a separate patch. See:
>>> Documentation/devicetree/bindings/submitting-patches.rst
>>
>> So you did not implement it... Include goes with the binding. Always.
>> Look at other commits.
> The warning says the exact opposite thing , does it not ?
>
> Maybe the warning text needs to be updated ?

The warning is shown for patches mixing stuff, like DTSI+header, so for
this context the AND means binding doc plus header are separate FROM
this patch. Not separate from each other.

To me it is clear, so I don't feel like finding different text. If you
find it unclear or confusing, you should propose something better.

Best regards,
Krzysztof