From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4342C433FE for ; Thu, 17 Nov 2022 12:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234629AbiKQMx6 (ORCPT ); Thu, 17 Nov 2022 07:53:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234774AbiKQMxn (ORCPT ); Thu, 17 Nov 2022 07:53:43 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2827621E28 for ; Thu, 17 Nov 2022 04:53:41 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id z24so2583701ljn.4 for ; Thu, 17 Nov 2022 04:53:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yz9LbFJ98Q5Qeq2EfeWsSRXcShkgGmPZGX7k4Xr8AA4=; b=FxUezgq5lFaQmsE86Oe+cRPswg7lpnio897yi98W9FoBDzHDYHQ00pk5qFozySgm00 M1gJfXlnBzTVgzEpFzpF4j6ftTynxyzFwP92l9W7PCBYtPmgHzHD5G0z8EYlml7UNRAU 99YOxC8/2V2MLfdcGZ7Dp/oFnRmErzhDNXYoYDr+S0y9g/RIC6pvJwCLWI0tWaMMhkZ0 /7edoo7lSQHNo8k+iMkRFqranSn3ZRv4F5IUaTp5MVjKF7JpCBJMlofOiZRUmmPdVQ2N 8JNDQLIBDgwOogo0Ab0Og0J11S5+ZaRicnKb6BVoBzmmfkhCS3Vy+gZ1sSYYngf4srKP +eHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yz9LbFJ98Q5Qeq2EfeWsSRXcShkgGmPZGX7k4Xr8AA4=; b=0ekt/Uqv3POVWnR1PdLHT5mOOw9+GQ4oHPfuBWDS6RhMd4N+V3Fe56C7TnhsRyrX2p /WUCvyizGwZs2SY2kmcdSruFFMV2C05tXmhqrM3LK6gujGp2wvdQrCzj2U6zm8RUA0ui Bvx050oBsdyh3fqlvc4QbarjKKnav7dPvnfVzdf7CyMAwGwiqdcIMwbPaR9r9w4nQ3Nx OdSzP8YjmgWHCErHHITUl9rfjWlrCf7MbE7vb6suERP5S6+BSe/yk1FsR3wq+hUeyP89 VI/K26vW2HCwCazuGj4qTipBC1c3eRBOXUx+sQzLBoa3fg/GeQ2mkyY+VysB4isBdKz/ bBMQ== X-Gm-Message-State: ANoB5plZPe9vdqggmxDIN4TP7GEB5XaYuF9+Q9X2wUpVkUhlt6x5VgpM LlUR5JhL7tjElrO9nCiMF3HYOA== X-Google-Smtp-Source: AA0mqf4WDluiqQuCkt7LLZYI1TPTfVBfMSgwsEqO4Lq/z5zPn3LbGjpRxf4Sx08uOwIyRL6VuqKvzg== X-Received: by 2002:a05:651c:158a:b0:26f:c160:6dde with SMTP id h10-20020a05651c158a00b0026fc1606ddemr901540ljq.20.1668689619500; Thu, 17 Nov 2022 04:53:39 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id k8-20020a05651210c800b0048a982ad0a8sm140092lfg.23.2022.11.17.04.53.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 04:53:38 -0800 (PST) Message-ID: Date: Thu, 17 Nov 2022 13:53:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 10/10] arm64: dts: qcom: Add base SM8550 MTP dts Content-Language: en-US To: Abel Vesa , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , "vkoul@kernel.org" , Srinivas Kandagatla References: <20221116103146.2556846-1-abel.vesa@linaro.org> <20221116103146.2556846-11-abel.vesa@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221116103146.2556846-11-abel.vesa@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/11/2022 11:31, Abel Vesa wrote: > Add dts file for Qualcomm MTP platform which uses SM8550 SoC. > > Co-developed-by: Neil Armstrong > Signed-off-by: Neil Armstrong > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 419 ++++++++++++++++++++++++ > 2 files changed, 420 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sm8550-mtp.dts Thank you for your patch. There is something to discuss/improve. > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index afe496a93f94..b447b3082c84 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -169,3 +169,4 @@ dtb-$(CONFIG_ARCH_QCOM) += sm8350-sony-xperia-sagami-pdx215.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8450-hdk.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8450-qrd.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm8450-sony-xperia-nagara-pdx223.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sm8550-mtp.dtb > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > new file mode 100644 > index 000000000000..d4c8d5b2497e > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -0,0 +1,419 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2022, Linaro Limited > + */ > + > +/dts-v1/; > + > +#include > +#include "sm8550.dtsi" > +#include "pm8010.dtsi" > +#include "pm8550.dtsi" > +#include "pm8550b.dtsi" > +#include "pm8550ve.dtsi" > +#include "pm8550vs.dtsi" > +#include "pmk8550.dtsi" > +#include "pmr735d.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. SM8550 MTP"; > + compatible = "qcom,sm8550-mtp", "qcom,sm8550"; > + > + aliases { > + serial0 = &uart7; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-min-microvolt = <3700000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-always-on; > + regulator-boot-on; > + }; > +}; > + > +&apps_rsc { > + pm8550b-rpmh-regulators { Node name: regulators-0 > + compatible = "qcom,pm8550-rpmh-regulators"; > + qcom,pmic-id = "b"; > + > + vdd-bob1-supply = <&vph_pwr>; > + vdd-bob2-supply = <&vph_pwr>; > + vdd-l2-l13-l14-supply = <&vreg_bob1>; > + vdd-l3-supply = <&vreg_s4g_1p3>; > + vdd-l5-l16-supply = <&vreg_bob1>; > + vdd-l6-l7-supply = <&vreg_bob1>; > + vdd-l8-l9-supply = <&vreg_bob1>; > + vdd-l11-supply = <&vreg_s4g_1p3>; > + vdd-l12-supply = <&vreg_s6g_1p8>; > + vdd-l15-supply = <&vreg_s6g_1p8>; > + vdd-l17-supply = <&vreg_bob2>; > + > + vreg_bob1: bob1 { > + regulator-name = "vreg_bob1"; > + regulator-min-microvolt = <3296000>; > + regulator-max-microvolt = <3960000>; > + regulator-initial-mode = ; > + }; > + > + vreg_bob2: bob2 { > + regulator-name = "vreg_bob2"; > + regulator-min-microvolt = <2720000>; > + regulator-max-microvolt = <3960000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l1b_1p8: ldo1 { > + regulator-name = "vreg_l1b_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l2b_3p0: ldo2 { > + regulator-name = "vreg_l2b_3p0"; > + regulator-min-microvolt = <3008000>; > + regulator-max-microvolt = <3008000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l5b_3p1: ldo5 { > + regulator-name = "vreg_l5b_3p1"; > + regulator-min-microvolt = <3104000>; > + regulator-max-microvolt = <3104000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l6b_1p8: ldo6 { > + regulator-name = "vreg_l6b_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3008000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l7b_1p8: ldo7 { > + regulator-name = "vreg_l7b_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3008000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l8b_1p8: ldo8 { > + regulator-name = "vreg_l8b_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3008000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l9b_2p9: ldo9 { > + regulator-name = "vreg_l9b_2p9"; > + regulator-min-microvolt = <2960000>; > + regulator-max-microvolt = <3008000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l11b_1p2: ldo11 { > + regulator-name = "vreg_l11b_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1504000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l12b_1p8: ldo12 { > + regulator-name = "vreg_l12b_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l13b_3p0: ldo13 { > + regulator-name = "vreg_l13b_3p0"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l14b_3p2: ldo14 { > + regulator-name = "vreg_l14b_3p2"; > + regulator-min-microvolt = <3200000>; > + regulator-max-microvolt = <3200000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l15b_1p8: ldo15 { > + regulator-name = "vreg_l15b_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l16b_2p8: ldo16 { > + regulator-name = "vreg_l16b_2p8"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l17b_2p5: ldo17 { > + regulator-name = "vreg_l17b_2p5"; > + regulator-min-microvolt = <2504000>; > + regulator-max-microvolt = <2504000>; > + regulator-initial-mode = ; > + }; > + }; > + > + pm8550c-rpmh-regulators { regulators-1 > + compatible = "qcom,pm8550vs-rpmh-regulators"; > + qcom,pmic-id = "c"; > + > + vdd-l3-supply = <&vreg_s4e_0p9>; > + > + vreg_l3c_0p91: ldo3 { > + regulator-name = "vreg_l3c_0p9"; > + regulator-min-microvolt = <880000>; > + regulator-max-microvolt = <912000>; > + regulator-initial-mode = ; > + }; > + }; > + > + pm8550d-rpmh-regulators { regulators-2 and bindings might need updates. > + compatible = "qcom,pm8550vs-rpmh-regulators"; > + qcom,pmic-id = "d"; > + > + vdd-l1-supply = <&vreg_s4e_0p9>; > + > + vreg_l1d_0p88: ldo1 { > + regulator-name = "vreg_l1d_0p88"; > + regulator-min-microvolt = <880000>; > + regulator-max-microvolt = <920000>; > + regulator-initial-mode = ; > + }; > + }; > + > + pm8550e-rpmh-regulators { ...and so on. (...) > + }; > +}; > + > +&pm8550_gpios { > + sdc2_card_det_n: sdc2-card-det-state { > + card-det-pins { > + pins = "gpio12"; > + function = "normal"; > + input-enable; > + output-disable; > + bias-pull-up; > + power-source = <1>; /* 1.8 V */ > + }; > + }; > +}; > + > +&qupv3_id_0 { > + status = "okay"; > +}; > + > +&sdhc_2 { > + status = "okay"; Status is always last. > + > + cd-gpios = <&pm8550_gpios 12 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_default &sdc2_card_det_n>; > + pinctrl-1 = <&sdc2_sleep &sdc2_card_det_n>; > + vmmc-supply = <&vreg_l9b_2p9>; > + vqmmc-supply = <&vreg_l8b_1p8>; > + bus-width = <4>; > + no-sdio; > + no-emmc; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <32 8>; > + > + sdc2_default: sdc2-default-state { > + clk-pins { > + pins = "sdc2_clk"; > + bias-disable; > + drive-strength = <16>; > + }; > + > + cmd-pins { > + pins = "sdc2_cmd"; > + bias-pull-up; > + drive-strength = <10>; > + }; > + > + data-pins { > + pins = "sdc2_data"; > + bias-pull-up; > + drive-strength = <10>; > + }; > + }; > +}; > + > +&uart7 { > + status = "okay"; > +}; Best regards, Krzysztof