From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
kishon@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
p.zabel@pengutronix.de, quic_nsekar@quicinc.com,
dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v11 4/7] arm64: dts: qcom: ipq9574: Reorder reg and reg-names
Date: Thu, 6 Mar 2025 12:49:20 +0100 [thread overview]
Message-ID: <b3d7374e-b144-4b0a-96f8-0538f9cd1a39@kernel.org> (raw)
In-Reply-To: <20250220094251.230936-5-quic_varada@quicinc.com>
On 20/02/2025 10:42, Varadarajan Narayanan wrote:
> The 'reg' & 'reg-names' constraints used in the bindings and dtsi are
> different resulting in dt_bindings_check errors. Re-order the reg entries,
Why?
> fix the node names and move the nodes to maintain sort order to address the
Fixing (how?) node name looks like separate problem.
> following errors/warnings.
>
> arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb: pcie@20000000: reg-names:0: 'parf' was expected
So this was added back in 2024 and never tested?
> arch/arm64/boot/dts/qcom/ipq9574.dtsi:1045.24-1127.5: Warning (simple_bus_reg): /soc@0/pcie@20000000: simple-bus unit address format error, expected "88000"
>
> Move the nodes to maintain sort order w.r.t address.
>
I don't understand this commit msg and huge diff does not help. It's
very difficult to spot the actual changes and since Qualcomm was never
testing this in the past, I do not believe it is being tested now.
Clearly explain what is the problem - *each of them*.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-06 11:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:42 [PATCH v11 0/7] Add PCIe support for Qualcomm IPQ5332 Varadarajan Narayanan
2025-02-20 9:42 ` [PATCH v11 1/7] dt-bindings: phy: qcom,uniphy-pcie: Document PCIe uniphy Varadarajan Narayanan
2025-02-20 9:42 ` [PATCH v11 2/7] phy: qcom: Introduce PCIe UNIPHY 28LP driver Varadarajan Narayanan
2025-02-20 9:42 ` [PATCH v11 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574 Varadarajan Narayanan
2025-03-06 11:52 ` Krzysztof Kozlowski
2025-03-06 12:06 ` Krzysztof Kozlowski
2025-03-10 7:44 ` Varadarajan Narayanan
2025-03-10 11:37 ` Krzysztof Kozlowski
2025-03-11 5:01 ` Varadarajan Narayanan
2025-03-11 7:54 ` Krzysztof Kozlowski
2025-03-11 8:16 ` Varadarajan Narayanan
2025-03-11 9:52 ` Krzysztof Kozlowski
2025-02-20 9:42 ` [PATCH v11 4/7] arm64: dts: qcom: ipq9574: Reorder reg and reg-names Varadarajan Narayanan
2025-03-06 11:49 ` Krzysztof Kozlowski [this message]
2025-03-06 11:56 ` Krzysztof Kozlowski
2025-03-10 8:04 ` Varadarajan Narayanan
2025-02-20 9:42 ` [PATCH v11 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller Varadarajan Narayanan
2025-02-20 9:42 ` [PATCH v11 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes Varadarajan Narayanan
2025-03-06 12:07 ` Krzysztof Kozlowski
2025-02-20 9:42 ` [PATCH v11 7/7] arm64: dts: qcom: ipq5332-rdp441: Enable PCIe phys and controllers Varadarajan Narayanan
2025-02-20 14:45 ` [PATCH v11 0/7] Add PCIe support for Qualcomm IPQ5332 Krzysztof Wilczyński
2025-03-06 11:56 ` Krzysztof Kozlowski
2025-03-06 12:59 ` Krzysztof Wilczyński
2025-03-07 7:10 ` Krzysztof Kozlowski
2025-03-11 11:46 ` (subset) " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d7374e-b144-4b0a-96f8-0538f9cd1a39@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_nsekar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).