From: Michael Walle <michael@walle.cc>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs
Date: Thu, 24 Feb 2022 09:54:15 +0100 [thread overview]
Message-ID: <b3f0b5ee57b144c2e0487fb104ae92da@walle.cc> (raw)
In-Reply-To: <CAEyMn7aVWK7NBH5+FpcK-gr9LPqb8MwsiOOTVJqo+PZJ+_naSw@mail.gmail.com>
Am 2022-02-24 08:29, schrieb Heiko Thiery:
> Hi,
>
> Am Mi., 23. Feb. 2022 um 22:06 Uhr schrieb Michael Walle
> <michael@walle.cc>:
>>
>> Use the power signal names as given in the schematics of the reference
>> board.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/imx8mn-evk.dts | 20
>> ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> index b4225cfcb6d9..eaa06f49aef5 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dts
>> @@ -41,7 +41,7 @@ pmic: pmic@25 {
>>
>> regulators {
>> buck1: BUCK1{
>> - regulator-name = "BUCK1";
>> + regulator-name = "VDD_ARM_0V9";
>
> I think BUCK1 and BUCK2 are twisted here. This should be "VDD_SOC".
>
>> regulator-min-microvolt = <600000>;
>> regulator-max-microvolt = <2187500>;
>> regulator-boot-on;
>> @@ -50,7 +50,7 @@ buck1: BUCK1{
>> };
>>
>> buck2: BUCK2 {
>> - regulator-name = "BUCK2";
>> + regulator-name = "VDD_SOC";
>
> And this should be "VDD_ARM_0V9".
You are absolutely right. I noticed it on the 8MNANOD3L-EVK but
forgot to update these.
-michael
prev parent reply other threads:[~2022-02-24 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 21:05 [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Michael Walle
2022-02-23 21:05 ` [PATCH v1 2/2] arm64: dts: imx8mn-evk: fix the min/max voltages of the PMIC Michael Walle
2022-02-24 7:29 ` [PATCH v1 1/2] arm64: dts: imx8mn-evk: use proper names for PMIC outputs Heiko Thiery
2022-02-24 8:54 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3f0b5ee57b144c2e0487fb104ae92da@walle.cc \
--to=michael@walle.cc \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).