From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64E18ECAAD8 for ; Tue, 20 Sep 2022 15:12:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbiITPMt (ORCPT ); Tue, 20 Sep 2022 11:12:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230293AbiITPMp (ORCPT ); Tue, 20 Sep 2022 11:12:45 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 610F85A3EF for ; Tue, 20 Sep 2022 08:12:43 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id h3so3422412lja.1 for ; Tue, 20 Sep 2022 08:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=ZDQKf8hMaoTftjO/wZ7T/DZ09g0+Y8QFKUhj1aczZO4=; b=ijboJH4ZrvEVX7eaxNhBtr6nvX/5TUNuJFbmOqb0+QVyWacM7IZnlW5yZJuYuClDvZ v4snu7Fkf2FNjd4tVHOObneeahy8b84caSjAI7JNomzrgj4KlvmmbGBRbBlIQDScGkU5 AtjjSLIFGry4WeNbCg5T1m5FeInNPPQLbsY8D0ysBmH9Ydb+zN0yU898nwA5nNQ5bM2O X0hBLN7WAek0/smDVWaHRNRklQ2eKn+W735Fg2/9g3xRfPsqh5qTykYmLMEos7L6T9jy JJZRR8d/3zZSkmAdDjJ9+umgDxlvr5XgkRJcVC9sj3hxuU9sv2FUfjHXvupE53tlIRbL QRvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=ZDQKf8hMaoTftjO/wZ7T/DZ09g0+Y8QFKUhj1aczZO4=; b=5LAGqZtHyAZc2xYciw3ocROUaTES3a3g8HiLwz/X/lyh0Pnm22jOBUVAKVWNf8bkSC Ghk1Joge3dQfKSWVMYpOswvNSypLdN544aQ7nAgv/fFK81KoNtyMzmfezsLwz9CYmnEK XH94m5Z/tIuTCk78iZ+7V3W59Cr2u+0ecgKZUdegJsKG9Dms7HmOz81dMvS3M9+m8nsw 6OL2VW81aJK0YHKv67Ov9Ou7YjjKkxbPTSeDpJT2Eyh2+zzR/yl8PV1WJR+oYNwfjnWH M3+TLK3YhH3jhVASMQyjEu5XHf4CZMOh/mO2xzWjZZvtO2DEi9lfodyg2lufaor/TBZo HJUA== X-Gm-Message-State: ACrzQf2+/vNLwebf76jT5tnbx5E38NPWwPodCp7goBa4FXdxElWB+AT1 LKaITEMvA19YnoHvUXqCeZFvMw== X-Google-Smtp-Source: AMsMyM7QSPRloERUtnpYtYvGWHR7eEWFhijs5dTYRI013FK2V/Z/om+lBoVDAQl70Nxw3ITy/2Cang== X-Received: by 2002:a05:651c:514:b0:26c:5815:551d with SMTP id o20-20020a05651c051400b0026c5815551dmr1792306ljp.28.1663686761755; Tue, 20 Sep 2022 08:12:41 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id v12-20020a19740c000000b00497a2815d8dsm1781lfe.195.2022.09.20.08.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Sep 2022 08:12:41 -0700 (PDT) Message-ID: Date: Tue, 20 Sep 2022 17:12:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v7 6/9] crypto: qce: core: Add new compatibles for qce crypto driver Content-Language: en-US To: Bhupesh Sharma , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org Cc: agross@kernel.org, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, thara.gopinath@gmail.com, robh@kernel.org, andersson@kernel.org, bhupesh.linux@gmail.com, davem@davemloft.net, Jordan Crouse References: <20220920114051.1116441-1-bhupesh.sharma@linaro.org> <20220920114051.1116441-7-bhupesh.sharma@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220920114051.1116441-7-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/09/2022 13:40, Bhupesh Sharma wrote: > Since we decided to use soc specific compatibles for describing > the qce crypto IP nodes in the device-trees, adapt the driver > now to handle the same. > > Keep the old deprecated compatible strings still in the driver, > to ensure backward compatibility. > > Cc: Bjorn Andersson > Cc: Rob Herring > Cc: herbert@gondor.apana.org.au > Tested-by: Jordan Crouse > Signed-off-by: Bhupesh Sharma > --- > drivers/crypto/qce/core.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 63be06df5519..99ed540611ab 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -291,8 +291,17 @@ static int qce_crypto_remove(struct platform_device *pdev) > } > > static const struct of_device_id qce_crypto_of_match[] = { > + /* Following two entries are deprecated (kept only for backward compatibility) */ > { .compatible = "qcom,crypto-v5.1", }, > { .compatible = "qcom,crypto-v5.4", }, This is okay, so there is no ABI break. > + /* Add compatible strings as per updated dt-bindings, here: */ > + { .compatible = "qcom,ipq4019-qce", }, > + { .compatible = "qcom,ipq6018-qce", }, > + { .compatible = "qcom,ipq8074-qce", }, > + { .compatible = "qcom,msm8996-qce", }, > + { .compatible = "qcom,sdm845-qce", }, > + { .compatible = "qcom,sm8150-qce", }, > + { .compatible = "qcom,sm8250-qce", }, This is a bit odd... you have 7 devices which are simply compatible or even the same. This should be instead one compatible. I don't really get why do you want to deprecate "qcom,crypto-v5.1". Commit msg only says "we decided" but I do not know who is "we" and "why we decided like this". If you want to deprecate it, perfectly fine by me, but please say in commit msg why you are doing it. Best regards, Krzysztof