* [PATCH] arm64: dts: mediatek: mt8186-corsola: Fix GPU supply coupling max-spread
@ 2024-10-21 14:05 Chen-Yu Tsai
2024-10-21 14:15 ` AngeloGioacchino Del Regno
2024-10-22 9:16 ` AngeloGioacchino Del Regno
0 siblings, 2 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2024-10-21 14:05 UTC (permalink / raw)
To: Matthias Brugger, AngeloGioacchino Del Regno
Cc: Chen-Yu Tsai, devicetree, linux-mediatek, linux-arm-kernel,
linux-kernel, stable
The GPU SRAM supply is supposed to be always at least 0.1V higher than
the GPU supply. However when the DT was upstreamed, the spread was
incorrectly set to 0.01V.
Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
Cc: <stable@vger.kernel.org>
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
Noticed this while trying to align the downstream Mali driver to the
upstream device tree and binding.
arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
index cf288fe7a238..db2aca079349 100644
--- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
@@ -1352,7 +1352,7 @@ mt6366_vgpu_reg: vgpu {
regulator-allowed-modes = <MT6397_BUCK_MODE_AUTO
MT6397_BUCK_MODE_FORCE_PWM>;
regulator-coupled-with = <&mt6366_vsram_gpu_reg>;
- regulator-coupled-max-spread = <10000>;
+ regulator-coupled-max-spread = <100000>;
};
mt6366_vproc11_reg: vproc11 {
@@ -1561,7 +1561,7 @@ mt6366_vsram_gpu_reg: vsram-gpu {
regulator-ramp-delay = <6250>;
regulator-enable-ramp-delay = <240>;
regulator-coupled-with = <&mt6366_vgpu_reg>;
- regulator-coupled-max-spread = <10000>;
+ regulator-coupled-max-spread = <100000>;
};
mt6366_vsram_others_reg: vsram-others {
--
2.47.0.rc1.288.g06298d1525-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Fix GPU supply coupling max-spread
2024-10-21 14:05 [PATCH] arm64: dts: mediatek: mt8186-corsola: Fix GPU supply coupling max-spread Chen-Yu Tsai
@ 2024-10-21 14:15 ` AngeloGioacchino Del Regno
2024-10-22 9:16 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-10-21 14:15 UTC (permalink / raw)
To: Chen-Yu Tsai, Matthias Brugger
Cc: devicetree, linux-mediatek, linux-arm-kernel, linux-kernel,
stable
Il 21/10/24 16:05, Chen-Yu Tsai ha scritto:
> The GPU SRAM supply is supposed to be always at least 0.1V higher than
> the GPU supply. However when the DT was upstreamed, the spread was
> incorrectly set to 0.01V.
>
> Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Fix GPU supply coupling max-spread
2024-10-21 14:05 [PATCH] arm64: dts: mediatek: mt8186-corsola: Fix GPU supply coupling max-spread Chen-Yu Tsai
2024-10-21 14:15 ` AngeloGioacchino Del Regno
@ 2024-10-22 9:16 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-10-22 9:16 UTC (permalink / raw)
To: Matthias Brugger, Chen-Yu Tsai
Cc: devicetree, linux-mediatek, linux-arm-kernel, linux-kernel,
stable
On Mon, 21 Oct 2024 22:05:36 +0800, Chen-Yu Tsai wrote:
> The GPU SRAM supply is supposed to be always at least 0.1V higher than
> the GPU supply. However when the DT was upstreamed, the spread was
> incorrectly set to 0.01V.
>
>
Applied to v6.12-next/dts64, thanks!
[1/1] arm64: dts: mediatek: mt8186-corsola: Fix GPU supply coupling max-spread
commit: 2f1aab0cb0661d533f008e4975325080351cdfc8
Cheers,
Angelo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-22 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 14:05 [PATCH] arm64: dts: mediatek: mt8186-corsola: Fix GPU supply coupling max-spread Chen-Yu Tsai
2024-10-21 14:15 ` AngeloGioacchino Del Regno
2024-10-22 9:16 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).