devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emil Gedenryd <Emil.Gedenryd@axis.com>
To: "jic23@kernel.org" <jic23@kernel.org>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dannenberg@ti.com" <dannenberg@ti.com>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"lars@metafoo.de" <lars@metafoo.de>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	Kernel <Kernel@axis.com>
Subject: Re: [PATCH v4 2/2] iio: light: opt3001: add support for TI's opt3002 light sensor
Date: Mon, 7 Oct 2024 07:19:06 +0000	[thread overview]
Message-ID: <b40d22b5bdf487b40207e676d35a0507c47cbb26.camel@axis.com> (raw)
In-Reply-To: <20241006141624.3fa5bf34@jic23-huawei>

On Sun, 2024-10-06 at 14:16 +0100, Jonathan Cameron wrote:
> On Thu, 3 Oct 2024 14:22:17 +0200
> Emil Gedenryd <emil.gedenryd@axis.com> wrote:
> > 
> > +struct opt3001_chip_info {
> > +	const struct iio_chan_spec (*channels)[2];
> > +	enum iio_chan_type chan_type;
> > +	int num_channels;
> > +
> > +	const struct opt3001_scale (*scales)[12];
> This doesn't compile for me as one of the two options only
> has 11 entries.  You could either force them to be 12
> entries each or use a pointer without the size and
> add a num_scales entry in here.
> 
> Jonathan

Hi Jonathan,

Are you building on top of the patch that was accepted in earlier versions of this
patch set? That patch adds the twelfth missing scale value for the opt3001.
See: https://lore.kernel.org/all/20240916-add_opt3002-v3-1-984b190cd68c@axis.com/

Should I have added some tag to highlight the dependency for this version of the
patch set?

Best regards,
Emil 

  reply	other threads:[~2024-10-07  7:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-03 12:22 [PATCH v4 0/2] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-10-03 12:22 ` [PATCH v4 1/2] dt-bindings: iio: light: opt3001: add compatible for opt3002 Emil Gedenryd
2024-10-03 12:22 ` [PATCH v4 2/2] iio: light: opt3001: add support for TI's opt3002 light sensor Emil Gedenryd
2024-10-06 13:16   ` Jonathan Cameron
2024-10-07  7:19     ` Emil Gedenryd [this message]
2024-10-10 17:47       ` Jonathan Cameron
2024-10-11  7:12         ` Emil Gedenryd
2024-10-12 15:10           ` Jonathan Cameron
2024-10-14  6:18             ` Emil Gedenryd
2024-10-21 18:28               ` Jonathan Cameron
2024-10-22  7:16                 ` Emil Gedenryd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b40d22b5bdf487b40207e676d35a0507c47cbb26.camel@axis.com \
    --to=emil.gedenryd@axis.com \
    --cc=Kernel@axis.com \
    --cc=conor+dt@kernel.org \
    --cc=dannenberg@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).