From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D06B5C61DA4 for ; Mon, 13 Mar 2023 06:42:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbjCMGm6 (ORCPT ); Mon, 13 Mar 2023 02:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjCMGm5 (ORCPT ); Mon, 13 Mar 2023 02:42:57 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E4052685 for ; Sun, 12 Mar 2023 23:42:55 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id da10so44425868edb.3 for ; Sun, 12 Mar 2023 23:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678689774; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ct3fbY7RVEKB9YRXgDHYdKGpI1hyfFOcZ+mEvPScFNw=; b=CSHSDudwYP7AsHbyClAvWnm3t5hhLx9PcYp7yd1rS6Y4FNABLARXs8qtx42oUW3czp 7yuootjZD8mNkRSc6zZuExApEMA8t2bJR5yQmpeWC5Pq52xCb7lMvVVr1FXf16K/loj8 3ZeUCapZT6oZCumAmO5/NPdBOcSw4UIINH/iL9BGSB6LjC2DSTnf8LHIhr/ybYLoLP5G xMPE1zysB/et9Uz46sdllTWVyOIOOEHToK+CQjWVBfI7MQmBdelk2158YhqzIdyd0hSZ j5sp5yHTDPE1QHVFQQJ5nitlaPSXaXyQb+UOiuK24r4vtsrg3e7YmR8Z+xXNiK8SX6Zu C0+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678689774; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ct3fbY7RVEKB9YRXgDHYdKGpI1hyfFOcZ+mEvPScFNw=; b=Qqx6HXnOgjVBMi7M9TKUXVkJfPiQDJmDERCnRHd8+0bruZ+Fjl4Acd+hnFCVWPU+0Z v2KOQyC7V+rn1NcPrxV2ubLriqoJGsxkw4Xp3oJLFuTxFEt4oOBwc9A8nKDJ/JUfZzzM WPT3lk1lrzLziX6cXsGbPqmAVbITjqELOZ3fBMWsSIpJG6zb1hlEBjPLj01Md/JAQCqs YZW2t7bPlLJAE1KyiIp8/nVE1C285SNOe/LbLJpnndhVhGI+4mpIPP4gyDo6UXJnxoxW EtM3mbblEJGgltL/2JySjwYAHsoBhckN31qKgm00WRXii72f1Q+d0maxiTLp1KvyLK1Y 9DZQ== X-Gm-Message-State: AO0yUKXmOyupOGeVtU0eLUVGJs9NoGJIVjtsjMF+zfMbNXEISc5NtwpR HWtG6mk6a8wqpz+eRzA4WuKPWQ== X-Google-Smtp-Source: AK7set8BOVZLBV0Vjn5uzvQJAYs2AWPASTtYs1zyPvWJ/7yY4iX5x4DALEaseEbwtC+lNjy6+Gx6PA== X-Received: by 2002:a17:906:5387:b0:8b1:7857:2331 with SMTP id g7-20020a170906538700b008b178572331mr29766278ejo.65.1678689773789; Sun, 12 Mar 2023 23:42:53 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:f052:f15:3f90:fcb3? ([2a02:810d:15c0:828:f052:f15:3f90:fcb3]) by smtp.gmail.com with ESMTPSA id s3-20020a170906bc4300b008c1952b63d8sm3054372ejv.137.2023.03.12.23.42.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Mar 2023 23:42:53 -0700 (PDT) Message-ID: Date: Mon, 13 Mar 2023 07:42:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 1/2] dt-bindings: spi: add loongson spi Content-Language: en-US To: zhuyinbo , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn References: <20230308025908.21491-1-zhuyinbo@loongson.cn> <20230308025908.21491-2-zhuyinbo@loongson.cn> <8d20dcfb-480b-3f1a-02b0-294a05a566f7@linaro.org> <9bfeef4b-f498-12d1-6f21-97289a3127bd@loongson.cn> <29b2a024-8b5a-70ff-17b6-0fb46d871925@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <29b2a024-8b5a-70ff-17b6-0fb46d871925@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/03/2023 03:09, zhuyinbo wrote: > > 在 2023/3/9 下午3:22, zhuyinbo 写道: >> >> 在 2023/3/9 下午2:23, Krzysztof Kozlowski 写道: >>> On 09/03/2023 03:08, zhuyinbo wrote: >>>> 在 2023/3/8 下午7:30, Krzysztof Kozlowski 写道: >>>>> On 08/03/2023 03:59, Yinbo Zhu wrote: >>>>>> Add the Loongson platform spi binding with DT schema format using >>>>>> json-schema. >>>>>> >>>>>> Signed-off-by: Yinbo Zhu >>>>>> --- >>>>>>    .../bindings/spi/loongson,ls-spi.yaml         | 47 >>>>>> +++++++++++++++++++ >>>>>>    MAINTAINERS                                   |  6 +++ >>>>>>    2 files changed, 53 insertions(+) >>>>>>    create mode 100644 >>>>>> Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >>>>> Filename matching the compatible. >>>> loongson,ls-spi.yaml is for ls2k-spi and ls7a-spi, I will add following >>>> desription: >>>> >>>> >>>> properties: >>>>     compatible: >>>>       enum: >>>>         - loongson,ls2k-spi >>>>         - loongson,ls7a-spi >>> OK then. >> >> I was to explain why that yaml was name as "loongson,ls-spi.yaml" >> rather than "loongson,ls2k-spi.yaml" >> >> because that need consider about  yaml filename to match >> "loongson,ls2k-spi" and "loongson,ls7a-spi". >> >>> >>>>>> diff --git >>>>>> a/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >>>>>> b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >>>>>> new file mode 100644 >>>>>> index 000000000000..8a13a96b3818 >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml >>>>>> @@ -0,0 +1,47 @@ >>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>>> + >>>>>> +%YAML 1.2 >>>>>> +--- >>>>>> +$id: "http://devicetree.org/schemas/spi/loongson,ls-spi.yaml#" >>>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >>>>> Drop the quotes. What was the base of your code here? >>>> okay, I will drop the quotes.    and I don't got it  about the code >>>> base >>>> that you said. >>>> >>>> you meaning is advice me add a line  as follows ? >>> I meant, from which other file did you copy it? >> okay,  but I maybe forgot it,  I should be refer other spi yaml file. >>> >>>>>> + >>>>>> +  clock-names: >>>>>> +    const: boot >>>>> Drop clock-names, not needed for single entry. >>>> if drop the clock-names entry, the yaml file will compile fail. >>> Obviously you have to also drop it from DTS and driver... >> >> drop clock-names should be not  affect my driver,  but I notice other >> lots of arm64 platform dts >> >> was keep clock-names and clock in dts when use grep search "clock-names". >> >> [zhuyinbo@localhost www.kernel.org]$ grep -rns "clock-names" arch/arm64/ >> >> arch/arm64/boot/dts/sprd/sc9863a.dtsi:280:            clock-names = >> "apb_pclk"; >> arch/arm64/boot/dts/sprd/sc9863a.dtsi:305:            clock-names = >> "apb_pclk"; >> arch/arm64/boot/dts/sprd/sc9863a.dtsi:330:            clock-names = >> "apb_pclk"; >> arch/arm64/boot/dts/sprd/sc9863a.dtsi:367:            clock-names = >> "apb_pclk"; > > so , if you think it is okay I will keep clock-names and clock in yaml > file like other platform. No, it's not ok. Best regards, Krzysztof