From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32DCFC433FE for ; Thu, 10 Nov 2022 12:55:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229912AbiKJMzB (ORCPT ); Thu, 10 Nov 2022 07:55:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbiKJMzA (ORCPT ); Thu, 10 Nov 2022 07:55:00 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 954CC6F35E for ; Thu, 10 Nov 2022 04:54:58 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id z24so1099125ljn.4 for ; Thu, 10 Nov 2022 04:54:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4rl7jbCW2Iyj8yUM0jRXj0eHKryCRu10YTQuW097Gr8=; b=whwogG/M7Q/aGeiR8QbGlSJ9JxjAtIf9fE8Jb+btzCVlfgjoH66EEA0EQbo+Zwr8dr wvauFcCp1Z29sNzHCzqa508TADHQYP4HPOnHPJ1ka6yJEZPXnxzHuU8g2gz7PXlCEuuY jlWu+VSMvLTnSH3EBYmu/IQTOsCchEYKjHkJanYaUBPmtlgPHNXaSH4VyWnJUjFsUolW Y8Yhfkjo2dc0xFBJNU2ICW+GaHd6r9V9Yf7+YOiI4LUFQlsrHo9WRXubMcYZU0XONo0d RrCnYOqHhMylSvVnxabKVw2Ews7lgk7fXfAvxg+9ueo6FQN3kezOtc5eycpUhmyg3LMs k7rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4rl7jbCW2Iyj8yUM0jRXj0eHKryCRu10YTQuW097Gr8=; b=WVikXIMEsA+nHwMUzeeTRNPZwolsdCWYoHDc2/VJlfJCBpQixO4AuZfWxub0wdAFix zGYhcrQPvAC3Pg48Qry5hD0f2ny3uyu1ClAkZcQJZ6Y61iEzaVXjVpb9EOOFWRkAdAW7 jgqe/ER5OlyLibns89lEdKEoDFdwGb/pE9LmWZAAa76VJYb7b8nnrSJBM2EzY3QZHlmI NusA9fwj49MlQTk0NVbviBS+PLIxJGJcKcOaF7DOOwoPye+gr5gAJuRmQwRlw71sXs8x NW5TEfeQtYjFwUdcO167Tn4UmtsZFbOgkIO3dMSJYQk3176tynTbM6XGzlMXM7yMJQ6K 7WJw== X-Gm-Message-State: ACrzQf1WvubNv7KAS5xmYNE/R05fhVYQChZ6oNLimz+g/oB/oTZysjoN 1OjnqYW5tu4SBuSH0j2k8Gk/GQ== X-Google-Smtp-Source: AMsMyM7PksszzPCzsZ7TQYRjS50hCw4oU0MMSh3auqYjyGoudQLh6bxP/LVj8dD1a7HI8a+95D3bpw== X-Received: by 2002:a2e:9f42:0:b0:277:1295:31ca with SMTP id v2-20020a2e9f42000000b00277129531camr8664043ljk.280.1668084896752; Thu, 10 Nov 2022 04:54:56 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id o11-20020a05651205cb00b00492dfcc0e58sm2742221lfo.53.2022.11.10.04.54.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Nov 2022 04:54:56 -0800 (PST) Message-ID: Date: Thu, 10 Nov 2022 13:54:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/6] arm64: dts: fsd: add sysreg device node Content-Language: en-US To: Sam Protsenko , Vivek Yadav Cc: rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org, wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, pankaj.dubey@samsung.com, ravi.patel@samsung.com, alim.akhtar@samsung.com, linux-fsd@tesla.com, robh+dt@kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, aswani.reddy@samsung.com, sriranjani.p@samsung.com References: <20221109100928.109478-1-vivek.2311@samsung.com> <20221109100928.109478-4-vivek.2311@samsung.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/11/2022 12:17, Sam Protsenko wrote: > Hi Vivek, > > On Wed, 9 Nov 2022 at 11:54, Vivek Yadav wrote: >> >> From: Sriranjani P >> >> Add SYSREG controller device node, which is available in PERIC and FSYS0 >> block of FSD SoC. >> >> Signed-off-by: Alim Akhtar >> Signed-off-by: Pankaj Kumar Dubey >> Cc: devicetree@vger.kernel.org >> Cc: Krzysztof Kozlowski >> Cc: Rob Herring >> Signed-off-by: Sriranjani P >> --- >> arch/arm64/boot/dts/tesla/fsd.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi >> index f35bc5a288c2..3d8ebbfc27f4 100644 >> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi >> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi >> @@ -518,6 +518,16 @@ >> "dout_cmu_fsys1_shared0div4"; >> }; >> >> + sysreg_peric: system-controller@14030000 { >> + compatible = "tesla,sysreg_peric", "syscon"; >> + reg = <0x0 0x14030000 0x0 0x1000>; > > Probably not related to this particular patch, but does the "reg" > really have to have those extra 0x0s? Why it can't be just: > > reg = <0x14030000 0x1000>; > > That comment applies to the whole dts/dtsi. Looks like #address-cells > or #size-cells are bigger than they should be, or I missing something? Yes, it looks like intention was to support some 64-bit addresses (maybe as convention for arm64?) but none of upstreamed are above 32 bit range. I don't have the manual/datasheet to judge whether any other (non-upstreamed) nodes need 64bit addresses. Best regards, Krzysztof