Re: [PATCH v3 3/8] wifi: ath10k: snoc: support powering on the device via pwrseq

Luca Weiss
2026-04-20T11:14:25Z

On Sat Apr 18, 2026 at 9:38 PM CEST, Dmitry Baryshkov wrote:
> On Thu, Apr 16, 2026 at 12:06:09PM +0200, Luca Weiss wrote:
>> Hi Dmitry,
>>
>> On Mon Jan 19, 2026 at 6:07 PM CET, Dmitry Baryshkov wrote:
>> > The WCN39xx family of WiFi/BT chips incorporates a simple PMU, spreading
>> > voltages over internal rails. Implement support for using powersequencer
>> > for this family of ATH10k devices in addition to using regulators.
>> >
>> > Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> > ---
>> > drivers/net/wireless/ath/ath10k/snoc.c | 53 ++++++++++++++++++++++++++++++++--
>> > drivers/net/wireless/ath/ath10k/snoc.h | 3 ++
>> > 2 files changed, 53 insertions(+), 3 deletions(-)
>> >
>> > + ar_snoc->pwrseq = devm_pwrseq_get(&pdev->dev, "wlan");
>> > + if (IS_ERR(ar_snoc->pwrseq)) {
>> > + ret = PTR_ERR(ar_snoc->pwrseq);
>> > + ar_snoc->pwrseq = NULL;
>> > + if (ret != -EPROBE_DEFER)
>> > + goto err_free_irq;
>>
>> I'm fairly sure this is now broken with CONFIG_POWER_SEQUENCING=n since
>> then pwrseq_get() is returning ERR_PTR(-ENOSYS) which is not handled
>> here.
>>
>> I'm observing my ath10k_snoc is now failing to probe "with error -38"
>> which definitely seems to be related, but I haven't debugged it further
>> yet.
>
> Posted https://patch.msgid.link/20260418-ath10k-snoc-pwrseq-v1-1-832594ba3294@oss.qualcomm.com

Thanks Dmitry!