From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marek Vasut <marex@denx.de>, devicetree@vger.kernel.org
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: rtc: m41t80: Convert text schema to YAML one
Date: Thu, 3 Nov 2022 13:13:12 -0400 [thread overview]
Message-ID: <b4639726-eb2a-0ea6-bc0a-c2f95e18a620@linaro.org> (raw)
In-Reply-To: <b34ba792-ba15-14fd-9f1d-7b45c7ae3d39@denx.de>
On 03/11/2022 12:44, Marek Vasut wrote:
> On 11/3/22 14:40, Krzysztof Kozlowski wrote:
>
> [...]
>
>>> diff --git a/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml b/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml
>>> new file mode 100644
>>> index 0000000000000..7f31a22caec9b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml
>>
>> Filename based on compatibles (more or less), so could be:
>> st,m41t80.yaml
>> or:
>> st,m41txx.yaml
>>
>> The "rtc" name can be skipped as it is implied from subsystem folder,
>> unless st,m41txx is a name of some SoC?
>
> [...]
>
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + interrupts:
>>> + maxItems: 1
>>> +
>>> + "#clock-cells":
>>> + const: 1
>>
>> Hm, why do you have it?
>
> Because of the following warning:
>
> $ make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml
> LINT Documentation/devicetree/bindings
> DTEX Documentation/devicetree/bindings/rtc/rtc-m41t80.example.dts
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> Documentation/devicetree/bindings/rtc/rtc-m41t80.yaml: properties:
> '#clock-cells' is a dependency of 'clock-output-names'
So mention any changes from pure conversion in commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-03 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 22:59 [PATCH 1/2] dt-bindings: rtc: m41t80: Convert text schema to YAML one Marek Vasut
2022-11-02 22:59 ` [PATCH 2/2] dt-bindings: rtc: m41t80: Mark the clock: subnode as deprecated Marek Vasut
2022-11-03 13:41 ` Krzysztof Kozlowski
2022-11-03 13:40 ` [PATCH 1/2] dt-bindings: rtc: m41t80: Convert text schema to YAML one Krzysztof Kozlowski
2022-11-03 16:44 ` Marek Vasut
2022-11-03 17:13 ` Krzysztof Kozlowski [this message]
2022-11-03 16:48 ` Marek Vasut
2022-11-03 17:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4639726-eb2a-0ea6-bc0a-c2f95e18a620@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-rtc@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).