From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D2CC83F1A for ; Wed, 30 Aug 2023 18:32:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236576AbjH3Sca (ORCPT ); Wed, 30 Aug 2023 14:32:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245163AbjH3OiQ (ORCPT ); Wed, 30 Aug 2023 10:38:16 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4765B1A2 for ; Wed, 30 Aug 2023 07:38:13 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b9c907bc68so85655551fa.2 for ; Wed, 30 Aug 2023 07:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693406291; x=1694011091; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cMgMrR7+l3U6InFHuLJKmHUuLjLzWvIThsVzLRt3aVA=; b=boeH8U4vR+1Vf5QffwQHIOwj9K1UppXefxIOnmXcfZDJMLWz5h27gJGL0BjAv7NP2v czLtXy8fTv8Ta4MKe8tmFDz3x+nYu8kvD7/JisJ8I0VWODUxat/ebLB+YAl1bvGvY0n6 BhwSU3096kAV8xGe1QVSjzqhf6SadAFA5Cs3wRQiZuGhKUTGElQS8vN5nm1SfZa+pl7E L4ibf79GLQm5KVtsPa1LEor8Lo3FfL04VKYdbPDJ62kf9WQpFDXmXjk3/3u0/d41RFzY a0s4HQzez8GacA5Ao2R6CuljBfjt9QpGhDfR/GKy6MV6NP8YpI6vqUDCjSatrvef4tNl vwig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693406291; x=1694011091; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cMgMrR7+l3U6InFHuLJKmHUuLjLzWvIThsVzLRt3aVA=; b=PfGazazlyUftRrJK8YurifW/aK2NKKKckkS3mbXa/vravhO5oMNnzE0w0m/62TEMba rfFlyD1dQKxD/8ozZ7MWr6YpK+wbgHtWCQYBMqs0D85x30N9iRY7xcPnqaqV9unVO3gX ZRiRdwmej7jddtm7hcF4nd4X5pqajqmVzdGh1A+lrd4Axh1o3ajS3Z6SbL+i5+4HXsuC ozuvKwm8T2uIbZUeOpP5UDxoM33K69QMrm5GJnfWirTFX+/7L1Vp77SRLPMupsKm9H/V /PkKiQP5XB8foe6/bL2Z/nNsb5+XSUdcXq1I0C7ZsS2JEVAB3S/vTYYmzDz3Kvq32xc0 3rew== X-Gm-Message-State: AOJu0YyKQR6m7Nhwc7EdYfOotEkNJjudvukt/ca9Ju7mnwtvzaZsGUa6 jrCSlzPEcnwSssS+Nxy7oIkhHg== X-Google-Smtp-Source: AGHT+IErThUR7PX4P9tgEp26JOMA5iIFhpRzIW70CUb4TYwhSuoCzQURMIk4hJsKeGk6T83B+0C8aA== X-Received: by 2002:a2e:98d0:0:b0:2bd:10b7:4610 with SMTP id s16-20020a2e98d0000000b002bd10b74610mr1823901ljj.25.1693406291406; Wed, 30 Aug 2023 07:38:11 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id sd26-20020a170906ce3a00b00997d76981e0sm7249079ejb.208.2023.08.30.07.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Aug 2023 07:38:10 -0700 (PDT) Message-ID: Date: Wed, 30 Aug 2023 16:38:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/2] dt-binding: Add custom property for MAX7357 Content-Language: en-US To: Naresh Solanki , Peter Rosin , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Laurent Pinchart Cc: Patrick Rudolph , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230830115744.4102929-1-Naresh.Solanki@9elements.com> From: Krzysztof Kozlowski In-Reply-To: <20230830115744.4102929-1-Naresh.Solanki@9elements.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/08/2023 13:57, Naresh Solanki wrote: > From: Patrick Rudolph > > Add a custom property "maxim,bus-lockup-fix" to enable proprietary > features on MAX7357. The driver configures MAX7357 to isolate the > failing channel and trigger a flush-out sequence for bus lock-up > resolution. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. It is "dt-bindings" not binding and several other fields are needed. Also "add custom property" is quite generic. When you add next custom property you are going to have two commits with the same subject. Just make it descriptive - "Add foobar for MAX7357" > > Signed-off-by: Patrick Rudolph > Signed-off-by: Naresh Solanki > --- > .../devicetree/bindings/i2c/i2c-mux-pca954x.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > index 2d7bb998b0e9..984d4614a270 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml > @@ -71,6 +71,11 @@ properties: > description: A voltage regulator supplying power to the chip. On PCA9846 > the regulator supplies power to VDD2 (core logic) and optionally to VDD1. > > + maxim,bus-lockup-fix: > + type: boolean > + description: Isolates only the stuck channel and generates a flush-out sequence > + to attempt to clear the bus lock-up. Why wouldn't you want it to be enabled all the time? Why should it be configurable per-board? Best regards, Krzysztof