From: Rajendra Nayak <rnayak@codeaurora.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: linus.walleij@linaro.org, bjorn.andersson@linaro.org,
linux-arm-msm@vger.kernel.org, agross@kernel.org,
robh+dt@kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jitendra Sharma <shajit@codeaurora.org>,
Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SC7180 pinctrl binding
Date: Fri, 2 Aug 2019 12:23:19 +0530 [thread overview]
Message-ID: <b468e53a-d010-d95f-de9a-62ef60083074@codeaurora.org> (raw)
In-Reply-To: <20190802063317.GB12733@vkoul-mobl.Dlink>
On 8/2/2019 12:03 PM, Vinod Koul wrote:
> On 02-08-19, 09:45, Rajendra Nayak wrote:
>> From: Jitendra Sharma <shajit@codeaurora.org>
>>
>> Add the binding for the TLMM pinctrl block found in the SC7180 platform
>>
>> Signed-off-by: Jitendra Sharma <shajit@codeaurora.org>
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> [rnayak: Fix some copy-paste issues, sort and fix functions]
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>
> changes since v1: ..?
>
>> +- reg-names:
>> + Usage: required
>> + Value type: <prop-encoded-array>
>> + Defintiion: names for the cells of reg, must contain "north", "south"
>
> s/Defintiion/Definition
>
>> +Example:
>> +
>> + tlmm: pinctrl@3000000 {
>
> this should be: pinctrl@3500000
>
> with these two nitpicks fixed:
Thanks Vinod for the review. I will fix these and respin, after I wait
a while to see if there is any more feedback :)
>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2019-08-02 6:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 4:15 [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SC7180 pinctrl binding Rajendra Nayak
2019-08-02 4:15 ` [PATCH v2 2/2] pinctrl: qcom: Add SC7180 pinctrl driver Rajendra Nayak
2019-08-02 6:34 ` Vinod Koul
2019-08-02 6:33 ` [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SC7180 pinctrl binding Vinod Koul
2019-08-02 6:53 ` Rajendra Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b468e53a-d010-d95f-de9a-62ef60083074@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shajit@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox