From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajendra Nayak Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: Add SC7180 pinctrl binding Date: Fri, 2 Aug 2019 12:23:19 +0530 Message-ID: References: <20190802041507.12365-1-rnayak@codeaurora.org> <20190802063317.GB12733@vkoul-mobl.Dlink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190802063317.GB12733@vkoul-mobl.Dlink> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Vinod Koul Cc: linus.walleij@linaro.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, agross@kernel.org, robh+dt@kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jitendra Sharma , Vivek Gautam List-Id: devicetree@vger.kernel.org On 8/2/2019 12:03 PM, Vinod Koul wrote: > On 02-08-19, 09:45, Rajendra Nayak wrote: >> From: Jitendra Sharma >> >> Add the binding for the TLMM pinctrl block found in the SC7180 platform >> >> Signed-off-by: Jitendra Sharma >> Signed-off-by: Vivek Gautam >> [rnayak: Fix some copy-paste issues, sort and fix functions] >> Signed-off-by: Rajendra Nayak >> Reviewed-by: Bjorn Andersson >> --- > > changes since v1: ..? > >> +- reg-names: >> + Usage: required >> + Value type: >> + Defintiion: names for the cells of reg, must contain "north", "south" > > s/Defintiion/Definition > >> +Example: >> + >> + tlmm: pinctrl@3000000 { > > this should be: pinctrl@3500000 > > with these two nitpicks fixed: Thanks Vinod for the review. I will fix these and respin, after I wait a while to see if there is any more feedback :) > > Reviewed-by: Vinod Koul > -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation