devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Deng <wei.deng@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	cheng.jiang@oss.qualcomm.com, quic_jiaymao@quicinc.com,
	quic_chezhou@quicinc.com, quic_shuaz@quicinc.com
Subject: Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
Date: Tue, 18 Nov 2025 21:18:35 +0800	[thread overview]
Message-ID: <b47e6b6e-6cec-4470-9bfc-93008bd44a5f@oss.qualcomm.com> (raw)
In-Reply-To: <26841765-171b-475f-8019-2c349958af7d@kernel.org>

Hi Krzysztof,
Thanks for your comments.

On 11/13/2025 9:38 PM, Krzysztof Kozlowski wrote:
> On 13/11/2025 14:37, Krzysztof Kozlowski wrote:
>> On 13/11/2025 14:09, Wei Deng wrote:
>>> Enable BT on qcs8300-ride by adding a device tree node for BT.
>>>
>>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>>> ---
>>> This patch depends on:
>>> - WLAN
>>> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
>>
>> And that patch depends on something else.
>>
>> You make it very difficult to review and even more difficult to merge.
>>
>>> ---
>>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>>>  1 file changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> index cd8800a59700..08b705fe4eea 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> @@ -18,6 +18,7 @@ / {
>>>  	aliases {
>>>  		serial0 = &uart7;
>>>  		mmc0 = &sdhc_1;
>>
>> There is no such alias?
> 
> Ah there is, found now added by Sayali Lokhande <quic_sayalil@quicinc.com>.
> 
> Anyway, organize your work in reasonable patchsets not 3 or more
> one-patchers spread all over the mailing list.
> 

OK, will re-organize my work in reasonable patchsets. Will send new patch.

> Best regards,
> Krzysztof

-- 
Best Regards,
Wei Deng


  reply	other threads:[~2025-11-18 13:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 13:09 [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support Wei Deng
2025-11-13 13:37 ` Krzysztof Kozlowski
2025-11-13 13:38   ` Krzysztof Kozlowski
2025-11-18 13:18     ` Wei Deng [this message]
2025-11-13 20:14 ` Dmitry Baryshkov
2025-11-14  9:40   ` Wei Deng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b47e6b6e-6cec-4470-9bfc-93008bd44a5f@oss.qualcomm.com \
    --to=wei.deng@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=cheng.jiang@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_chezhou@quicinc.com \
    --cc=quic_jiaymao@quicinc.com \
    --cc=quic_shuaz@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).