From: Marcelo Schmitt <marcelo.schmitt@analog.com>
To: <paul.cercueil@analog.com>, <Michael.Hennerich@analog.com>,
<lars@metafoo.de>, <jic23@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<marcelo.schmitt1@gmail.com>
Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 1/7] iio: adc: ad7091r-base: Set alert config and drvdata
Date: Thu, 23 Nov 2023 13:40:16 -0300 [thread overview]
Message-ID: <b485b1ccafad79f9ac3bb1a6b5e6d68b24ad4ad5.1700751907.git.marcelo.schmitt1@gmail.com> (raw)
In-Reply-To: <cover.1700751907.git.marcelo.schmitt1@gmail.com>
Write 1 to bit 4 in the configuration register to set ALERT/BUSY/GPO pin
to be used as ALERT.
Set device driver data so it can be retrieved when handling alert
events, avoiding null pointer dereference.
Fixes: <ca69300173b6> (iio: adc: Add support for AD7091R5 ADC)
Signed-off-by: Marcelo Schmitt <marcelo.schmitt@analog.com>
---
drivers/iio/adc/ad7091r-base.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ad7091r-base.c b/drivers/iio/adc/ad7091r-base.c
index 8e252cde735b..3ecac3164446 100644
--- a/drivers/iio/adc/ad7091r-base.c
+++ b/drivers/iio/adc/ad7091r-base.c
@@ -28,6 +28,7 @@
#define AD7091R_REG_RESULT_CONV_RESULT(x) ((x) & 0xfff)
/* AD7091R_REG_CONF */
+#define AD7091R_REG_CONF_ALERT_EN BIT(4)
#define AD7091R_REG_CONF_AUTO BIT(8)
#define AD7091R_REG_CONF_CMD BIT(10)
@@ -232,9 +233,16 @@ int ad7091r_probe(struct device *dev, const char *name,
iio_dev->channels = chip_info->channels;
if (irq) {
+ ret = regmap_update_bits(st->map, AD7091R_REG_CONF,
+ AD7091R_REG_CONF_ALERT_EN, BIT(4));
+ if (ret)
+ return ret;
+
+ dev_set_drvdata(st->dev, iio_dev);
ret = devm_request_threaded_irq(dev, irq, NULL,
- ad7091r_event_handler,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT, name, st);
+ ad7091r_event_handler,
+ IRQF_TRIGGER_FALLING |
+ IRQF_ONESHOT, name, st);
if (ret)
return ret;
}
--
2.42.0
next prev parent reply other threads:[~2023-11-23 16:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 16:29 [PATCH v2 0/7] Add support for AD7091R-2/-4/-8 Marcelo Schmitt
2023-11-23 16:40 ` Marcelo Schmitt [this message]
2023-11-25 16:13 ` [PATCH v2 1/7] iio: adc: ad7091r-base: Set alert config and drvdata Jonathan Cameron
2023-11-23 16:40 ` [PATCH v2 2/7] MAINTAINERS: Add MAINTAINERS entry for AD7091R Marcelo Schmitt
2023-11-25 16:15 ` Jonathan Cameron
2023-11-23 16:41 ` [PATCH v2 3/7] iio: adc: ad7091r: Move defines to header file Marcelo Schmitt
2023-11-25 16:18 ` Jonathan Cameron
2023-11-23 16:41 ` [PATCH v2 4/7] iio: adc: ad7091r: Alloc IIO device before generic probe Marcelo Schmitt
2023-11-25 16:21 ` Jonathan Cameron
2023-11-23 16:42 ` [PATCH v2 5/7] dt-bindings: iio: Add binding documentation for AD7091R-8 Marcelo Schmitt
2023-11-25 12:21 ` Conor Dooley
2023-11-27 20:53 ` Rob Herring
2023-11-23 16:42 ` [PATCH v2 6/7] iio: adc: Add support " Marcelo Schmitt
2023-11-25 16:41 ` Jonathan Cameron
2023-11-23 16:43 ` [PATCH v2 7/7] iio: adc: ad7091r-base: Add debugfs reg access Marcelo Schmitt
2023-11-25 16:44 ` Jonathan Cameron
2023-11-25 16:08 ` [PATCH v2 0/7] Add support for AD7091R-2/-4/-8 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b485b1ccafad79f9ac3bb1a6b5e6d68b24ad4ad5.1700751907.git.marcelo.schmitt1@gmail.com \
--to=marcelo.schmitt@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=paul.cercueil@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).