From: Andrew Lunn <andrew@lunn.ch>
To: "Uwe Kleine-König" <ukleinek@debian.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add basic support for QNAP TS-433
Date: Tue, 27 Feb 2024 22:00:48 +0100 [thread overview]
Message-ID: <b48cde05-c583-4414-9424-fbb2db3a53ce@lunn.ch> (raw)
In-Reply-To: <0d9fa5d730ac1cb91261b25b6809fcef3a12f03a.1709034476.git.ukleinek@debian.org>
> +&gmac0 {
> + assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
> + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>;
> + assigned-clock-rates = <0>, <125000000>;
> + clock_in_out = "output";
> + phy-handle = <&rgmii_phy0>;
> + phy-mode = "rgmii";
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac0_miim
> + &gmac0_tx_bus2
> + &gmac0_rx_bus2
> + &gmac0_rgmii_clk
> + &gmac0_rgmii_bus>;
> + rx_delay = <0x2f>;
> + tx_delay = <0x3c>;
Have you tried phy-mode = "rgmii-id"; and not have these two _delay
settings?
In general, we try to have the PHY do the delay, not the MAC, so that
all devices work the same.
Andrew
next prev parent reply other threads:[~2024-02-27 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 11:52 [PATCH 0/2] arm64: Add basic support for QNAP TS-433 Uwe Kleine-König
2024-02-27 11:52 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add " Uwe Kleine-König
2024-02-28 7:43 ` Krzysztof Kozlowski
2024-02-27 11:52 ` [PATCH 2/2] arm64: dts: rockchip: Add basic support for " Uwe Kleine-König
2024-02-27 21:00 ` Andrew Lunn [this message]
2024-02-28 7:23 ` Uwe Kleine-König
2024-02-28 13:53 ` Andrew Lunn
2024-02-28 17:05 ` Uwe Kleine-König
2024-02-27 12:26 ` [PATCH 0/2] arm64: " Heiko Stübner
2024-02-27 13:53 ` Uwe Kleine-König
2024-02-27 13:45 ` Rob Herring
2024-02-27 13:55 ` Uwe Kleine-König
2024-02-27 17:41 ` Heiko Stübner
2024-02-28 13:02 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b48cde05-c583-4414-9424-fbb2db3a53ce@lunn.ch \
--to=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=ukleinek@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).