From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54C6314E2CD for ; Tue, 27 Feb 2024 21:00:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067639; cv=none; b=aFmmS6enIT6X0AO0N9eK1VXIsdrMlBtiBvFlubID/sIIbQsQKxiJqDsCu0wL49xTRRA1h6x0CcdeK29+lJC2xiuhq9mRhHfLLF55CqB4U5oVy1E7Of7lKSgkgJJm5jgn6P3d9ZDJzRqx6X4g9ZJL87mF2rhmBNBTImhly8JD2+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067639; c=relaxed/simple; bh=YcZKUGavYY15zjszTnCWYT3wX4veqUwiweM8akSVWvI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WpAtArR2UlIqxrOpgUTZOIpCVmjZxrV0vSSDj0R5B4Jbov8vhzMWwAV5qVEnl+VyphG6QfMsAInErn/aRCPr9MrykVoLSPmCyhX9PpVAGAh8oiJUYzbBNdZB8mPA5FHd77YSwcLn50LyzcRlHdCRCE8Qb/pLBt5/DRWdeiKUiME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=B2NMJlbv; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="B2NMJlbv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Rk9Vo0mBfgVKHqc4fUhHA256f+oW4rOARrZgd+9glVE=; b=B2NMJlbvJ6T41+c4sj3UExauga 5MQf7AvV1VrT99Hii+DiDMtxwseRhjT5BjxfMH/knu4QYblQlN7hJMep9Apz4Nt6lQBHp7pL2bRHr ajp3Ep7YdsbmPOaL5ZNr3UCxEai31hBYSQH/oGCq3gV6D5XvpgBXZeZC7QQHMmAKp9ew=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rf4ZE-008t9w-TL; Tue, 27 Feb 2024 22:00:48 +0100 Date: Tue, 27 Feb 2024 22:00:48 +0100 From: Andrew Lunn To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add basic support for QNAP TS-433 Message-ID: References: <0d9fa5d730ac1cb91261b25b6809fcef3a12f03a.1709034476.git.ukleinek@debian.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d9fa5d730ac1cb91261b25b6809fcef3a12f03a.1709034476.git.ukleinek@debian.org> > +&gmac0 { > + assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>; > + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>; > + assigned-clock-rates = <0>, <125000000>; > + clock_in_out = "output"; > + phy-handle = <&rgmii_phy0>; > + phy-mode = "rgmii"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gmac0_miim > + &gmac0_tx_bus2 > + &gmac0_rx_bus2 > + &gmac0_rgmii_clk > + &gmac0_rgmii_bus>; > + rx_delay = <0x2f>; > + tx_delay = <0x3c>; Have you tried phy-mode = "rgmii-id"; and not have these two _delay settings? In general, we try to have the PHY do the delay, not the MAC, so that all devices work the same. Andrew