devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michal Simek <michal.simek@amd.com>, Rob Herring <robh@kernel.org>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
	linux-clk@vger.kernel.org, git@amd.com,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	sboyd@kernel.org, mturquette@baylibre.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 1/2] dt-bindings: clk: Add binding for versal clocking wizard
Date: Mon, 3 Oct 2022 09:23:21 +0200	[thread overview]
Message-ID: <b495804c-cf04-4512-ac05-424eded46468@linaro.org> (raw)
In-Reply-To: <6e58837e-896c-7069-7913-2afb90af5e95@amd.com>

On 03/10/2022 09:15, Michal Simek wrote:
>>> And this is new IP. Not sure who has chosen similar name but this targets
>>> Xilinx Versal SOCs. Origin one was targeting previous families.
>>
>> Do we need a whole new schema doc?
> 
> It is completely new IP with different logic compare to origin one.
> 
>>
>> It is not ideal to define the same property, xlnx,nr-outputs, more than
>> once. And it's only a new compatible string.
> 
> I can't see any issue with using dt binding for xlnx,clocking-wizard.yaml
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml

So we already have out of staging document:
devicetree/bindings/clock/xlnx,clocking-wizard.yaml

and author wants to add one more:
devicetree/bindings/clock/xlnx,clk-wizard.yaml

Shall we expect in two years, a third document like:
devicetree/bindings/clock/xlnx,clk-wzrd.yaml
?

> 
> also for this IP if that's fine with you.
> Only xlnx,speed-grade can be defined for previous IP which is easy to mark.

That old binding also explained nr-outputs as "Number of outputs".
Perfect... :(

Best regards,
Krzysztof


  reply	other threads:[~2022-10-03  8:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30  8:03 [PATCH 0/2] clocking-wizard: Add versal clocking wizard support Shubhrajyoti Datta
2022-09-30  8:03 ` [PATCH 1/2] dt-bindings: clk: Add binding for versal clocking wizard Shubhrajyoti Datta
2022-09-30 11:19   ` Krzysztof Kozlowski
2022-09-30 12:25   ` Rob Herring
2022-09-30 13:00     ` Michal Simek
2022-09-30 21:39       ` Rob Herring
2022-10-03  7:15         ` Michal Simek
2022-10-03  7:23           ` Krzysztof Kozlowski [this message]
2022-10-03  7:58             ` Michal Simek
2022-10-03  8:10               ` Krzysztof Kozlowski
2022-10-03  8:16                 ` Greg Kroah-Hartman
2022-10-03  9:59                   ` Michal Simek
2022-10-03 10:41                     ` Michal Simek
2022-10-03 14:50                       ` Greg Kroah-Hartman
2022-10-03 10:37                 ` Michal Simek
2022-10-03 10:50                   ` Krzysztof Kozlowski
2022-10-03 15:27                     ` Michal Simek
2022-10-04 11:00                       ` Krzysztof Kozlowski
2022-10-04 11:04                         ` Michal Simek
2022-09-30  8:04 ` [PATCH 2/2] clocking-wizard: Add versal clocking wizard support Shubhrajyoti Datta
2022-09-30 14:39   ` kernel test robot
2022-10-02  2:11   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b495804c-cf04-4512-ac05-424eded46468@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shubhrajyoti.datta@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).