From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 184E1C433F5 for ; Mon, 3 Oct 2022 08:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231530AbiJCIgP (ORCPT ); Mon, 3 Oct 2022 04:36:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231557AbiJCIfq (ORCPT ); Mon, 3 Oct 2022 04:35:46 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41F5520BC4 for ; Mon, 3 Oct 2022 01:08:26 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id a10so10933819ljq.0 for ; Mon, 03 Oct 2022 01:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=OWR0WOYIaygxKBvBdUgm8aSkracuNoxTbBMzqtzlAGM=; b=SgggRDKZ9637LDD9qoLTBMhZMGXPdWXed2DPJceiSK9Tc7Vq8nN2AZ2+pur7kK1vOr 5QFpa7N1crON1mLhqfo3rguSdfAw+YtMbIrt9+xLNCU3I3Ts0JQtIFelpWyfhF2hjRiI 2Z5pjmq5qQspmbGp1Al5jj4i1JpJeXxIIqBs1AQxiWVMR9DmWr9p5tXDFfNr05F9HAwK twd5N4ljZuoKr56ETEDFQIjdX2Xj75wOg2RWCgCGPoZQAlqK8aBGe5pAChJ6f8iA9roC OpIMYNUEKkZ4ZlUdyvZW0AxOqjnHWAM74+4X2Iza6NCUJnPik9SQ//yEIrtO8YmFNgqb wt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=OWR0WOYIaygxKBvBdUgm8aSkracuNoxTbBMzqtzlAGM=; b=CZ93x9lEDCHWx59SYKdkZMk5Foocup0S0M9HNTw5sMwze6Bk4tJH5KTIZfNzH52bwj BjAQe7GCkCYKCFM1ghwxwZeM//Lju8HLmwEL36FwvKnUdNckiE1pybRYRxV/5Bz/YZiR 329xOETQAZ2gt8ZnHWv0GFDrPcP6HxPamXURZMgezOomsnk15eTjfIF2qRjxDA84bnbR 0PTJyU2Zcgtd64Yj1ug6Id3ld5+CnKBh3UgmZHY+SAZA7/hYQ88Q5wm9LhrSyqj6MLLd c7y365ShKd9gOzSbXyCumA/jE2/z8N8lxmHGEj+L2RcqHg5qS4l0E8C4wy/mi21Q2GwF AXjg== X-Gm-Message-State: ACrzQf1QCaG4VS8MAS6/YdCN0FryvO3agBpc7bOqr7pZYBaiNVAjo0CI WPo+Nfh0c+v6Yj/HlW3QVcZDtmX3tlc4uQ== X-Google-Smtp-Source: AMsMyM48/WNE88THbqjlggjZtr95vdx5GT4rzEmO+1YcVjo0LbjTYzb5mlh5xE+DQbWZ6ZhqrlXliQ== X-Received: by 2002:a05:6512:2342:b0:4a2:e4a:5fb7 with SMTP id p2-20020a056512234200b004a20e4a5fb7mr6340939lfu.272.1664781802167; Mon, 03 Oct 2022 00:23:22 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id o12-20020a056512230c00b004946748ad4dsm1344042lfu.159.2022.10.03.00.23.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 00:23:21 -0700 (PDT) Message-ID: Date: Mon, 3 Oct 2022 09:23:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 1/2] dt-bindings: clk: Add binding for versal clocking wizard Content-Language: en-US To: Michal Simek , Rob Herring Cc: Shubhrajyoti Datta , linux-clk@vger.kernel.org, git@amd.com, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, sboyd@kernel.org, mturquette@baylibre.com, Greg Kroah-Hartman References: <20220930080400.15619-1-shubhrajyoti.datta@amd.com> <20220930080400.15619-2-shubhrajyoti.datta@amd.com> <20220930213924.GA1079711-robh@kernel.org> <6e58837e-896c-7069-7913-2afb90af5e95@amd.com> From: Krzysztof Kozlowski In-Reply-To: <6e58837e-896c-7069-7913-2afb90af5e95@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/10/2022 09:15, Michal Simek wrote: >>> And this is new IP. Not sure who has chosen similar name but this targets >>> Xilinx Versal SOCs. Origin one was targeting previous families. >> >> Do we need a whole new schema doc? > > It is completely new IP with different logic compare to origin one. > >> >> It is not ideal to define the same property, xlnx,nr-outputs, more than >> once. And it's only a new compatible string. > > I can't see any issue with using dt binding for xlnx,clocking-wizard.yaml > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml So we already have out of staging document: devicetree/bindings/clock/xlnx,clocking-wizard.yaml and author wants to add one more: devicetree/bindings/clock/xlnx,clk-wizard.yaml Shall we expect in two years, a third document like: devicetree/bindings/clock/xlnx,clk-wzrd.yaml ? > > also for this IP if that's fine with you. > Only xlnx,speed-grade can be defined for previous IP which is easy to mark. That old binding also explained nr-outputs as "Number of outputs". Perfect... :( Best regards, Krzysztof