[PATCH v2 1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock

[PATCH v2 1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock

[AngeloGioacchino Del Regno]

Add binding for the HDMI TX clock found in the VDO1 controller.
While at it, also remove the unused CLK_VDO1_NR_CLK.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
index bd5cd100b796..0e87f61c90f4 100644
--- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
+++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
@@ -721,6 +721,6 @@
 #define CLK_VDO1_DPINTF				58
 #define CLK_VDO1_DISP_MONITOR_DPINTF		59
 #define CLK_VDO1_26M_SLOW			60
-#define CLK_VDO1_NR_CLK				61
+#define CLK_VDO1_DPI1_HDMI			61
 
 #endif /* _DT_BINDINGS_CLK_MT8188_H */
-- 
2.48.1

[PATCH v2 2/2] clk: mediatek: mt8188-vdo1: Add VDO1_DPI1_HDMI clock for hdmitx

[AngeloGioacchino Del Regno]

Add a missing clock found in the VDO1 controller for the HDMI TX
controller over DPI1.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 drivers/clk/mediatek/clk-mt8188-vdo1.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/clk/mediatek/clk-mt8188-vdo1.c b/drivers/clk/mediatek/clk-mt8188-vdo1.c
index 4fa355f8f0c2..f715d45e545e 100644
--- a/drivers/clk/mediatek/clk-mt8188-vdo1.c
+++ b/drivers/clk/mediatek/clk-mt8188-vdo1.c
@@ -43,6 +43,12 @@ static const struct mtk_gate_regs vdo1_4_cg_regs = {
 	.sta_ofs = 0x140,
 };
 
+static const struct mtk_gate_regs vdo1_5_cg_regs = {
+	.set_ofs = 0x400,
+	.clr_ofs = 0x400,
+	.sta_ofs = 0x400,
+};
+
 #define GATE_VDO1_0(_id, _name, _parent, _shift)			\
 	GATE_MTK(_id, _name, _parent, &vdo1_0_cg_regs, _shift, &mtk_clk_gate_ops_setclr)
 
@@ -62,6 +68,9 @@ static const struct mtk_gate_regs vdo1_4_cg_regs = {
 #define GATE_VDO1_4(_id, _name, _parent, _shift)			\
 	GATE_MTK(_id, _name, _parent, &vdo1_4_cg_regs, _shift, &mtk_clk_gate_ops_setclr)
 
+#define GATE_VDO1_5(_id, _name, _parent, _shift)			\
+	GATE_MTK(_id, _name, _parent, &vdo1_5_cg_regs, _shift, &mtk_clk_gate_ops_setclr)
+
 static const struct mtk_gate vdo1_clks[] = {
 	/* VDO1_0 */
 	GATE_VDO1_0(CLK_VDO1_SMI_LARB2, "vdo1_smi_larb2", "top_vpp", 0),
@@ -129,6 +138,8 @@ static const struct mtk_gate vdo1_clks[] = {
 	GATE_VDO1_3(CLK_VDO1_DISP_MONITOR_DPINTF, "vdo1_disp_monitor_dpintf_ck", "top_vpp", 17),
 	/* VDO1_4 */
 	GATE_VDO1_4(CLK_VDO1_26M_SLOW, "vdo1_26m_slow_ck", "clk26m", 8),
+	/* VDO1_5 */
+	GATE_VDO1_5(CLK_VDO1_DPI1_HDMI, "vdo1_dpi1_hdmi", "hdmi_txpll", 0),
 };
 
 static const struct mtk_clk_desc vdo1_desc = {
-- 
2.48.1

Re: [PATCH v2 1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

On Wed, Feb 12, 2025 at 11:03:41AM +0100, AngeloGioacchino Del Regno wrote:
> Add binding for the HDMI TX clock found in the VDO1 controller.
> While at it, also remove the unused CLK_VDO1_NR_CLK.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> index bd5cd100b796..0e87f61c90f4 100644
> --- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
> +++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> @@ -721,6 +721,6 @@
>  #define CLK_VDO1_DPINTF				58
>  #define CLK_VDO1_DISP_MONITOR_DPINTF		59
>  #define CLK_VDO1_26M_SLOW			60
> -#define CLK_VDO1_NR_CLK				61
> +#define CLK_VDO1_DPI1_HDMI			61

Acked-by: Conor Dooley <conor.dooley@microchip.com>

btw, I see the mt8195 has this same CLK_VDO1_NR_CLK define in it, if you
fancy getting rid of that too.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock

[AngeloGioacchino Del Regno]

Il 12/02/25 20:17, Conor Dooley ha scritto:
> On Wed, Feb 12, 2025 at 11:03:41AM +0100, AngeloGioacchino Del Regno wrote:
>> Add binding for the HDMI TX clock found in the VDO1 controller.
>> While at it, also remove the unused CLK_VDO1_NR_CLK.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
>> index bd5cd100b796..0e87f61c90f4 100644
>> --- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
>> +++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
>> @@ -721,6 +721,6 @@
>>   #define CLK_VDO1_DPINTF				58
>>   #define CLK_VDO1_DISP_MONITOR_DPINTF		59
>>   #define CLK_VDO1_26M_SLOW			60
>> -#define CLK_VDO1_NR_CLK				61
>> +#define CLK_VDO1_DPI1_HDMI			61
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> btw, I see the mt8195 has this same CLK_VDO1_NR_CLK define in it, if you
> fancy getting rid of that too.

Thanks Conor, yeah I'll do that asap... one commit for each NR_CLK is a bit
too much... I should just clean them all up :-)

That requires a bit of work though, so it's not something that I can do in
a few minutes; let's see if I can make it for this cycle, but no promises.

Cheers,
Angelo

Re: [PATCH v2 1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

On Tue, Feb 18, 2025 at 02:22:25PM +0100, AngeloGioacchino Del Regno wrote:
> Il 12/02/25 20:17, Conor Dooley ha scritto:
> > On Wed, Feb 12, 2025 at 11:03:41AM +0100, AngeloGioacchino Del Regno wrote:
> > > Add binding for the HDMI TX clock found in the VDO1 controller.
> > > While at it, also remove the unused CLK_VDO1_NR_CLK.
> > > 
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > ---
> > >   include/dt-bindings/clock/mediatek,mt8188-clk.h | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/include/dt-bindings/clock/mediatek,mt8188-clk.h b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > index bd5cd100b796..0e87f61c90f4 100644
> > > --- a/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > +++ b/include/dt-bindings/clock/mediatek,mt8188-clk.h
> > > @@ -721,6 +721,6 @@
> > >   #define CLK_VDO1_DPINTF				58
> > >   #define CLK_VDO1_DISP_MONITOR_DPINTF		59
> > >   #define CLK_VDO1_26M_SLOW			60
> > > -#define CLK_VDO1_NR_CLK				61
> > > +#define CLK_VDO1_DPI1_HDMI			61
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > btw, I see the mt8195 has this same CLK_VDO1_NR_CLK define in it, if you
> > fancy getting rid of that too.
> 
> Thanks Conor, yeah I'll do that asap... one commit for each NR_CLK is a bit
> too much... I should just clean them all up :-)
> 
> That requires a bit of work though, so it's not something that I can do in
> a few minutes; let's see if I can make it for this cycle, but no promises.

Yah, no worries. Was just pointing it out, don't need to let this
particular patch wait around for it by any means.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/2] dt-bindings: clock: mediatek,mt8188: Add VDO1_DPI1_HDMI clock

[Stephen Boyd]

Quoting AngeloGioacchino Del Regno (2025-02-12 02:03:41)
> Add binding for the HDMI TX clock found in the VDO1 controller.
> While at it, also remove the unused CLK_VDO1_NR_CLK.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---

Applied to clk-next

Re: [PATCH v2 2/2] clk: mediatek: mt8188-vdo1: Add VDO1_DPI1_HDMI clock for hdmitx

[Stephen Boyd]

Quoting AngeloGioacchino Del Regno (2025-02-12 02:03:42)
> Add a missing clock found in the VDO1 controller for the HDMI TX
> controller over DPI1.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---

Applied to clk-next