From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 902577404E for ; Wed, 29 Apr 2026 10:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777459428; cv=none; b=WCwqsd5cO6N89Y3r3H6bivXgzB6w4xrACxSxd61r8/652dKBJmENT0rsuFyX/jlkmylKChzP43ntpE08K5yzcqHvMiZP12d3yBBgxgJX84qvixu1trKglaEEg4idZW3PdshEGxDQXFwC3R0kPHCA7QP9FA3O4lZvWOSuHJNJUNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777459428; c=relaxed/simple; bh=kLpe4nBO1EEqY+eeCo5RdibwdXifGeVFAhSBKQCLbf0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y4DyiKAYImNNSllNpiBDHD/4dwtb2t2ndrMFsVE+YU3X9RbFsiSIzb+1mByuF/NcxPicKrXMvokzRzrpPqryCJLkUxsab9oRXjfrboXx8X+uAxHgOmuX3lBrAVGAgDB20cfE6LbrZkEhNuhwc/4i1I0MmApKpl6gLL0MhvXfdQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fMotN0Wg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dWzhxj9o; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fMotN0Wg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dWzhxj9o" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63T8q7EW1721232 for ; Wed, 29 Apr 2026 10:43:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +Hcg/mdJagPhL4gZ2X13igeHogG5VDvHtgIlHe5+ZTQ=; b=fMotN0WgA1RcsQm7 lkxeX855evsD8KGrHctFsk24hDbnjTL7+8TCAYAk5ASl6vAV67ztQ+tGxYackF/y QVg+8fTQ4W9CpyCDiKqVNHz/mgrJaKIQI94aunWO+rv13u/Loa8LmimjK3nXubhb P57gNTY17OsbGjGMh3PCd7JWLeNoWxKvIfUxRGwydB+/KOPppoL/9KFCM16bMxpH A+s7JxwohnJM0y74oCf+9p1zqbeZzObyhc+4l6/L8OwU44ZXxioQos+khUhL88k5 nn8ezyR+j23nX7ijCpk6iSj9Wv99sZ9A5A8EInP8p544JLU1MNMNbhRdUQdAr2PT Kbp7Gw== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dua731nmv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Apr 2026 10:43:46 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-5ff9e60dd65so645128137.3 for ; Wed, 29 Apr 2026 03:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777459426; x=1778064226; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+Hcg/mdJagPhL4gZ2X13igeHogG5VDvHtgIlHe5+ZTQ=; b=dWzhxj9of/sKKsaozjkztG5Z5ua217fYTvfEarcZv89PRIY9uPILqxdaXQzvnxSAji Jvdy3jb3rVD7gVgPLL6sUVk4CLUfLpTdQcrYARqqB0u6QP9m78GFMtgjO4E6KvBsWaPo eHJBN9ux5PsJ2afy1uJFufhv9CBDlNNTXWDQXeN5+XyjTdIFHv+XP22PagcJJ9mc//X+ aPYIXglSQnm+cLI5kN+k0frsLdQdbHpiu2psFN86JAVNjFTk0MnG3B7F1lkS7HrZuwd8 h3wlS1hmWYZPGoUK71f9IbrMpx+u+jmyPeLrxLMETpB46kObNQcT5tfX+NPKWORhK6CY 3CwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777459426; x=1778064226; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+Hcg/mdJagPhL4gZ2X13igeHogG5VDvHtgIlHe5+ZTQ=; b=SyUzhrnD2S7NDV/Au5Pqd6LzfQUpJVfu78EjTtloWeyp6CagEdvfTVj4n+7UowrDyf a+Qz+ztXIMuSAXxgTQXRzAtSjt+MjVrWWihl9GzjoCaYRgBF6fScKCjQhLzer81NzPgM pteiAH866a70iFmIZ3kYt0E7LBn2/SCBYsfah6AfmaXgWSQijRDeer6+BiltHd5p+NB3 sKf1NwBsInYsdCs4e+N1pkNQ9rWmSA/z6+tM+bTzK7tWTKUxjR112cLscO/hyUac6wXo JatHPyjfN1nYKmL8uvFb/5VxD9s9Lrr8TfyWpsQDoyCt8NswiN5lNRDkYimisMCSmdwc NDUQ== X-Forwarded-Encrypted: i=1; AFNElJ+RZCvf32cyuZ4KivQ3ZK7c3dUuVk/7/wEfaVFbcGCKVTBdc9OBJJTBn06/niezDO0O8tgVcz8zI+bS@vger.kernel.org X-Gm-Message-State: AOJu0YxA6QR87YQGZOuEKEQgSjP2dfTecdSEq9iurSSBAu9+o7UQNIR8 NMy44ELWuYHF03cfF6OtqlVioG8SkoW6YYELIgCHXMphPiPKo3/vVGHtpgKSeWCRkxhkS+MBRRQ EY+izaYddlRLtTKiNhWEszJ8QVSA87W0/wBwLejVrN5VZAy7Xdl+CdajgCQ1stOJF X-Gm-Gg: AeBDieuAFtpar84hoCcx6JiHMkDWafvVUpTyJ5KnSsWN2xwcHZFu6LLvTIwJnsVClTW QCdO0LqjyXROvAG9Jt10cIIqMvYd9y7SlqRqpuG/u6jzUw3gsb/WHPRAJ7zyTyCllogssHMXopw z4TZZRpp35jGZCSFcPam2FNRa7IHidL9ynhMXMXRdgwsvJ5q8rUmfspIqHyzP1XBXsaemkUDlDN ARlKv2cqGnpFpMh+7F8J4hHzhrY46tOlC/yI0d/VPnUr1SxZeD8CMghjXXU/Ykgu5PsEl7hyp44 2R58hltuARLPBuNeRVLbwIElp2uGIh4n46qOGZ2NGP2RqR0gTTA04yZFaIlx/uBJL3k5KU/E/19 Bfwy9HJD/23Ux86Ddznq9Se20/6mMtl+xSi/5eJkr21+4iCdAQ2EgkOLvUJVhhf1CDjTPyOu6Ui IA33bkXOsapFkH+w== X-Received: by 2002:a05:6102:5885:b0:602:b87a:3524 with SMTP id ada2fe7eead31-627d5fe21c2mr1152103137.8.1777459425783; Wed, 29 Apr 2026 03:43:45 -0700 (PDT) X-Received: by 2002:a05:6102:5885:b0:602:b87a:3524 with SMTP id ada2fe7eead31-627d5fe21c2mr1152097137.8.1777459425334; Wed, 29 Apr 2026 03:43:45 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bb981b4ee3dsm76268566b.23.2026.04.29.03.43.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 03:43:44 -0700 (PDT) Message-ID: Date: Wed, 29 Apr 2026 12:43:41 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: slim7x: Add Embedded Controller node To: Daniel J Blueman , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Randy Dunlap Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Anvesh Jain P , Maya Matuszczyk , Krzysztof Kozlowski , Dmitry Baryshkov , Akhil P Oommen , Abel Vesa , Gaurav Kohli References: <20260429103301.17449-1-daniel@quora.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260429103301.17449-1-daniel@quora.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XtvK/1F9 c=1 sm=1 tr=0 ts=69f1e0e2 cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=t9ty7G3lAAAA:8 a=J7uTrBVL25gZzBqQJcQA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 a=CsAS6f0m0zARWR-uHzm3:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI5MDEwOCBTYWx0ZWRfX2k1xYAQLZF51 iO+lR1MQ6ss0TgYYcwHZlt9qETkMaMg5kJB4512XlXwXdvpsoP9kKhdM/l23d4VW8RfFNP5BTqA /5j/BtDCHm3fMDmcQuL4YK72qBtoZowLmjE5RB9GpJb2pfuHeG3w4E/6lZJ+DjcwgzBIBWYXdcc 3LLY59wY44iYlAJpO51MuJkZiyZAqmcs/LUsr3ur/LMxn/kKtGuJ/+8O+pA/aDtydN+wim2lL90 +sw88w1Y+cIn4uAgDBpH5yb0GTybfRNghgscBsY2G4Vb8Dza73sUGUOkEhbwyNJhExxc9Fc/Y0e Bj3miw7M6kb6HPVKik3mCEgop0POEHmO9yXm6bswdWxVdKsVhFgD2GginlTFlt9SFJMbgEV5LgD UTKTiJVEThfjuNpXjpSxaRWdze+qjKslyBQk484NYjlmuAsNKn3+LoMS4SFoix1i4StvCX4YeUW DyfdK1pCNS2ogKsY22w== X-Proofpoint-GUID: 7xGw2CIzdxJ0ca1wfOki99LlKeQfuRfP X-Proofpoint-ORIG-GUID: 7xGw2CIzdxJ0ca1wfOki99LlKeQfuRfP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604290108 On 4/29/26 12:32 PM, Daniel J Blueman wrote: > The Lenovo Slim7x uses the same Embedded Controller as the Qualcomm > Hamoa Customer Reference Device (X1). Wire it up for fan control, > thermal sensor and suspend behaviour. > > Dependencies: > https://lore.kernel.org/all/20260427-add-driver-for-ec-v8-0-702f74e495f7@oss.qualcomm.com/ This should not be part of the commit message - please put it under the --- line, so git doesn't keep it in history > > Signed-off-by: Daniel J Blueman > --- > .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > index beb1475d7fa0..22c4ad34a2a4 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts > @@ -951,6 +951,22 @@ retimer_ss0_con_sbu_out: endpoint { > }; > }; > > +&i2c5 { > + clock-frequency = <400000>; > + > + status = "okay"; > + > + embedded-controller@76 { > + compatible = "qcom,glymur-crd-ec", "qcom,hamoa-crd-ec"; This should have its own compatible. The Glymur CRD is a different laptop, with a different SoC. That will need a change to Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml so that dt validation passes Konrad