From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0744DC77B73 for ; Sun, 16 Apr 2023 17:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229588AbjDPRbG (ORCPT ); Sun, 16 Apr 2023 13:31:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjDPRbF (ORCPT ); Sun, 16 Apr 2023 13:31:05 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2E8E137 for ; Sun, 16 Apr 2023 10:31:03 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id kt6so20220425ejb.0 for ; Sun, 16 Apr 2023 10:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681666262; x=1684258262; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t2xdlz8zT+95r3jmtcx8udaHAYRhzx4/xxqNOYfEnyQ=; b=UPY/xgMpRi7Kh3LDgP73wLTw2JkroVmtHnv/SAQoKEFd9c1Wf02DTgKcc1vp/Kxr73 bdru6k/Dw1+Bm6LbrYS8dhsiZQOMSrbhyRRRX0meRpBqV/8g1Nx7ycJL5KjzZu+8gXPn aUjJe4lKUq8AenHDO+FCIYZWc76l/DCsxHz+15NYhpf+wBpRAn+tSFHrIBhhApOh++Gu TtZAW2J8607Q+zeHwPgkerUTI4O0T3R9rEtt/45UFrZbvYrYRiUN3JwNwgBHTMkt8fKv /8g+7NDp9FBTyowBuslUKfhZUdsPiCEg7MsPq3a0Q213pd85yUp4OubyfM0Djxbb3X7z e38Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681666262; x=1684258262; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t2xdlz8zT+95r3jmtcx8udaHAYRhzx4/xxqNOYfEnyQ=; b=RwcdkJ9cbU5aAkR0NFz1EIsamJ0+e8Ue3I3FfjrV7n5e0onxogz4zDifnBCpQqusjo GBVgfjB+Ql4AtHEUdVvOufIeGwVL4d8zuLZ9HA92xpIp5joXfwsWTHdpYTblfdguq17I nWPQUr+u7YKaAR3xL/H1KI2QbziWoZEGKQEHXglU491ceDuas7fZ8DPdrJ2zN2ihTJhj zi8I/0FNvoGF7CHiGirnPG05xIKyOz+IQ4FBN8pvrezl4bh6djtprwuYxYURq4LODsKJ hvcHRSZYOkOGGR1Ty1IVeR6+D4UA0iPp9I8YJ5lC8lkgSsxudq/WdCex+yjS1g00Bl2K 9Nkg== X-Gm-Message-State: AAQBX9dQhC6AfQYVhLdjzENaoQL6J1HlNXiovuvAo1o6dwXoNOVTUT0V rqm38bw3Noe3b9+To39HJ5NscA== X-Google-Smtp-Source: AKy350bBiTeu1+2CyyTo8pFcohBJFEKu8qa2Y86EZfdwvjg5nTgSrLcbsgbgwIeXPh0aZSNxI/5L/A== X-Received: by 2002:a17:906:2dd4:b0:94f:a03:3d3b with SMTP id h20-20020a1709062dd400b0094f0a033d3bmr4288204eji.20.1681666262173; Sun, 16 Apr 2023 10:31:02 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:f9e3:1d38:66a7:ae92? ([2a02:810d:15c0:828:f9e3:1d38:66a7:ae92]) by smtp.gmail.com with ESMTPSA id sg32-20020a170907a42000b008c16025b318sm5344804ejc.155.2023.04.16.10.31.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Apr 2023 10:31:01 -0700 (PDT) Message-ID: Date: Sun, 16 Apr 2023 19:31:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH V3 1/7] dt-bindings: rtc: Subdivision of LS2X RTC compatible Content-Language: en-US To: Binbin Zhou , Alessandro Zummo , Alexandre Belloni , Thomas Bogendoerfer , Jiaxun Yang , Huacai Chen , WANG Xuerui Cc: linux-rtc@vger.kernel.org, linux-mips@vger.kernel.org, loongarch@lists.linux.dev, Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, Qing Zhang , zhaoxiao , keguang.zhang@gmail.com References: <35f43a8cfc32b5a065e4a04eb6cc6abf311f2700.1681370153.git.zhoubinbin@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <35f43a8cfc32b5a065e4a04eb6cc6abf311f2700.1681370153.git.zhoubinbin@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13/04/2023 09:57, Binbin Zhou wrote: > The LS2X RTC alarm depends on the associated registers in a separate > power management domain. > > In order to define the PM domain addresses of the different chips, a > more detailed description of compatible is required. This does not match your diff at all. > > Signed-off-by: Binbin Zhou > --- > Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > index a3603e638c37..2928811b83a0 100644 > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml > @@ -47,8 +47,11 @@ properties: > - isil,isl1218 > # Intersil ISL12022 Real-time Clock > - isil,isl12022 > - # Loongson-2K Socs/LS7A bridge Real-time Clock > - - loongson,ls2x-rtc Why removing it? > + # Loongson LS7A bridge Real-time Clock > + - loongson,ls7a-rtc > + # Loongson-2K Socs Real-time Clock > + - loongson,ls2k0500-rtc > + - loongson,ls2k1000-rtc That's even more surprising... I don't understand what you are doing here at all. Best regards, Krzysztof