From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 08/15] arm64: dts: qcom: msm8996: add missing TCSR syscon compatible
Date: Tue, 20 Sep 2022 15:04:37 +0200 [thread overview]
Message-ID: <b4b61b0a-25a2-b435-4154-2ec2db2c289e@linaro.org> (raw)
In-Reply-To: <9f47ef0f-6e73-9ed4-55db-491d22c55c76@linaro.org>
On 20/09/2022 00:13, Dmitry Baryshkov wrote:
> On 09/09/2022 12:20, Krzysztof Kozlowski wrote:
>> TCSR syscon node should come with dedicated compatible.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> index 166374566a49..5f45d0589265 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>> @@ -3499,7 +3499,7 @@ frame@98c0000 {
>> };
>>
>> saw3: syscon@9a10000 {
>> - compatible = "syscon";
>> + compatible = "qcom,tcsr-msm8996", "syscon";
>
> No! saw3 is not a TCSR. It is a separate region, which should be managed
> by the SPM driver.
Indeed. Thanks for checking this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-20 13:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 9:20 [PATCH v3 00/15] ARM/hwlock: qcom: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 01/15] dt-bindings: hwlock: qcom-hwspinlock: add support for MMIO on older SoCs Krzysztof Kozlowski
2022-09-13 12:50 ` Rob Herring
2022-09-09 9:20 ` [PATCH v3 02/15] dt-bindings: hwlock: qcom-hwspinlock: correct example indentation Krzysztof Kozlowski
2022-09-13 12:51 ` Rob Herring
2022-09-09 9:20 ` [PATCH v3 03/15] hwspinlock: qcom: correct MMIO max register for newer SoCs Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 04/15] hwspinlock: qcom: add support for MMIO on older SoCs Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 05/15] arm64: dts: qcom: ipq6018: add missing TCSR syscon compatible Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 06/15] arm64: dts: qcom: msm8953: " Krzysztof Kozlowski
2022-09-13 22:36 ` Bjorn Andersson
2022-09-09 9:20 ` [PATCH v3 07/15] arm64: dts: qcom: qcs404: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 08/15] arm64: dts: qcom: msm8996: " Krzysztof Kozlowski
2022-09-19 22:13 ` Dmitry Baryshkov
2022-09-20 13:04 ` Krzysztof Kozlowski [this message]
2022-09-09 9:20 ` [PATCH v3 09/15] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 10/15] ARM: dts: qcom: msm8974: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-09-13 22:44 ` Bjorn Andersson
2022-09-15 14:49 ` Krzysztof Kozlowski
2022-09-19 21:01 ` Bjorn Andersson
2022-09-09 9:20 ` [PATCH v3 11/15] arm64: dts: qcom: ipq6018: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 12/15] arm64: dts: qcom: msm8994: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 13/15] ARM: dts: qcom: msm8974: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 14/15] ARM: dts: qcom: apq8084: " Krzysztof Kozlowski
2022-09-09 9:20 ` [PATCH v3 15/15] ARM: dts: qcom: msm8226: " Krzysztof Kozlowski
2022-09-13 22:43 ` (subset) [PATCH v3 00/15] ARM/hwlock: qcom: " Bjorn Andersson
2022-09-13 22:48 ` Bjorn Andersson
2022-09-19 22:14 ` Dmitry Baryshkov
2022-09-27 3:34 ` Bjorn Andersson
2022-09-27 3:36 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4b61b0a-25a2-b435-4154-2ec2db2c289e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).