From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3310CC41513 for ; Fri, 28 Jul 2023 07:31:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234285AbjG1Hbe (ORCPT ); Fri, 28 Jul 2023 03:31:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234190AbjG1Hbd (ORCPT ); Fri, 28 Jul 2023 03:31:33 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE15F2733 for ; Fri, 28 Jul 2023 00:31:30 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-991c786369cso246154866b.1 for ; Fri, 28 Jul 2023 00:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690529489; x=1691134289; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iJmb5dhR/A69axFp1n/g3w1WP4NZBl+VMQ8J3r8W4Go=; b=CMCbVYq2we1aK2YgyhLbvUPjHv8upf6iecEYG445wcF7z+ZtnBl11qU/H7Bj19u460 1y4KjJvJfBx/Vl3xllxT5aqmSQ6RH+kUFvp69q4awuzJ+EFcE6nLAhd70usmByNh691z ICJ/ReEyhmU1uDTH6tTDY4uIG1iI+9fyksVihIKHTbBLEi0FUqTHXHlKwRDu2CmKUeFE afBKX9LJQ9+HBerptlPVYAdx+LCppFn5rJjhopLk5cJwX/Ahf/DL5Zi8HATEbvYYUjxz cSvemKUlV8xr60sg1SAqQzPWhvm/zujwxNjGrk7F0W224PPu+rfjVL151HRgM2gmLCMZ hRcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690529489; x=1691134289; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iJmb5dhR/A69axFp1n/g3w1WP4NZBl+VMQ8J3r8W4Go=; b=hUv3CH9mcNf1mx8gJkR6jFmFjF4ON0U60Wr7mxpqeeiOuIYerq9wQJotLX7L2j+iqv U0g+W+nl5wySPI0l+4YVLF5572Xng2FZxLHCCwZyXIPumRDiVpNAJxcC9RY4X6vtmDaF 4gG0MH7DIGohz4WBGzcVkgjEAnik6EPbvNqPCuRH3QVhNzcOlAjgm8B56/UsnZoHD20J 6gaW7R5eXPLxjEkZXU0r8d+HkH+HS/wm3NBSelMLSnDKBaCWtF1lw3mVYvSs6//r17mB ZVMcoWRGYXopVuOOQUvU2QDMGmfLxNUBMtTwhVBMgI2lxEpGTs/klpzwna4c9sW8CYx5 wzZQ== X-Gm-Message-State: ABy/qLZN7p6M+lp008uMGxVk05PvlYoUu5Rbz1y1JQYE7ENJsTCt3qb6 eQ1AzCLjWAe0UKQIlKpaKYV+YA== X-Google-Smtp-Source: APBJJlFGeWYG4rS/QYddKDPW5upbEl7+O2bgJN59+hicqThEbi6BO/HJCDw6yicrvW9/cB7ORc4SlQ== X-Received: by 2002:a17:906:328d:b0:993:d1b6:61cc with SMTP id 13-20020a170906328d00b00993d1b661ccmr1157247ejw.44.1690529489331; Fri, 28 Jul 2023 00:31:29 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id u7-20020a170906408700b009786ae9ed50sm1698270ejj.194.2023.07.28.00.31.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 00:31:28 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 09:31:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] dt-bindings: leds: Add binding for Broadchip BCT3024 LED driver Content-Language: en-US To: Matus Gajdos , Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230727160525.23312-1-matuszpd@gmail.com> <20230727160525.23312-3-matuszpd@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230727160525.23312-3-matuszpd@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/07/2023 18:05, Matus Gajdos wrote: > The BCT3024 chip is an I2C LED driver with independent 24 output > channels. Each channel supports 256 levels. > > Signed-off-by: Matus Gajdos Thank you for your patch. There is something to discuss/improve. A nit, subject: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. > --- > .../bindings/leds/broadchip,bct3024.yaml | 89 +++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/broadchip,bct3024.yaml > > diff --git a/Documentation/devicetree/bindings/leds/broadchip,bct3024.yaml b/Documentation/devicetree/bindings/leds/broadchip,bct3024.yaml > new file mode 100644 > index 000000000000..0d622894e79c > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/broadchip,bct3024.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/broadchip,bct3024.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadchip BCT3024 LED Driver > + > +maintainers: > + - Matus Gajdos > + > +description: | > + The BCT3024 is an I2C LED driver with independent 24 output channels. Each > + channel supports 256 levels and its output current can be scaled by a factor > + of 1, 1/2, 1/3 and 1/4. > + > +properties: > + compatible: > + const: broadchip,bct3024 > + > + reg: > + description: I2C slave address of the driver. Drop description, it is obvious. > + maxItems: 1 > + > + vdd-supply: > + description: Regulator providing power to the VDD pin. > + > + shutdown-gpios: powerdown-gpios instead. See gpio-consumer-common.yaml > + maxItems: 1 And this won't be needed. > + description: GPIO attached to the SDB pin. > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + Best regards, Krzysztof