From: Krzysztof Kozlowski <krzk@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.au@gmail.com>
Subject: Re: [PATCH v3 6/6] arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS
Date: Wed, 12 Jun 2024 08:38:25 +0200 [thread overview]
Message-ID: <b4d04a73-22eb-44f3-af03-8f8686869c9e@kernel.org> (raw)
In-Reply-To: <20240611110402.58104-7-biju.das.jz@bp.renesas.com>
On 11/06/2024 13:04, Biju Das wrote:
> &phyrst {
> status = "okay";
> + usb0_vbus_otg: regulator-vbus {
> + regulator-name = "vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
These two voltages look unnecessary. You know the voltage of your LDO,
don't you? It's fixed, cannot be anything else.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-12 6:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 11:03 [PATCH v3 0/6] Add support for USB VBUS control for RZ/G2L SoCs Biju Das
2024-06-11 11:03 ` [PATCH v3 1/6] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl: Document USB VBUS regulator Biju Das
2024-06-12 6:37 ` Krzysztof Kozlowski
2024-06-12 6:51 ` Biju Das
2024-06-11 11:03 ` [PATCH v3 2/6] reset: renesas: Add USB VBUS regulator device as child Biju Das
2024-06-11 11:03 ` [PATCH v3 3/6] regulator: core: Add helper for allow access to enable register Biju Das
2024-06-11 14:59 ` Mark Brown
2024-06-11 16:28 ` Biju Das
2024-06-12 15:50 ` Mark Brown
2024-06-14 11:43 ` Biju Das
2024-06-14 14:31 ` Mark Brown
2024-06-14 15:52 ` Biju Das
2024-06-11 11:04 ` [PATCH v3 4/6] regulator: Add Renesas RZ/G2L USB VBUS regulator driver Biju Das
2024-06-11 11:04 ` [PATCH v3 6/6] arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS Biju Das
2024-06-12 6:38 ` Krzysztof Kozlowski [this message]
2024-06-12 6:52 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4d04a73-22eb-44f3-af03-8f8686869c9e@kernel.org \
--to=krzk@kernel.org \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox