From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA1B6C47088 for ; Fri, 2 Dec 2022 09:03:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233044AbiLBJDi (ORCPT ); Fri, 2 Dec 2022 04:03:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232608AbiLBJCz (ORCPT ); Fri, 2 Dec 2022 04:02:55 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B75E86CA28 for ; Fri, 2 Dec 2022 01:02:53 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id s8so6421250lfc.8 for ; Fri, 02 Dec 2022 01:02:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d357RzDjtKPp3WWfYQH7heJGal+F6FSfSLrUVjGFkq4=; b=mqQDCmyQG/5SbngulvRTuzJ+3MSK7nhUjoSr1pO3OsabBxMFkZxkO57kyM54zuuIlB KvuYqLNBYLzbVUlhIF1Xq9kJ/6T5lSjKU3IjlcPtmtmiNa8jFtHjtOI3fSz9iaDpi3Jf Z837xjUXND20xRlWba3kft1qe4e8wAn+2XlY/diMNcATQayBieQEt0z9pCv/7GK8PzVO X4h4rXXG7YuPpG99jceY92wBuxwH3OgCy8hSdkxXayq3uI0MAcLLJa1295zN3js5Y5N4 i1UOpLtoy0M08qaURXJlaVd/NPxCyq9yRsWjbLcgWzvqJ2oWNO2ZlskojhIVGPbrHO17 ybzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d357RzDjtKPp3WWfYQH7heJGal+F6FSfSLrUVjGFkq4=; b=m1uidRTXfGvFQJ+msMZdKvlAckSFA2s+lltl7htCCSN/WDPDjVdY0GsDWVy98zv/yq O/S+ATzi36KvYG9hx8bc9HnpLwl9wtgGXGw37y2bo1PAPHU7yLWnBznTRhIkIxlB0Nln zmG/a2jf3O5WGevbLDUM+wASbviCRdJcHduLpy7I86FnejxLSmIFfGtg52zbMxzPF5KC gcA9oSISKDVOP070/CZEucuAAL+BsqFoSTGEe2ToHUoIxfQPZe9/1We9a8+8pnJSiDJp KQzd39SEallN3LM9mMK64DEbBNfF8ghFFl46En6GKjHnEvjZUiHg2lJt9vLlhu6+3NUX 1E7Q== X-Gm-Message-State: ANoB5pmU5xHtyyBuMuH4CrizYL0CBsWAXTUAEUAFID/SRvqVIRfRiA+y htN79pBWtoVDxZXq8pm9puOMVg== X-Google-Smtp-Source: AA0mqf6orlGlnS1Quh4XPH1Nz+WLhaE31FI5CTQ7FzMVAJbD5FIAGwSYxFTHdfAgFkxWB1dNmxZ5EQ== X-Received: by 2002:a05:6512:b8f:b0:4a2:3953:7e43 with SMTP id b15-20020a0565120b8f00b004a239537e43mr18056878lfv.229.1669971772101; Fri, 02 Dec 2022 01:02:52 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id b6-20020ac25e86000000b004a95d5098f2sm948550lfq.226.2022.12.02.01.02.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Dec 2022 01:02:51 -0800 (PST) Message-ID: Date: Fri, 2 Dec 2022 10:02:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller Content-Language: en-US To: Icenowy Zheng , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Greg Kroah-Hartman , Matthias Kaehlcke , Andre Przywara Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20221202081647.3183870-1-uwu@icenowy.me> <20221202081647.3183870-3-uwu@icenowy.me> From: Krzysztof Kozlowski In-Reply-To: <20221202081647.3183870-3-uwu@icenowy.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/12/2022 09:16, Icenowy Zheng wrote: > The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that > features 4 downstream ports, an internal 5V-to-3.3V LDO regulator (can > be bypassed) and an external reset pin. > > Add a device tree binding for its USB protocol part. The internal LDO is > not covered by this and can just be modelled as a fixed regulator. > > Signed-off-by: Icenowy Zheng > --- > Changes in v2: > - Misc fixes suggested by Krzysztof, including property descriptions, > single-item "items" and fixing the example's gpio property. > - Fixed $id. > (...) > + > +examples: > + - | > + usb { > + dr_mode = "host"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + hub: hub@1 { > + compatible = "usb5e3,608"; > + reg = <1>; > + reset-gpios = <&pio 7 2>; Use GPIO flags. What did you fix in the example? Best regards, Krzysztof