From: Krzysztof Kozlowski <krzk@kernel.org>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] media: vgxy61: Add legacy compatible string
Date: Tue, 11 Jun 2024 08:47:25 +0200 [thread overview]
Message-ID: <b4de42ba-d884-44b1-9f0e-12f5818c6781@kernel.org> (raw)
In-Reply-To: <20240610150815.228790-3-benjamin.mugnier@foss.st.com>
On 10/06/2024 17:08, Benjamin Mugnier wrote:
> As the driver has been renamed from 'st-vgxy61' to 'vgxy61', its
> compatible string has been updated to reflect this change. Therefore old
> device trees will not work anymore.
> Add the old driver name as another compatible name to handle the
> retro compatibility.
>
> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
> drivers/media/i2c/vgxy61.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> index 30378e962016..ca3b43608dad 100644
> --- a/drivers/media/i2c/vgxy61.c
> +++ b/drivers/media/i2c/vgxy61.c
> @@ -1867,6 +1867,11 @@ static void vgxy61_remove(struct i2c_client *client)
> }
>
> static const struct of_device_id vgxy61_dt_ids[] = {
> + { .compatible = "st,vgxy61" },
> + /*
> + * Previously the driver was named 'st-vgxy61' instead of simply
> + * 'vgxy61', keep it for retrocompatibility purposes.
NAK.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-11 6:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 15:08 [PATCH 0/3] media: vgxy61: Remove vendor prefix from driver name Benjamin Mugnier
2024-06-10 15:08 ` [PATCH 1/3] media: vgxy61: Fix " Benjamin Mugnier
2024-06-11 6:47 ` Krzysztof Kozlowski
2024-06-10 15:08 ` [PATCH 2/3] media: vgxy61: Add legacy compatible string Benjamin Mugnier
2024-06-11 6:47 ` Krzysztof Kozlowski [this message]
2024-06-11 8:19 ` Sakari Ailus
2024-06-11 8:38 ` Krzysztof Kozlowski
2024-06-11 11:57 ` Benjamin Mugnier
2024-06-11 12:17 ` Krzysztof Kozlowski
2024-06-11 13:07 ` Benjamin Mugnier
2024-06-11 20:54 ` Krzysztof Kozlowski
2024-06-10 15:08 ` [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS() Benjamin Mugnier
2024-06-11 6:48 ` Krzysztof Kozlowski
2024-06-11 8:21 ` Sakari Ailus
2024-06-11 11:57 ` Benjamin Mugnier
2024-06-11 13:11 ` Sakari Ailus
2024-06-11 13:13 ` Benjamin Mugnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4de42ba-d884-44b1-9f0e-12f5818c6781@kernel.org \
--to=krzk@kernel.org \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).