From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>,
sboyd@kernel.org, andersson@kernel.org,
bjorn.andersson@linaro.org, david.brown@linaro.org,
devicetree@vger.kernel.org, jassisinghbrar@gmail.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
mark.rutland@arm.com, mturquette@baylibre.com, ohad@wizery.com,
robh@kernel.org, sricharan@codeaurora.org
Cc: gokulsri@codeaurora.org
Subject: Re: [PATCH v9 5/8] remoteproc: qcom: Update regmap offsets for halt register
Date: Fri, 21 Jun 2024 17:11:27 +0200 [thread overview]
Message-ID: <b4e474de-36bd-40ce-a7e3-4cd2ffdff000@kernel.org> (raw)
In-Reply-To: <20240621114659.2958170-6-quic_gokulsri@quicinc.com>
On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote:
> Fixed issue in reading halt-regs parameter from device-tree.
What issue?
That's a terrible commit msg. Explain what is the problem, how can it be
reproduced.
>
> Signed-off-by: Sricharan R <quic_srichara@quicinc.com>
> Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@quicinc.com>
> ---
> drivers/remoteproc/qcom_q6v5_wcss.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
> index 06936ca1d079..87b78eb15b86 100644
> --- a/drivers/remoteproc/qcom_q6v5_wcss.c
> +++ b/drivers/remoteproc/qcom_q6v5_wcss.c
> @@ -86,7 +86,7 @@
> #define TCSR_WCSS_CLK_MASK 0x1F
> #define TCSR_WCSS_CLK_ENABLE 0x14
>
> -#define MAX_HALT_REG 3
> +#define MAX_HALT_REG 4
? That's confusing and looks unrelated.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-21 15:11 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 11:46 [PATCH v9 0/8] remoteproc: qcom: q6v5-wcss: Add support for secure pil Gokul Sriram Palanisamy
2024-06-21 11:46 ` [PATCH v9 1/8] remoteproc: qcom: Add PRNG proxy clock Gokul Sriram Palanisamy
2024-06-21 15:09 ` Krzysztof Kozlowski
2024-06-25 4:25 ` Gokul Sriram P
2024-06-21 21:08 ` Dmitry Baryshkov
2024-06-25 5:33 ` Gokul Sriram P
2024-06-26 19:17 ` Dmitry Baryshkov
2024-06-27 10:01 ` Gokul Sriram P
2024-06-27 11:08 ` Dmitry Baryshkov
2024-06-27 11:29 ` Gokul Sriram P
2024-06-27 13:35 ` Dmitry Baryshkov
2024-06-21 11:46 ` [PATCH v9 2/8] remoteproc: qcom: Add secure PIL support Gokul Sriram Palanisamy
2024-06-21 21:17 ` Dmitry Baryshkov
2024-06-25 5:36 ` Gokul Sriram P
2024-06-21 11:46 ` [PATCH v9 3/8] remoteproc: qcom: Add support for split q6 + m3 wlan firmware Gokul Sriram Palanisamy
2024-06-27 11:11 ` Dmitry Baryshkov
2024-06-21 11:46 ` [PATCH v9 4/8] remoteproc: qcom: Add ssr subdevice identifier Gokul Sriram Palanisamy
2024-06-21 15:10 ` Krzysztof Kozlowski
[not found] ` <8adae0a7-d496-4c9f-ab0c-f162c06e90c4@quicinc.com>
2024-06-25 7:04 ` Krzysztof Kozlowski
2024-06-25 7:13 ` Dmitry Baryshkov
2024-06-21 21:23 ` Dmitry Baryshkov
2024-06-21 11:46 ` [PATCH v9 5/8] remoteproc: qcom: Update regmap offsets for halt register Gokul Sriram Palanisamy
2024-06-21 15:11 ` Krzysztof Kozlowski [this message]
2024-06-21 11:46 ` [PATCH v9 6/8] dt-bindings: clock: qcom: Add reset for WCSSAON Gokul Sriram Palanisamy
2024-06-21 15:12 ` Krzysztof Kozlowski
2024-06-21 16:17 ` Kathiravan Thirumoorthy
2024-06-21 11:46 ` [PATCH v9 7/8] clk: qcom: Add WCSSAON reset Gokul Sriram Palanisamy
2024-06-21 16:14 ` Kathiravan Thirumoorthy
2024-06-21 21:28 ` Dmitry Baryshkov
2024-06-21 11:46 ` [PATCH v9 8/8] arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC Gokul Sriram Palanisamy
2024-06-21 15:14 ` Krzysztof Kozlowski
2024-06-21 16:09 ` Kathiravan Thirumoorthy
2024-06-27 12:42 ` kernel test robot
2024-06-28 2:47 ` kernel test robot
2024-06-28 21:12 ` kernel test robot
2024-06-21 21:22 ` [PATCH v9 0/8] remoteproc: qcom: q6v5-wcss: Add support for secure pil Dmitry Baryshkov
2024-06-21 21:24 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4e474de-36bd-40ce-a7e3-4cd2ffdff000@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gokulsri@codeaurora.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=ohad@wizery.com \
--cc=quic_gokulsri@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).