From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64321C4332F for ; Fri, 11 Nov 2022 10:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233423AbiKKKuu (ORCPT ); Fri, 11 Nov 2022 05:50:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232182AbiKKKus (ORCPT ); Fri, 11 Nov 2022 05:50:48 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 689FF654F6 for ; Fri, 11 Nov 2022 02:50:39 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id c1so7767797lfi.7 for ; Fri, 11 Nov 2022 02:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=q6uzXd9rjr0+MjLzY/HrG+pQd4oP8LwDd91lEObJUaQ=; b=I9WKwUNhIR5elOxoGTRWpNTjG31YTLcg0Ktty6H3+BrT/cqTYe7o5P5iUL7WJFUnCH jNESdIU7GUhNIopL3UXPPS5cbBIjaTgZYqVeLF8Q9biYlbgsLBoGYi7FsNmc75pbyzXf W9oOTpZt9iyxAdBlU3YElS8nOlXyoXqaJ1rK6OwzcTjRyZI8J1KxvGx3xk+YtAVlHSKf gGq4xu2/bLNoYz+uaMCcFWOqUOiSDVZ8qjK9GlPTTxMvg7ljYZD7YEEbzAGWlPDOUSJH Q9JKS9mGf32vmmM9s9Kcn4Yxc/QEQ9P+i5M3fSseJHD+LdfwKEAkjY3Ya5HxgwgXf+0q G9/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q6uzXd9rjr0+MjLzY/HrG+pQd4oP8LwDd91lEObJUaQ=; b=yiGeFIRCG4xIu+cd/ecv1TZw3h5dn32JoYFD5kyYbJ4NHFdW2lLcVUj404ZUcoG0LY HTIscbji3dETVKkRFoOKWXNNjX3SrvaLCx82nKr3pxzP22D4T+UaMmlu2Yi1dPXy/eAQ /uF1/nSFQLvxCG+CByATSIPWT5TFEbrG76MwUGDHCgEjN0sveF4J6ZcZsX1+5EV2ffE2 kktXwjwHwjrc9TBASa8b/gXnjW/e8uHgxofc4Syf3TQ45Il0uosyOB0BXRHDuW53EdvN eQsAtS2GBNii1QcZxseNEcRvCFU33FW57teZnRew0XY9Ez42YkTov1uiOFKgiJka7XrL lQ/w== X-Gm-Message-State: ANoB5pnS+Q4rU5oP7DaZuqsBwj6A5T0OgwNFSgP4i+XN7SE4Ju6XyS+v EgG/aBggeTcetEr06TxW4oreyg== X-Google-Smtp-Source: AA0mqf6cgJitB+6WrjolHrR4FTBiJloBk88LOICcNXtAeUiCVl88D+f0zoTJ4+uDUUmEJqCHTZJxTg== X-Received: by 2002:a05:6512:401d:b0:4b1:25ff:28aa with SMTP id br29-20020a056512401d00b004b125ff28aamr517492lfb.547.1668163837807; Fri, 11 Nov 2022 02:50:37 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id q26-20020a2eb4ba000000b0026e0434eb1esm327348ljm.67.2022.11.11.02.50.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 02:50:37 -0800 (PST) Message-ID: Date: Fri, 11 Nov 2022 11:50:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r9a09g011: Add system configuration node Content-Language: en-US To: Biju Das , Rob Herring , Krzysztof Kozlowski Cc: Geert Uytterhoeven , Magnus Damm , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , Chris Paterson , Fabrizio Castro References: <20221110162126.103437-1-biju.das.jz@bp.renesas.com> <20221110162126.103437-4-biju.das.jz@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/11/2022 10:10, Biju Das wrote: > Hi Krzysztof Kozlowski, > > Thanks for the feedback. > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: 11 November 2022 08:35 >> To: Biju Das ; Rob Herring ; >> Krzysztof Kozlowski >> Cc: Geert Uytterhoeven ; Magnus Damm >> ; linux-renesas-soc@vger.kernel.org; >> devicetree@vger.kernel.org; Chris Paterson ; >> Fabrizio Castro >> Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: r9a09g011: Add system >> configuration node >> >> On 10/11/2022 17:21, Biju Das wrote: >>> Add system configuration node to RZ/V2M SoC dtsi. >>> >>> Signed-off-by: Biju Das >>> --- >>> v2: >>> * New patch >>> --- >>> arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi >> b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi >>> index 7b949e40745a..07164d9e4a0f 100644 >>> --- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi >>> +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi >>> @@ -130,6 +130,12 @@ cpg: clock-controller@a3500000 { >>> #power-domain-cells = <0>; >>> }; >>> >>> + sysc: system-configuration@a3f03000 { >>> + compatible = "renesas,r9a09g011-sys"; >>> + reg = <0 0xa3f03000 0 0x400>; >>> + status = "disabled"; >> >> Why disabled? You do not have any other resources needed. This is odd. > > OK, will enable by default. Currently the driver compatible is used for getting SoC > Major and Minor versions. But later will enhance to support more features. Whatever your driver is doing, should be rather independent of enabling/disabling nodes in DTS. Generic rule is that all SoC components, which do not need external resources from board, should be enabled by default. Of course there are exceptions to this rule. DTS is anyway description of hardware, so "driver compatible" is not appropriate argument for this (or I miss the meaning behind this). Best regards, Krzysztof