Re: [PATCH 1/1] arm64: dts: imx93: Fix anatop node size

[Peng Fan <peng.fan@oss.nxp.com>]

On 7/28/2023 4:34 PM, Alexander Stein wrote:
> 
> 
> Although the memory map of i.MX93 reference manual rev. 2 claims that
> analog top has start address of 0x44480000 and end address of 0x4448ffff,
> this overlaps with TMU memory area starting at 0x44482000, as stated in
> section 73.6.1.
> As PLL configuration registers start at addresses up to 0x44481400, as used
> by clk-imx93, reduce the anatop size to 0x2000, so exclude the TMU area
> but keep all PLL registers inside.
> 
> Fixes: ec8b5b5058ea ("arm64: dts: freescale: Add i.MX93 dtsi support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
> Unfortunately TMU isn't listed in memory map, so it was a bit of guess work.
> 
> This fixes the probe failure of qoriq_thermal:
> qoriq_thermal 44482000.tmu: can't request region for resource [mem 0x44482000-0x44482fff]
> qoriq_thermal 44482000.tmu: Failed to get memory region
> qoriq_thermal: probe of 44482000.tmu failed with error -16
> 
> /proc/iomem also shows it's claimed by anatop:
>> 44480000-4448ffff : 44450000.clock-controller anatop@44480000
> 
>   arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 4ec9df78f2050..6f85a05ee7e1a 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -379,7 +379,7 @@ mediamix: power-domain@44462400 {
> 
>                          anatop: anatop@44480000 {
>                                  compatible = "fsl,imx93-anatop", "syscon";
> -                               reg = <0x44480000 0x10000>;
> +                               reg = <0x44480000 0x2000>;
>                          };
> 
>                          tmu: tmu@44482000 {
> --
> 2.34.1
>