From: Stefan Agner <stefan@agner.ch>
To: Meng Yi <meng.yi@nxp.com>
Cc: jianwei.wang.chn@gmail.com, devicetree@vger.kernel.org,
emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org,
robh+dt@kernel.org, shawnguo@kernel.org,
alexander.stein@systec-electronic.com
Subject: Re: [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document
Date: Wed, 13 Jul 2016 23:30:16 -0700 [thread overview]
Message-ID: <b4f91421f79f297b04b279056257d110@agner.ch> (raw)
In-Reply-To: <1467188278-10978-1-git-send-email-meng.yi@nxp.com>
On 2016-06-29 01:17, Meng Yi wrote:
> dropped the old "fsl,panel" property, using the of_graph dt
> binding syntax
>
> Signed-off-by: Meng Yi <meng.yi@nxp.com>
> ---
> Changes in V2:
> -drop the unit address of port
> ---
> Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt
> b/Documentation/devicetree/bindings/display/fsl,dcu.txt
> index ae55cde..c96ec1f 100644
> --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt
> +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt
> @@ -12,7 +12,7 @@ Required properties:
> - clock-names: Should be "dcu" and "pix"
> See ../clocks/clock-bindings.txt for details.
> - big-endian Boolean property, LS1021A DCU registers are big-endian.
> -- fsl,panel: The phandle to panel node.
> +- port Video port for the panel output
>
> Optional properties:
> - fsl,tcon: The phandle to the timing controller node.
> @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 {
> clocks = <&platform_clk 0>, <&platform_clk 0>;
> clock-names = "dcu", "pix";
> big-endian;
> - fsl,panel = <&panel>;
> fsl,tcon = <&tcon>;
> +
> + port: port {
Port does not need a label here.
> + dcu_out: endpoint {
> + remote-endpoint = <&panel_out>;
> + };
> + };
> };
Otherwise looks good. However, I would prefer to have this change as
part of the corresponding driver change. Can you squash that into the
"drm/fsl-dcu: rework codes to support of_graph dt binding for panel"
patch?
--
Stefan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-07-14 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 8:17 [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Meng Yi
[not found] ` <1467188278-10978-1-git-send-email-meng.yi-3arQi8VN3Tc@public.gmane.org>
2016-06-29 8:17 ` [PATCH v2 2/2] drm/fsl-dcu: update panel syntax to of_graph dt binding Meng Yi
2016-07-14 6:36 ` Stefan Agner
2016-07-01 1:37 ` [PATCH v2 1/2] drm/fsl-dcu: update the panel dt binding document Rob Herring
2016-07-14 6:30 ` Stefan Agner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f91421f79f297b04b279056257d110@agner.ch \
--to=stefan@agner.ch \
--cc=alexander.stein@systec-electronic.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jianwei.wang.chn@gmail.com \
--cc=meng.yi@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).