From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Andersson <andersson@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Michal Simek <michal.simek@amd.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Nishanth Menon <nm@ti.com>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH] docs: dt-bindings: add DTS Coding Style document
Date: Mon, 20 Nov 2023 08:12:58 +0100 [thread overview]
Message-ID: <b502d655-5b01-4e23-8100-237f3b38f94a@linaro.org> (raw)
In-Reply-To: <7592981.EvYhyI6sBW@phil>
On 16/11/2023 21:33, Heiko Stuebner wrote:
>> regulator-state-mem {
>> regulator-off-in-suspend;
>> };
>>
>> What exactly would be here misordered?
>
> going with the vcc5v0_host regulator of the rk3588-quartzpro64 and
>
> +1. compatible
> +2. reg
> +3. ranges
> +4. All properties with values
> +5. Boolean properties
> +6. status (if applicable)
> +7. Child nodes
>
> we'd end up with
>
> vcc5v0_host: vcc5v0-host-regulator {
> /* 1. */ compatible = "regulator-fixed";
> /* 4. */ gpio = <&gpio4 RK_PB0 GPIO_ACTIVE_HIGH>;
> pinctrl-names = "default";
> pinctrl-0 = <&vcc5v0_host_en>;
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> regulator-name = "vcc5v0_host";
> vin-supply = <&vcc5v0_usb>;
> /* 5. */ enable-active-high;
> regulator-always-on;
> regulator-boot-on;
> };
>
> which I find somewhat counter-intuitive ;-) .
Yes, good point.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-20 7:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 18:12 [PATCH] docs: dt-bindings: add DTS Coding Style document Krzysztof Kozlowski
2023-11-16 19:26 ` Heiko Stuebner
2023-11-16 19:51 ` Krzysztof Kozlowski
2023-11-16 20:03 ` Heiko Stuebner
2023-11-16 20:23 ` Krzysztof Kozlowski
2023-11-16 20:33 ` Heiko Stuebner
2023-11-17 14:03 ` Andrew Davis
2023-11-17 19:38 ` Heiko Stübner
2023-11-17 19:54 ` Andrew Davis
2023-11-17 20:04 ` Heiko Stübner
2023-11-18 11:25 ` Geert Uytterhoeven
2023-11-20 7:12 ` Krzysztof Kozlowski [this message]
2023-11-16 20:44 ` Rob Herring
2023-11-17 23:55 ` Konrad Dybcio
2023-11-20 7:19 ` Krzysztof Kozlowski
2023-11-16 21:27 ` Conor Dooley
2023-11-20 7:14 ` Krzysztof Kozlowski
2023-11-16 21:32 ` Geert Uytterhoeven
2023-11-20 7:16 ` Krzysztof Kozlowski
2023-11-17 23:53 ` Konrad Dybcio
2023-11-20 7:15 ` Krzysztof Kozlowski
2023-11-17 23:58 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b502d655-5b01-4e23-8100-237f3b38f94a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=nm@ti.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).