From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3AD6C43334 for ; Wed, 15 Jun 2022 09:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234780AbiFOJPf (ORCPT ); Wed, 15 Jun 2022 05:15:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347790AbiFOJOt (ORCPT ); Wed, 15 Jun 2022 05:14:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC68239826; Wed, 15 Jun 2022 02:14:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 86D4361A39; Wed, 15 Jun 2022 09:14:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 091D9C34115; Wed, 15 Jun 2022 09:14:44 +0000 (UTC) Message-ID: Date: Wed, 15 Jun 2022 11:14:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 3/9] vivid: add dynamic array test control Content-Language: en-US To: Laurent Pinchart , Xavier Roumegue Cc: mchehab@kernel.org, stanimir.varbanov@linaro.org, tomi.valkeinen@ideasonboard.com, robh+dt@kernel.org, nicolas@ndufresne.ca, alexander.stein@ew.tq-group.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org References: <20220503093925.876640-1-xavier.roumegue@oss.nxp.com> <20220503093925.876640-4-xavier.roumegue@oss.nxp.com> From: Hans Verkuil In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Laurent, Xavier, Ignore what I wrote before, I read it with the HEVC patch series in mind, not the dw100 series. So let me try again :-) On 6/14/22 23:00, Laurent Pinchart wrote: > Hi Xavier and Hans, > > Thank you for the patch. > > On Tue, May 03, 2022 at 11:39:19AM +0200, Xavier Roumegue wrote: >> From: Hans Verkuil >> >> Add a dynamic array test control to help test support for this >> feature. >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/test-drivers/vivid/vivid-ctrls.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/media/test-drivers/vivid/vivid-ctrls.c b/drivers/media/test-drivers/vivid/vivid-ctrls.c >> index e7516dc1227b..7267892dc18a 100644 >> --- a/drivers/media/test-drivers/vivid/vivid-ctrls.c >> +++ b/drivers/media/test-drivers/vivid/vivid-ctrls.c >> @@ -34,6 +34,7 @@ >> #define VIVID_CID_U8_4D_ARRAY (VIVID_CID_CUSTOM_BASE + 10) >> #define VIVID_CID_AREA (VIVID_CID_CUSTOM_BASE + 11) >> #define VIVID_CID_RO_INTEGER (VIVID_CID_CUSTOM_BASE + 12) >> +#define VIVID_CID_U32_DYN_ARRAY (VIVID_CID_CUSTOM_BASE + 13) >> >> #define VIVID_CID_VIVID_BASE (0x00f00000 | 0xf000) >> #define VIVID_CID_VIVID_CLASS (0x00f00000 | 1) >> @@ -189,6 +190,19 @@ static const struct v4l2_ctrl_config vivid_ctrl_u32_array = { >> .dims = { 1 }, >> }; >> >> +static const struct v4l2_ctrl_config vivid_ctrl_u32_dyn_array = { >> + .ops = &vivid_user_gen_ctrl_ops, >> + .id = VIVID_CID_U32_DYN_ARRAY, >> + .name = "U32 Dynamic Array", >> + .type = V4L2_CTRL_TYPE_U32, >> + .flags = V4L2_CTRL_FLAG_DYNAMIC_ARRAY, >> + .def = 50, >> + .min = 10, >> + .max = 90, >> + .step = 1, >> + .dims = { 100 }, >> +}; > > To meaningfully test this, don't we need the vivid driver to change the > dimension ? Or is it meant to only test changes made by the application > ? As I understand it the dw100 driver needs a 2 dimensional array control. The size is fixed for each resolution, but if the resolution changes, then this control changes size as well, and it makes sense that when that happens it is also reset to default values. So this isn't a dynamic array at all. It is a standard 2 dimensional array. What is missing in the control framework is a function similar to v4l2_ctrl_modify_range() that can resize an array. v4l2_ctrl_modify_dimensions() would be a good name. I can make something for that if you both agree with this proposal. Regards, Hans > >> + >> static const struct v4l2_ctrl_config vivid_ctrl_u16_matrix = { >> .ops = &vivid_user_gen_ctrl_ops, >> .id = VIVID_CID_U16_MATRIX, >> @@ -1612,6 +1626,7 @@ int vivid_create_controls(struct vivid_dev *dev, bool show_ccs_cap, >> dev->ro_int32 = v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_ro_int32, NULL); >> v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_area, NULL); >> v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u32_array, NULL); >> + v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u32_dyn_array, NULL); >> v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u16_matrix, NULL); >> v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u8_4d_array, NULL); >> >