From: <Conor.Dooley@microchip.com>
To: <mail@conchuod.ie>, <Daire.McNamara@microchip.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>
Cc: <palmer@dabbelt.com>, <linux-riscv@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] riscv: dts: microchip: remove ti,fifo-depth property
Date: Thu, 11 Aug 2022 20:42:35 +0000 [thread overview]
Message-ID: <b51b78c7-6b75-908e-53de-6585cdd32deb@microchip.com> (raw)
In-Reply-To: <20220811203207.179470-1-mail@conchuod.ie>
On 11/08/2022 21:32, Conor Dooley wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Upgrading dt-schema to v2022.08 brings with it better handling of
> unevaluatedProperties, exposing a previously undetected missing
> property in the cadence macb dt-binding:
>
> arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dtb: ethernet@20112000: ethernet-phy@8: Unevaluated properties are not allowed ('ti,fifo-depth' was unexpected)
> From schema: Documentation/devicetree/bindings/net/cdns,macb.yaml
>
> I know what you're thinking, the binding doesn't look to be the problem
> and I agree. I am not sure why a TI vendor property was ever actually
> added since it has no meaning... just get rid of it.
>
> Fixes: 0fa6107eca41 ("RISC-V: Initial DTS for Microchip ICICLE board")
Fixes: bc47b2217f24 ("riscv: dts: microchip: add the sundance polarberry")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts | 2 --
> arch/riscv/boot/dts/microchip/mpfs-polarberry.dts | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> index 044982a11df5..ee548ab61a2a 100644
> --- a/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts
> @@ -84,12 +84,10 @@ &mac1 {
>
> phy1: ethernet-phy@9 {
> reg = <9>;
> - ti,fifo-depth = <0x1>;
> };
>
> phy0: ethernet-phy@8 {
> reg = <8>;
> - ti,fifo-depth = <0x1>;
> };
> };
>
> diff --git a/arch/riscv/boot/dts/microchip/mpfs-polarberry.dts b/arch/riscv/boot/dts/microchip/mpfs-polarberry.dts
> index 82c93c8f5c17..dc11bb8fc833 100644
> --- a/arch/riscv/boot/dts/microchip/mpfs-polarberry.dts
> +++ b/arch/riscv/boot/dts/microchip/mpfs-polarberry.dts
> @@ -54,12 +54,10 @@ &mac1 {
>
> phy1: ethernet-phy@5 {
> reg = <5>;
> - ti,fifo-depth = <0x01>;
> };
>
> phy0: ethernet-phy@4 {
> reg = <4>;
> - ti,fifo-depth = <0x01>;
> };
> };
>
> --
> 2.37.1
>
prev parent reply other threads:[~2022-08-11 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 20:32 [PATCH] riscv: dts: microchip: remove ti,fifo-depth property Conor Dooley
2022-08-11 20:42 ` Conor.Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b51b78c7-6b75-908e-53de-6585cdd32deb@microchip.com \
--to=conor.dooley@microchip.com \
--cc=Daire.McNamara@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mail@conchuod.ie \
--cc=palmer@dabbelt.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).