From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 508963C1089 for ; Thu, 16 Jul 2026 17:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784222242; cv=none; b=SRoP8bQkqL5C1N543O+k6EXi9IPPQAI3sVcwCqDJUrPC6QEP8f0qus83DIJwytrFCD9VMtEW6cwyArN+LzrxSOzjoAG1oWPsqr+P4A3PZ2nzB054xxZZLblWk5GNn+Hgl3eymVDIqVvmWWn9ZrrKQ2jBF8V5xZFZGUBqXaPH8h8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784222242; c=relaxed/simple; bh=yhjO9foj3wfTz126q4+ORECWPTnHtF0SfAfrvQrOr24=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A7GWR12nKW3JkP4w1DcvBxw+fIhQV6QROthuGrU6NgJqwK8LmtAoFfqRLm5seE8Og0sHo+ilFvQNEgVlkqzWY6rN6Pfd3XHZa9nj01nMuNJTaChiNOJ/50cEeLpnYQ01MuYeE/uthhQa5krvpZWkUZ97oAVDBOI6gz1uKaIKYsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dJYngoBn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CI6s7Q3q; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dJYngoBn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CI6s7Q3q" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GGSiTY3387459 for ; Thu, 16 Jul 2026 17:17:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RLyka2dGDlxqyY4LBXDQg+Mr3NeguU+JffNAcDddFJ0=; b=dJYngoBnuFcZ5nZW RUyQ3eRVKm4KJ43FVH1TQtMskakIkhd/QBMcF3jHQVEuBOh8l7cFzBjxVDePCMFF 5t9pilhUfyDKDRVRNjdkWLsbGrbr6UFHzVK/Wf4CbOdPrHb8P3Y4YZ/a3mfqmg9o Trv2wp2tiR3HHbsBDsUeOaRMvMtESEMsRD+KMqqb2aFaGCUkpJ14COqRaPCLwAad HlkMegi6OVzg/ESGWzASpmZ6E2L+NXZzhBA1X32A9MPXZPRn2jXubf0tuIU5FYux zxarc9uVM/6/2xem0dQTdzEePYOATgHNC2S3VxSRoMoRMA22omgpPgPab1j+43iw HAyWqg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fen4wbrp1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 17:17:19 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51e9d892f0dso3498211cf.2 for ; Thu, 16 Jul 2026 10:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784222238; x=1784827038; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RLyka2dGDlxqyY4LBXDQg+Mr3NeguU+JffNAcDddFJ0=; b=CI6s7Q3q4Ch7E6ZC3BofwLLzrsdGf/g4rPnB3rGUay8ptl0M9WJJ3u3Fvm5HeZ+9P9 zHUvkiNgDF64UY9sut7EwCsciWtuWU2gqHbdQk75t1kqBq0QN6Wr+itwJruAa2dbXkZH bj0jcTPkJtyxeGCq529+hCoA+s6BPWv7zd+Dkcs8PmQCYiVf1RDAoZZaT1oJoXamG3zT Pk6mstReyntg/rI8JNEKMXoQF81U9F8Hir3/7hmDbRNGUHJRyVRwsXFFzRN7OOHOW8gb NuB43bJAIgW5RWM6EpIs4lIWkskElNXz56B7mcPupSEOCSN5fxsIw1cayfQJwvwpVp07 j2mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784222238; x=1784827038; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RLyka2dGDlxqyY4LBXDQg+Mr3NeguU+JffNAcDddFJ0=; b=CAigmpkeNz3t8/at0HusqbECo1UK3MDscF/YzQCA9Wo83AaTmsbJq/r/alI4/gEkMo w+TWRJUDqPWhgCkAiycSPwCxQaQvTbDiDDSFqV0A4af8d4g12xyUFZUjO3n0RCV/kPBt yg26xIQLHXsWVvJgcjIOeZku6KCammwb5wavCzzStHOIvm4td7I9rdqJkVvR7u2HqiGK DtT1ZoZURlSbMPsW67gWwv49Gk1vY2mGkJ8qPlxXUv2irjUjXgS+fHdUyOtCcrg93j/o SvcLnH3ZomgzFFkcDsPJDotY4zr8AcPT4Zyu0jXF9P5uYcqUMl0pnRYBbsDV9OQnSe1U LbJA== X-Forwarded-Encrypted: i=1; AHgh+RrUJWcfyoIy8o6StGyz3rq+Iq3RKzHvgPhRyElfXob3fCgLGflncj0cOda72rVvqSz9Z9NzIQKn07FW@vger.kernel.org X-Gm-Message-State: AOJu0YwDQqq44K2wV9RHhR9IVza9GkcHcAzHq52yWWTi4KfkSM4Mu3oM bLvVtOHWXbtDWF+VUQeRn/iXn0cI6hsHtMbwbPVwk896s3uWDlgB6PS0WDdoKR/cchSYZoQh9Dw WNd09k8nAI7KmOew3TS1LifTykYEvg1jygz35o8aJnMwkUIT3n7XJS764iCW/68IP X-Gm-Gg: AfdE7ckFA8hR478Yq7eL2oCigBLY+VPaOIBgQxaXBAO4iXU0CRiSrWNdsRzFX41grdA fr+OpTwnG4PIvCFbiyzmE8ijWGhX1oNAdfl80FYq8T1l40tTvm2YgV0e7bIajVVfQfNvFgmUUvl JA19SuBltBYwaPQgzVqKUkWFYjc+EBg7UwiTxnDaRH1NUS4UVV9faX6BtsXPueXK6d1VPxIVQga GnBDNObifKG6z3kFnjU3RLsN5/IxnmSH01DlT7nv+gfkEIPITl73eJTdqNu+Y8kg//i1QWGgy0k zrNDL4ZtJznWoiwnzFcrLBf0ZEAv/tjHjWjPKIllumdCP7c/A9vHyIAGkaPaxmGIOIZ6MZTjntG GtYjrvUjSYLIpaJQqRVCWtSjT X-Received: by 2002:ac8:7f88:0:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-51cbf32f49dmr191490781cf.11.1784222238389; Thu, 16 Jul 2026 10:17:18 -0700 (PDT) X-Received: by 2002:ac8:7f88:0:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-51cbf32f49dmr191490351cf.11.1784222237777; Thu, 16 Jul 2026 10:17:17 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c16871264c5sm259740166b.2.2026.07.16.10.17.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 10:17:16 -0700 (PDT) Message-ID: Date: Thu, 16 Jul 2026 19:17:14 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/6] arm64: dts: qcom: Add device tree for Nord RRD board To: Shawn Guo , Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Deepti Jaggi , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20260716142605.2398433-1-shengchao.guo@oss.qualcomm.com> <20260716142605.2398433-7-shengchao.guo@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260716142605.2398433-7-shengchao.guo@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=PsejqQM3 c=1 sm=1 tr=0 ts=6a59121f cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=JYDhkS4F_D_NCfCrlLEA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: o_R5kPTU3CQX4DHcsT-1li2UcIkJwzOr X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDE3NiBTYWx0ZWRfXyclIjYaZzLX4 oEqs/QUD2tscjmmsD0N/IbN3JwZuPDLVxKT0MML1zbhpWkmf3BurXYru8k1PF0LI7VQ27HDhqPU dvNWVdoqs8mMOrcYMovM++e1B4jhXMw= X-Proofpoint-ORIG-GUID: o_R5kPTU3CQX4DHcsT-1li2UcIkJwzOr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDE3NiBTYWx0ZWRfX1Ed78seD0mmb EQjiJalZle+nNEm+Q9dSNr0Ya3uHyQOSjpzetggvn6mwuAbpjoBts640r1rMgj8oVJUFhuyqYWj /Ny6fy3GMgCsAqx3oedYzCdVb/ISonfIKR/4V+IPLJZ0rAtTjQ+PVHhkrIZCWVZRAix1xb0BdfZ 3NmOnjSxmvnfJBzHrFz3Me66kLrognNcjnvmnP1I3X9pqlo8pYJ1rg4p7PaFTttYcA39en9OUpc 7+8Id50i8TFqKRc4EjIRl/gJT7TZCUVOAr2rVGTOmrOP2W7wv4UHQNyN9jTOL24GvgEf9AYdNFQ lXWWhZ97Jv/i7tDd+4hD/J0s7N1goVZe2cQS1y57UDUlATMkiK2caxAKsSOZkgt5Drp88TwJ+EN h42E8d52BoiSkCQyw9gITV+ow+xIgeyIVCX1Sn7qQ1jSW5hfZbQ4Tfwdqa9jCRaCRLZ5t6r0CYY f1ZvifCeGd1vDviv7eg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_06,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160176 On 7/16/26 4:26 PM, Shawn Guo wrote: > Add initial device tree for the Qualcomm Dragonwing IQ10 RRD (Robotics > Reference Design) board, which is built on Nord Embedded variant. Enable > the debug UART, UFS storage, PMICs, I2C and SPI. > > Co-developed-by: Bartosz Golaszewski > Signed-off-by: Bartosz Golaszewski > Signed-off-by: Shawn Guo > --- [...] > + /* PMIC A - Kobra_MM (PMM8650AU) - SID 0x0, Bus E0 */ This comment is very useful > + regulators-0 { > + compatible = "qcom,pmm8654au-rpmh-regulators"; > + qcom,pmic-id = "A_E0"; > + > + /* LDO Regulators */ This is much less so [...] > + vreg_l7a_1p2: ldo7 { > + regulator-name = "vreg_l7a_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-initial-mode = ; > + regulator-always-on; > + regulator-boot-on; > + regulator-allow-set-load; You made a lot of the regulators always-/boot-on - are you sure about each one of them? > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; It's commonplace to restrict regulators to HPM only because not all of the drivers that should be voting on desired load actually do it. Do you have any intermittent failures, particularly around PHYs? [...] > +&i2c7 { > + clock-frequency = <400000>; > + > + status = "okay"; It's commonplace to add comments like: /* Type-C controller @ 0x15 */ Otherwise this lgtm Reviewed-by: Konrad Dybcio Konrad